Add knip linter (#36442)

This adds [knip](https://github.com/webpro-nl/knip), a tool to find
unused files, dependencies and exports in JS. Fixed all discovered
issues.

1. knip apparently has some issue resolving imports from `d.ts` to `.ts`
so I worked around it by moving the two affected types to where they are
used.
2. I don't know why `modules/fomantic/dropdown.ts` had a new typescript
error, but I fixed it.
3. Use named export for `EsbuildPlugin`, I think this was added
recently.

web_src/js/features/tribute.ts

@@ -29,7 +29,7 @@ export async function attachTribute(element: HTMLElement) {
         return html`<div class="tribute-item">${htmlRaw(emojiHTML(item.original))}<span>${item.original}</span></div>`;
       },
     }, { // mentions
-      values: window.config.mentionValues ?? [],
+      values: window.config.mentionValues,
       requireLeadingSpace: true,
       menuItemTemplate: (item: TributeItem) => {
         const fullNameHtml = item.original.fullname && item.original.fullname !== '' ? html`<span class="fullname">${item.original.fullname}</span>` : '';

web_src/js/globals.d.ts

@@ -49,7 +49,26 @@ interface Element {
 }
 
 interface Window {
-  config: import('./web_src/js/types.ts').Config;
+  config: {
+    appUrl: string,
+    appSubUrl: string,
+    assetVersionEncoded: string,
+    assetUrlPrefix: string,
+    runModeIsProd: boolean,
+    customEmojis: Record<string, string>,
+    pageData: Record<string, any>,
+    notificationSettings: Record<string, any>,
+    enableTimeTracking: boolean,
+    mentionValues: Array<{
+      key: string,
+      value: string,
+      name: string,
+      fullname: string,
+      avatar: string,
+    }>,
+    mermaidMaxSourceCharacters: number,
+    i18n: Record<string, string>,
+  },
   $: typeof import('@types/jquery'),
   jQuery: typeof import('@types/jquery'),
   htmx: typeof import('htmx.org').default,

web_src/js/markup/refissue.ts

@@ -11,7 +11,7 @@ export function initMarkupRefIssue(el: HTMLElement) {
   });
 }
 
-export function showMarkupRefIssuePopup(e: MouseEvent | FocusEvent) {
+function showMarkupRefIssuePopup(e: MouseEvent | FocusEvent) {
   const refIssue = e.currentTarget as HTMLElement;
   if (getAttachedTippyInstance(refIssue)) return;
   if (refIssue.classList.contains('ref-external-issue')) return;

web_src/js/markup/render-iframe.ts

@@ -1,7 +1,7 @@
 import {generateElemId, queryElemChildren} from '../utils/dom.ts';
 import {isDarkTheme} from '../utils.ts';
 
-export async function loadRenderIframeContent(iframe: HTMLIFrameElement) {
+async function loadRenderIframeContent(iframe: HTMLIFrameElement) {
   const iframeSrcUrl = iframe.getAttribute('data-src')!;
   if (!iframe.id) iframe.id = generateElemId('gitea-iframe-');
 

web_src/js/modules/fomantic/dropdown.ts

@@ -65,7 +65,7 @@ function updateSelectionLabel(label: HTMLElement) {
   const deleteIcon = label.querySelector('.delete.icon');
   if (deleteIcon) {
     deleteIcon.setAttribute('aria-hidden', 'false');
-    deleteIcon.setAttribute('aria-label', window.config.i18n.remove_label_str.replace('%s', label.getAttribute('data-value')));
+    deleteIcon.setAttribute('aria-label', window.config.i18n.remove_label_str.replace('%s', label.getAttribute('data-value')!));
     deleteIcon.setAttribute('role', 'button');
   }
 }

web_src/js/types.ts

@@ -1,26 +1,3 @@
-export type MentionValue = {
-  key: string,
-  value: string,
-  name: string,
-  fullname: string,
-  avatar: string,
-};
-
-export type Config = {
-  appUrl: string,
-  appSubUrl: string,
-  assetVersionEncoded: string,
-  assetUrlPrefix: string,
-  runModeIsProd: boolean,
-  customEmojis: Record<string, string>,
-  pageData: Record<string, any>,
-  notificationSettings: Record<string, any>,
-  enableTimeTracking: boolean,
-  mentionValues?: MentionValue[],
-  mermaidMaxSourceCharacters: number,
-  i18n: Record<string, string>,
-};
-
 export type IntervalId = ReturnType<typeof setInterval>;
 
 export type Intent = 'error' | 'warning' | 'info';

web_src/js/utils/match.ts

@@ -35,7 +35,7 @@ export function matchMention(queryText: string): MentionSuggestion[] {
 
   // results is a map of weights, lower is better
   const results = new Map<MentionSuggestion, number>();
-  for (const obj of window.config.mentionValues ?? []) {
+  for (const obj of window.config.mentionValues) {
     const index = obj.key.toLowerCase().indexOf(query);
     if (index === -1) continue;
     const existing = results.get(obj);