mirror of
https://github.com/go-gitea/gitea.git
synced 2026-04-02 00:18:35 +01:00
- Replace monaco-editor with CodeMirror 6 - Add `--color-syntax-*` CSS variables for all syntax token types, shared by CodeMirror, Chroma and EasyMDE - Consolidate chroma CSS into a single theme-independent file (`modules/chroma.css`) - Syntax colors in the code editor now match the code view and light/dark themes - Code editor is now 12px instead of 14px font size to match code view and GitHub - Use a global style for kbd elements - When editing existing files, focus will be on codemirror instead of filename input. - Keyboard shortcuts are roughtly the same as VSCode - Add a "Find" button, useful for mobile - Add context menu similar to Monaco - Add a command palette (Ctrl/Cmd+Shift+P or F1) or via button - Add clickable URLs via Ctrl/Cmd+click - Add e2e test for the code editor - Remove `window.codeEditors` global - The main missing Monaco features are hover types and semantic rename but these were not fully working because monaco operated only on single files and only for JS/TS/HTML/CSS/JSON. | | Monaco (main) | CodeMirror (cm) | Delta | |---|---|---|---| | **Build time** | 7.8s | 5.3s | **-32%** | | **JS output** | 25 MB | 14 MB | **-44%** | | **CSS output** | 1.2 MB | 1012 KB | **-17%** | | **Total (no maps)** | 23.3 MB | 12.1 MB | **-48%** | Fixes: #36311 Fixes: #14776 Fixes: #12171 <img width="1333" height="555" alt="image" src="https://github.com/user-attachments/assets/f0fe3a28-1ed9-4f22-bf25-2b161501d7ce" /> --------- Signed-off-by: silverwind <me@silverwind.io> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
77 lines
3.0 KiB
TypeScript
77 lines
3.0 KiB
TypeScript
import {registerGlobalInitFunc} from './observer.ts';
|
|
import {hideElem, toggleElem} from '../utils/dom.ts';
|
|
|
|
function initShortcutKbd(kbd: HTMLElement) {
|
|
// Handle initial state: hide the kbd hint if the associated input already has a value
|
|
// (e.g., from browser autofill or back/forward navigation cache)
|
|
const elem = elemFromKbd(kbd);
|
|
if (elem?.value) hideElem(kbd);
|
|
kbd.setAttribute('aria-hidden', 'true');
|
|
kbd.setAttribute('aria-keyshortcuts', kbd.getAttribute('data-shortcut-keys')!);
|
|
}
|
|
|
|
function shortcutWrapper(el: HTMLElement): HTMLElement | null {
|
|
const parent = el.parentElement;
|
|
return parent?.matches('.global-shortcut-wrapper') ? parent : null;
|
|
}
|
|
|
|
function elemFromKbd(kbd: HTMLElement): HTMLInputElement | HTMLTextAreaElement | null {
|
|
return shortcutWrapper(kbd)?.querySelector<HTMLInputElement>('input, textarea') || null;
|
|
}
|
|
|
|
function kbdFromElem(input: HTMLElement): HTMLElement | null {
|
|
return shortcutWrapper(input)?.querySelector<HTMLElement>('kbd') || null;
|
|
}
|
|
|
|
export function initGlobalShortcut() {
|
|
registerGlobalInitFunc('onGlobalShortcut', initShortcutKbd);
|
|
|
|
// A <kbd> element next to an <input> declares a keyboard shortcut for that input.
|
|
// When the matching key is pressed, the sibling input is focused.
|
|
// When Escape is pressed inside such an input, the input is cleared and blurred.
|
|
// The <kbd> element is shown/hidden automatically based on input focus and value.
|
|
document.addEventListener('keydown', (e: KeyboardEvent) => {
|
|
// Modifier keys are not supported yet
|
|
if (e.ctrlKey || e.metaKey || e.altKey) return;
|
|
|
|
const target = e.target as HTMLElement;
|
|
|
|
// Handle Escape: clear and blur inputs that have an associated keyboard shortcut
|
|
if (e.key === 'Escape') {
|
|
const kbd = kbdFromElem(target);
|
|
if (kbd) {
|
|
(target as HTMLInputElement).value = '';
|
|
(target as HTMLInputElement).blur();
|
|
}
|
|
return;
|
|
}
|
|
|
|
// Don't trigger shortcuts when typing in input fields or contenteditable areas
|
|
if (target.matches('input, textarea, select') || target.isContentEditable) {
|
|
return;
|
|
}
|
|
|
|
// Find kbd element with matching shortcut (case-insensitive), then focus its sibling input
|
|
const key = e.key.toLowerCase();
|
|
// At the moment, only a simple match. In the future, it can be extended to support modifiers and key combinations
|
|
const kbd = document.querySelector<HTMLElement>(`.global-shortcut-wrapper > kbd[data-shortcut-keys="${CSS.escape(key)}"]`);
|
|
if (!kbd) return;
|
|
e.preventDefault();
|
|
elemFromKbd(kbd)!.focus();
|
|
});
|
|
|
|
// Toggle kbd shortcut hint visibility on input focus/blur
|
|
document.addEventListener('focusin', (e) => {
|
|
const kbd = kbdFromElem(e.target as HTMLElement);
|
|
if (!kbd) return;
|
|
hideElem(kbd);
|
|
});
|
|
|
|
document.addEventListener('focusout', (e) => {
|
|
const kbd = kbdFromElem(e.target as HTMLElement);
|
|
if (!kbd) return;
|
|
const hasContent = Boolean((e.target as HTMLInputElement).value);
|
|
toggleElem(kbd, !hasContent);
|
|
});
|
|
}
|