Home-Assistant/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-12-24 12:59:34 +00:00
Code Activity

Do not select all entities when omitting entity ID in service call (#29178)

Browse Source 
* Do not select all entities when omitting entity ID

* Address comments Matthew

* Require either area_id or entity_id

* Fix tests

* Fix test
This commit is contained in:
Paulus Schoutsen
2019-12-02 16:23:12 -08:00
committed by GitHub
parent 9587afc5ce
commit 02d9ed5e36
47 changed files with 538 additions and 626 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/components/light/common.py
View File

@@ -24,6 +24,7 @@ from homeassistant.const import (
SERVICE_TOGGLE,
SERVICE_TURN_OFF,
SERVICE_TURN_ON,
ENTITY_MATCH_ALL,
)
from homeassistant.loader import bind_hass
@@ -31,7 +32,7 @@ from homeassistant.loader import bind_hass
@bind_hass
def turn_on(
hass,
entity_id=None,
entity_id=ENTITY_MATCH_ALL,
transition=None,
brightness=None,
brightness_pct=None,
@@ -69,7 +70,7 @@ def turn_on(
async def async_turn_on(
hass,
entity_id=None,
entity_id=ENTITY_MATCH_ALL,
transition=None,
brightness=None,
brightness_pct=None,
@@ -110,12 +111,12 @@ async def async_turn_on(
@bind_hass
def turn_off(hass, entity_id=None, transition=None):
def turn_off(hass, entity_id=ENTITY_MATCH_ALL, transition=None):
"""Turn all or specified light off."""
hass.add_job(async_turn_off, hass, entity_id, transition)
async def async_turn_off(hass, entity_id=None, transition=None):
async def async_turn_off(hass, entity_id=ENTITY_MATCH_ALL, transition=None):
"""Turn all or specified light off."""
data = {
key: value
@@ -127,12 +128,12 @@ async def async_turn_off(hass, entity_id=None, transition=None):
@bind_hass
def toggle(hass, entity_id=None, transition=None):
def toggle(hass, entity_id=ENTITY_MATCH_ALL, transition=None):
"""Toggle all or specified light."""
hass.add_job(async_toggle, hass, entity_id, transition)
async def async_toggle(hass, entity_id=None, transition=None):
async def async_toggle(hass, entity_id=ENTITY_MATCH_ALL, transition=None):
"""Toggle all or specified light."""
data = {
key: value