Cleanup mqtt platform tests part 1 (#120470)

tests/components/mqtt/test_config_flow.py

@@ -187,11 +187,11 @@ def mock_process_uploaded_file(
         yield mock_upload
 
 
+@pytest.mark.usefixtures("mqtt_client_mock")
 async def test_user_connection_works(
     hass: HomeAssistant,
     mock_try_connection: MagicMock,
     mock_finish_setup: MagicMock,
-    mqtt_client_mock: MqttMockPahoClient,
 ) -> None:
     """Test we can finish a config flow."""
     mock_try_connection.return_value = True
@@ -217,11 +217,11 @@ async def test_user_connection_works(
     assert len(mock_finish_setup.mock_calls) == 1
 
 
+@pytest.mark.usefixtures("mqtt_client_mock")
 async def test_user_v5_connection_works(
     hass: HomeAssistant,
     mock_try_connection: MagicMock,
     mock_finish_setup: MagicMock,
-    mqtt_client_mock: MqttMockPahoClient,
 ) -> None:
     """Test we can finish a config flow."""
     mock_try_connection.return_value = True
@@ -664,11 +664,11 @@ async def test_bad_certificate(
         ("100", False),
     ],
 )
+@pytest.mark.usefixtures("mock_reload_after_entry_update")
 async def test_keepalive_validation(
     hass: HomeAssistant,
     mqtt_mock_entry: MqttMockHAClientGenerator,
     mock_try_connection: MagicMock,
-    mock_reload_after_entry_update: MagicMock,
     input_value: str,
     error: bool,
 ) -> None:
@@ -872,11 +872,11 @@ def get_suggested(schema: vol.Schema, key: str) -> Any:
             return schema_key.description["suggested_value"]
 
 
+@pytest.mark.usefixtures("mock_reload_after_entry_update")
 async def test_option_flow_default_suggested_values(
     hass: HomeAssistant,
     mqtt_mock_entry: MqttMockHAClientGenerator,
     mock_try_connection_success: MqttMockPahoClient,
-    mock_reload_after_entry_update: MagicMock,
 ) -> None:
     """Test config flow options has default/suggested values."""
     await mqtt_mock_entry()
@@ -1030,11 +1030,11 @@ async def test_option_flow_default_suggested_values(
 @pytest.mark.parametrize(
     ("advanced_options", "step_id"), [(False, "options"), (True, "broker")]
 )
+@pytest.mark.usefixtures("mock_reload_after_entry_update")
 async def test_skipping_advanced_options(
     hass: HomeAssistant,
     mqtt_mock_entry: MqttMockHAClientGenerator,
     mock_try_connection: MagicMock,
-    mock_reload_after_entry_update: MagicMock,
     advanced_options: bool,
     step_id: str,
 ) -> None:
@@ -1102,11 +1102,11 @@ async def test_skipping_advanced_options(
         ),
     ],
 )
+@pytest.mark.usefixtures("mock_reload_after_entry_update")
 async def test_step_reauth(
     hass: HomeAssistant,
     mqtt_client_mock: MqttMockPahoClient,
     mock_try_connection: MagicMock,
-    mock_reload_after_entry_update: MagicMock,
     test_input: dict[str, Any],
     user_input: dict[str, Any],
     new_password: str,
@@ -1284,12 +1284,9 @@ async def test_options_bad_will_message_fails(
 @pytest.mark.parametrize(
     "hass_config", [{"mqtt": {"sensor": [{"state_topic": "some-topic"}]}}]
 )
+@pytest.mark.usefixtures("mock_ssl_context", "mock_process_uploaded_file")
 async def test_try_connection_with_advanced_parameters(
-    hass: HomeAssistant,
-    mock_try_connection_success: MqttMockPahoClient,
-    tmp_path: Path,
-    mock_ssl_context: dict[str, MagicMock],
-    mock_process_uploaded_file: MagicMock,
+    hass: HomeAssistant, mock_try_connection_success: MqttMockPahoClient
 ) -> None:
     """Test config flow with advanced parameters from config."""
     config_entry = MockConfigEntry(domain=mqtt.DOMAIN)
@@ -1402,10 +1399,10 @@ async def test_try_connection_with_advanced_parameters(
     await hass.async_block_till_done()
 
 
+@pytest.mark.usefixtures("mock_ssl_context")
 async def test_setup_with_advanced_settings(
     hass: HomeAssistant,
     mock_try_connection: MagicMock,
-    mock_ssl_context: dict[str, MagicMock],
     mock_process_uploaded_file: MagicMock,
 ) -> None:
     """Test config flow setup with advanced parameters."""
@@ -1564,11 +1561,9 @@ async def test_setup_with_advanced_settings(
     }
 
 
+@pytest.mark.usesfixtures("mock_ssl_context", "mock_process_uploaded_file")
 async def test_change_websockets_transport_to_tcp(
-    hass: HomeAssistant,
-    mock_try_connection,
-    mock_ssl_context: dict[str, MagicMock],
-    mock_process_uploaded_file: MagicMock,
+    hass: HomeAssistant, mock_try_connection: MagicMock
 ) -> None:
     """Test option flow setup with websockets transport settings."""
     config_entry = MockConfigEntry(domain=mqtt.DOMAIN)