Home-Assistant/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-12-24 12:59:34 +00:00
Code Activity

Use built-in Jinja min and max filters in templates (#60327)

Browse Source 
* Use built-in Jinja min and max filters in templates

* use built-in filter for global

* lint

* less generic name

* more tests

* even more tests
This commit is contained in:
avee87
2022-01-04 09:07:23 +00:00
committed by GitHub
parent 2d0aaeba6b
commit 04606f05a4
2 changed files with 112 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

85
tests/helpers/test_template.py
View File

@@ -835,6 +835,15 @@ def test_min(hass):
assert template.Template("{{ min([1, 2, 3]) }}", hass).async_render() == 1
assert template.Template("{{ min(1, 2, 3) }}", hass).async_render() == 1
with pytest.raises(TemplateError):
template.Template("{{ 1 | min }}", hass).async_render()
with pytest.raises(TemplateError):
template.Template("{{ min() }}", hass).async_render()
with pytest.raises(TemplateError):
template.Template("{{ min(1) }}", hass).async_render()
def test_max(hass):
"""Test the max filter."""
@@ -842,6 +851,82 @@ def test_max(hass):
assert template.Template("{{ max([1, 2, 3]) }}", hass).async_render() == 3
assert template.Template("{{ max(1, 2, 3) }}", hass).async_render() == 3
with pytest.raises(TemplateError):
template.Template("{{ 1 | max }}", hass).async_render()
with pytest.raises(TemplateError):
template.Template("{{ max() }}", hass).async_render()
with pytest.raises(TemplateError):
template.Template("{{ max(1) }}", hass).async_render()
@pytest.mark.parametrize(
"attribute",
(
"a",
"b",
"c",
),
)
def test_min_max_attribute(hass, attribute):
"""Test the min and max filters with attribute."""
hass.states.async_set(
"test.object",
"test",
{
"objects": [
{
"a": 1,
"b": 2,
"c": 3,
},
{
"a": 2,
"b": 1,
"c": 2,
},
{
"a": 3,
"b": 3,
"c": 1,
},
],
},
)
assert (
template.Template(
"{{ (state_attr('test.object', 'objects') | min(attribute='%s'))['%s']}}"
% (attribute, attribute),
hass,
).async_render()
== 1
)
assert (
template.Template(
"{{ (min(state_attr('test.object', 'objects'), attribute='%s'))['%s']}}"
% (attribute, attribute),
hass,
).async_render()
== 1
)
assert (
template.Template(
"{{ (state_attr('test.object', 'objects') | max(attribute='%s'))['%s']}}"
% (attribute, attribute),
hass,
).async_render()
== 3
)
assert (
template.Template(
"{{ (max(state_attr('test.object', 'objects'), attribute='%s'))['%s']}}"
% (attribute, attribute),
hass,
).async_render()
== 3
)
def test_ord(hass):
"""Test the ord filter."""