From 0e8295604ea0ab58a7bc1cc46133b078bd8b574f Mon Sep 17 00:00:00 2001 From: Joost Lekkerkerker Date: Thu, 11 Sep 2025 18:56:56 +0200 Subject: [PATCH] Fail hassfest if translation key is obsolete (#151924) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Abílio Costa --- script/hassfest/services.py | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/script/hassfest/services.py b/script/hassfest/services.py index 844a8955470..b47fa90d8bb 100644 --- a/script/hassfest/services.py +++ b/script/hassfest/services.py @@ -158,6 +158,31 @@ VALIDATE_AS_CUSTOM_INTEGRATION = { } +def check_extraneous_translation_fields( + integration: Integration, + service_name: str, + strings: dict[str, Any], + service_schema: dict[str, Any], +) -> None: + """Check for extraneous translation fields.""" + if integration.core and "services" in strings: + section_fields = set() + for field in service_schema.get("fields", {}).values(): + if "fields" in field: + # This is a section + section_fields.update(field["fields"].keys()) + translation_fields = { + field + for field in strings["services"][service_name].get("fields", {}) + if field not in service_schema.get("fields", {}) + } + for field in translation_fields - section_fields: + integration.add_error( + "services", + f"Service {service_name} has a field {field} in the translations file that is not in the schema", + ) + + def grep_dir(path: pathlib.Path, glob_pattern: str, search_pattern: str) -> bool: """Recursively go through a dir and it's children and find the regex.""" pattern = re.compile(search_pattern) @@ -262,6 +287,10 @@ def validate_services(config: Config, integration: Integration) -> None: # noqa f"Service {service_name} has no description {error_msg_suffix}", ) + check_extraneous_translation_fields( + integration, service_name, strings, service_schema + ) + # The same check is done for the description in each of the fields of the # service schema. for field_name, field_schema in service_schema.get("fields", {}).items():