From 1cc778954f40d7949e9d5900ff623ff1caa54ff9 Mon Sep 17 00:00:00 2001 From: Maciej Bieniek Date: Wed, 29 Apr 2026 14:54:55 +0200 Subject: [PATCH] Use new UPTIME sensor class in Brother (#169457) --- homeassistant/components/brother/sensor.py | 3 +- homeassistant/components/brother/strings.json | 3 - .../brother/snapshots/test_sensor.ambr | 102 +++++++++--------- 3 files changed, 52 insertions(+), 56 deletions(-) diff --git a/homeassistant/components/brother/sensor.py b/homeassistant/components/brother/sensor.py index 4f1a10c2621..cc473742b8b 100644 --- a/homeassistant/components/brother/sensor.py +++ b/homeassistant/components/brother/sensor.py @@ -293,9 +293,8 @@ SENSOR_TYPES: tuple[BrotherSensorEntityDescription, ...] = ( ), BrotherSensorEntityDescription( key="uptime", - translation_key="last_restart", entity_registry_enabled_default=False, - device_class=SensorDeviceClass.TIMESTAMP, + device_class=SensorDeviceClass.UPTIME, entity_category=EntityCategory.DIAGNOSTIC, value=lambda data: data.uptime, ), diff --git a/homeassistant/components/brother/strings.json b/homeassistant/components/brother/strings.json index f52875018c1..428edc25cb5 100644 --- a/homeassistant/components/brother/strings.json +++ b/homeassistant/components/brother/strings.json @@ -151,9 +151,6 @@ "laser_remaining_life": { "name": "Laser remaining lifetime" }, - "last_restart": { - "name": "Last restart" - }, "magenta_drum_page_counter": { "name": "Magenta drum page counter", "unit_of_measurement": "[%key:component::brother::entity::sensor::page_counter::unit_of_measurement%]" diff --git a/tests/components/brother/snapshots/test_sensor.ambr b/tests/components/brother/snapshots/test_sensor.ambr index 5095dbe2541..4127144b791 100644 --- a/tests/components/brother/snapshots/test_sensor.ambr +++ b/tests/components/brother/snapshots/test_sensor.ambr @@ -863,57 +863,6 @@ 'state': '97', }) # --- -# name: test_sensors[sensor.hl_l2340dw_last_restart-entry] - EntityRegistryEntrySnapshot({ - 'aliases': list([ - None, - ]), - 'area_id': None, - 'capabilities': None, - 'config_entry_id': , - 'config_subentry_id': , - 'device_class': None, - 'device_id': , - 'disabled_by': None, - 'domain': 'sensor', - 'entity_category': , - 'entity_id': 'sensor.hl_l2340dw_last_restart', - 'has_entity_name': True, - 'hidden_by': None, - 'icon': None, - 'id': , - 'labels': set({ - }), - 'name': None, - 'object_id_base': 'Last restart', - 'options': dict({ - }), - 'original_device_class': , - 'original_icon': None, - 'original_name': 'Last restart', - 'platform': 'brother', - 'previous_unique_id': None, - 'suggested_object_id': None, - 'supported_features': 0, - 'translation_key': 'last_restart', - 'unique_id': '0123456789_uptime', - 'unit_of_measurement': None, - }) -# --- -# name: test_sensors[sensor.hl_l2340dw_last_restart-state] - StateSnapshot({ - 'attributes': ReadOnlyDict({ - 'device_class': 'timestamp', - 'friendly_name': 'HL-L2340DW Last restart', - }), - 'context': , - 'entity_id': 'sensor.hl_l2340dw_last_restart', - 'last_changed': , - 'last_reported': , - 'last_updated': , - 'state': '2024-03-03T15:04:24+00:00', - }) -# --- # name: test_sensors[sensor.hl_l2340dw_magenta_drum_page_counter-entry] EntityRegistryEntrySnapshot({ 'aliases': list([ @@ -1288,6 +1237,57 @@ 'state': 'waiting', }) # --- +# name: test_sensors[sensor.hl_l2340dw_uptime-entry] + EntityRegistryEntrySnapshot({ + 'aliases': list([ + None, + ]), + 'area_id': None, + 'capabilities': None, + 'config_entry_id': , + 'config_subentry_id': , + 'device_class': None, + 'device_id': , + 'disabled_by': None, + 'domain': 'sensor', + 'entity_category': , + 'entity_id': 'sensor.hl_l2340dw_uptime', + 'has_entity_name': True, + 'hidden_by': None, + 'icon': None, + 'id': , + 'labels': set({ + }), + 'name': None, + 'object_id_base': 'Uptime', + 'options': dict({ + }), + 'original_device_class': , + 'original_icon': None, + 'original_name': 'Uptime', + 'platform': 'brother', + 'previous_unique_id': None, + 'suggested_object_id': None, + 'supported_features': 0, + 'translation_key': None, + 'unique_id': '0123456789_uptime', + 'unit_of_measurement': None, + }) +# --- +# name: test_sensors[sensor.hl_l2340dw_uptime-state] + StateSnapshot({ + 'attributes': ReadOnlyDict({ + 'device_class': 'uptime', + 'friendly_name': 'HL-L2340DW Uptime', + }), + 'context': , + 'entity_id': 'sensor.hl_l2340dw_uptime', + 'last_changed': , + 'last_reported': , + 'last_updated': , + 'state': '2024-03-03T15:04:24+00:00', + }) +# --- # name: test_sensors[sensor.hl_l2340dw_yellow_drum_page_counter-entry] EntityRegistryEntrySnapshot({ 'aliases': list([