diff --git a/homeassistant/components/synology_dsm/quality_scale.yaml b/homeassistant/components/synology_dsm/quality_scale.yaml new file mode 100644 index 00000000000..3355b907845 --- /dev/null +++ b/homeassistant/components/synology_dsm/quality_scale.yaml @@ -0,0 +1,92 @@ +rules: + # Bronze + action-setup: done + appropriate-polling: done + brands: done + common-modules: done + config-flow-test-coverage: todo + config-flow: + status: todo + comment: | + `test_user` initializes flow with `None` data + `test_user` imports a fixture that already patches, but then patches again + `test_user` doesn't continue the old flow but creates a second one + `test_user` can be parametrized to test the false SSL part + `test_user_2sa` directly initialized the flow with form data + Flows should end in CREATE_ENTRY or ABORT + dependency-transparency: done + docs-actions: todo + docs-high-level-description: done + docs-installation-instructions: done + docs-removal-instructions: done + entity-event-setup: done + entity-unique-id: done + has-entity-name: + status: todo + comment: button entities missing + runtime-data: done + test-before-configure: done + test-before-setup: done + unique-config-entry: done + + # Silver + action-exceptions: todo + config-entry-unloading: done + docs-configuration-parameters: todo + docs-installation-parameters: todo + entity-unavailable: done + integration-owner: done + log-when-unavailable: + status: done + comment: | + Handled by coordinator. + parallel-updates: todo + reauthentication-flow: done + test-coverage: + status: todo + comment: | + consts.py -> const.py + fixture could be autospecced and also be combined with the config flow one + Consider creating a fixture of the mock config entry + + # Gold + devices: + status: done + comment: Could add serial number to camera device + diagnostics: done + discovery-update-info: done + discovery: done + docs-data-update: done + docs-examples: todo + docs-known-limitations: done + docs-supported-devices: done + docs-supported-functions: done + docs-troubleshooting: done + docs-use-cases: done + dynamic-devices: + status: todo + comment: cameras and disks can be replaced and removed + entity-category: + status: todo + comment: CPU load sounds like diagnostic data + entity-device-class: done + entity-disabled-by-default: done + entity-translations: + status: todo + comment: button still has names, can use placeholders + exception-translations: todo + icon-translations: + status: todo + comment: button still has icons + reconfiguration-flow: todo + repair-issues: done + stale-devices: + status: todo + comment: see dynamic-devices + + # Platinum + async-dependency: done + inject-websession: done + strict-typing: + status: done + comment: Would be nice if we can get rid of getattr diff --git a/script/hassfest/quality_scale.py b/script/hassfest/quality_scale.py index 1b179012af8..da63d3a1010 100644 --- a/script/hassfest/quality_scale.py +++ b/script/hassfest/quality_scale.py @@ -932,7 +932,6 @@ INTEGRATIONS_WITHOUT_QUALITY_SCALE_FILE = [ "switchmate", "syncthing", "synology_chat", - "synology_dsm", "synology_srm", "syslog", "system_bridge",