mirror of
https://github.com/home-assistant/core.git
synced 2025-12-24 12:59:34 +00:00
Refactored units and icons for the Dyson sensors (#14550)
* Refactored units and icons for the Dyson sensors * Adapted unit tests to the new device names and unit of measurements * Use None as empty unit of measurement * Unrelated overall improvements following code review * Adapted tests to new constructors as per previous commit * Make sure the sensors have their `hass` attribute set in the test environment
This commit is contained in:
Giuseppe
committed by
Paulus Schoutsen
Paulus Schoutsen
parent
d5813cf167
commit
213171769d
@@ -70,11 +70,11 @@ class DysonTest(unittest.TestCase):
|
||||
"""Test setup component with devices."""
|
||||
def _add_device(devices):
|
||||
assert len(devices) == 5
|
||||
assert devices[0].name == "Device_name filter life"
|
||||
assert devices[1].name == "Device_name dust"
|
||||
assert devices[2].name == "Device_name humidity"
|
||||
assert devices[3].name == "Device_name temperature"
|
||||
assert devices[4].name == "Device_name air quality"
|
||||
assert devices[0].name == "Device_name Filter Life"
|
||||
assert devices[1].name == "Device_name Dust"
|
||||
assert devices[2].name == "Device_name Humidity"
|
||||
assert devices[3].name == "Device_name Temperature"
|
||||
assert devices[4].name == "Device_name AQI"
|
||||
|
||||
device_fan = _get_device_without_state()
|
||||
device_non_fan = _get_with_state()
|
||||
@@ -83,143 +83,147 @@ class DysonTest(unittest.TestCase):
|
||||
|
||||
def test_dyson_filter_life_sensor(self):
|
||||
"""Test filter life sensor with no value."""
|
||||
sensor = dyson.DysonFilterLifeSensor(self.hass,
|
||||
_get_device_without_state())
|
||||
sensor = dyson.DysonFilterLifeSensor(_get_device_without_state())
|
||||
sensor.hass = self.hass
|
||||
sensor.entity_id = "sensor.dyson_1"
|
||||
self.assertFalse(sensor.should_poll)
|
||||
self.assertIsNone(sensor.state)
|
||||
self.assertEqual(sensor.unit_of_measurement, "hours")
|
||||
self.assertEqual(sensor.name, "Device_name filter life")
|
||||
self.assertEqual(sensor.name, "Device_name Filter Life")
|
||||
self.assertEqual(sensor.entity_id, "sensor.dyson_1")
|
||||
sensor.on_message('message')
|
||||
|
||||
def test_dyson_filter_life_sensor_with_values(self):
|
||||
"""Test filter sensor with values."""
|
||||
sensor = dyson.DysonFilterLifeSensor(self.hass, _get_with_state())
|
||||
sensor = dyson.DysonFilterLifeSensor(_get_with_state())
|
||||
sensor.hass = self.hass
|
||||
sensor.entity_id = "sensor.dyson_1"
|
||||
self.assertFalse(sensor.should_poll)
|
||||
self.assertEqual(sensor.state, 100)
|
||||
self.assertEqual(sensor.unit_of_measurement, "hours")
|
||||
self.assertEqual(sensor.name, "Device_name filter life")
|
||||
self.assertEqual(sensor.name, "Device_name Filter Life")
|
||||
self.assertEqual(sensor.entity_id, "sensor.dyson_1")
|
||||
sensor.on_message('message')
|
||||
|
||||
def test_dyson_dust_sensor(self):
|
||||
"""Test dust sensor with no value."""
|
||||
sensor = dyson.DysonDustSensor(self.hass,
|
||||
_get_device_without_state())
|
||||
sensor = dyson.DysonDustSensor(_get_device_without_state())
|
||||
sensor.hass = self.hass
|
||||
sensor.entity_id = "sensor.dyson_1"
|
||||
self.assertFalse(sensor.should_poll)
|
||||
self.assertIsNone(sensor.state)
|
||||
self.assertEqual(sensor.unit_of_measurement, 'level')
|
||||
self.assertEqual(sensor.name, "Device_name dust")
|
||||
self.assertEqual(sensor.unit_of_measurement, None)
|
||||
self.assertEqual(sensor.name, "Device_name Dust")
|
||||
self.assertEqual(sensor.entity_id, "sensor.dyson_1")
|
||||
|
||||
def test_dyson_dust_sensor_with_values(self):
|
||||
"""Test dust sensor with values."""
|
||||
sensor = dyson.DysonDustSensor(self.hass, _get_with_state())
|
||||
sensor = dyson.DysonDustSensor(_get_with_state())
|
||||
sensor.hass = self.hass
|
||||
sensor.entity_id = "sensor.dyson_1"
|
||||
self.assertFalse(sensor.should_poll)
|
||||
self.assertEqual(sensor.state, 5)
|
||||
self.assertEqual(sensor.unit_of_measurement, 'level')
|
||||
self.assertEqual(sensor.name, "Device_name dust")
|
||||
self.assertEqual(sensor.unit_of_measurement, None)
|
||||
self.assertEqual(sensor.name, "Device_name Dust")
|
||||
self.assertEqual(sensor.entity_id, "sensor.dyson_1")
|
||||
|
||||
def test_dyson_humidity_sensor(self):
|
||||
"""Test humidity sensor with no value."""
|
||||
sensor = dyson.DysonHumiditySensor(self.hass,
|
||||
_get_device_without_state())
|
||||
sensor = dyson.DysonHumiditySensor(_get_device_without_state())
|
||||
sensor.hass = self.hass
|
||||
sensor.entity_id = "sensor.dyson_1"
|
||||
self.assertFalse(sensor.should_poll)
|
||||
self.assertIsNone(sensor.state)
|
||||
self.assertEqual(sensor.unit_of_measurement, '%')
|
||||
self.assertEqual(sensor.name, "Device_name humidity")
|
||||
self.assertEqual(sensor.name, "Device_name Humidity")
|
||||
self.assertEqual(sensor.entity_id, "sensor.dyson_1")
|
||||
|
||||
def test_dyson_humidity_sensor_with_values(self):
|
||||
"""Test humidity sensor with values."""
|
||||
sensor = dyson.DysonHumiditySensor(self.hass, _get_with_state())
|
||||
sensor = dyson.DysonHumiditySensor(_get_with_state())
|
||||
sensor.hass = self.hass
|
||||
sensor.entity_id = "sensor.dyson_1"
|
||||
self.assertFalse(sensor.should_poll)
|
||||
self.assertEqual(sensor.state, 45)
|
||||
self.assertEqual(sensor.unit_of_measurement, '%')
|
||||
self.assertEqual(sensor.name, "Device_name humidity")
|
||||
self.assertEqual(sensor.name, "Device_name Humidity")
|
||||
self.assertEqual(sensor.entity_id, "sensor.dyson_1")
|
||||
|
||||
def test_dyson_humidity_standby_monitoring(self):
|
||||
"""Test humidity sensor while device is in standby monitoring."""
|
||||
sensor = dyson.DysonHumiditySensor(self.hass,
|
||||
_get_with_standby_monitoring())
|
||||
sensor = dyson.DysonHumiditySensor(_get_with_standby_monitoring())
|
||||
sensor.hass = self.hass
|
||||
sensor.entity_id = "sensor.dyson_1"
|
||||
self.assertFalse(sensor.should_poll)
|
||||
self.assertEqual(sensor.state, STATE_OFF)
|
||||
self.assertEqual(sensor.unit_of_measurement, '%')
|
||||
self.assertEqual(sensor.name, "Device_name humidity")
|
||||
self.assertEqual(sensor.name, "Device_name Humidity")
|
||||
self.assertEqual(sensor.entity_id, "sensor.dyson_1")
|
||||
|
||||
def test_dyson_temperature_sensor(self):
|
||||
"""Test temperature sensor with no value."""
|
||||
sensor = dyson.DysonTemperatureSensor(self.hass,
|
||||
_get_device_without_state(),
|
||||
sensor = dyson.DysonTemperatureSensor(_get_device_without_state(),
|
||||
TEMP_CELSIUS)
|
||||
sensor.hass = self.hass
|
||||
sensor.entity_id = "sensor.dyson_1"
|
||||
self.assertFalse(sensor.should_poll)
|
||||
self.assertIsNone(sensor.state)
|
||||
self.assertEqual(sensor.unit_of_measurement, '°C')
|
||||
self.assertEqual(sensor.name, "Device_name temperature")
|
||||
self.assertEqual(sensor.name, "Device_name Temperature")
|
||||
self.assertEqual(sensor.entity_id, "sensor.dyson_1")
|
||||
|
||||
def test_dyson_temperature_sensor_with_values(self):
|
||||
"""Test temperature sensor with values."""
|
||||
sensor = dyson.DysonTemperatureSensor(self.hass,
|
||||
_get_with_state(),
|
||||
sensor = dyson.DysonTemperatureSensor(_get_with_state(),
|
||||
TEMP_CELSIUS)
|
||||
sensor.hass = self.hass
|
||||
sensor.entity_id = "sensor.dyson_1"
|
||||
self.assertFalse(sensor.should_poll)
|
||||
self.assertEqual(sensor.state, 21.9)
|
||||
self.assertEqual(sensor.unit_of_measurement, '°C')
|
||||
self.assertEqual(sensor.name, "Device_name temperature")
|
||||
self.assertEqual(sensor.name, "Device_name Temperature")
|
||||
self.assertEqual(sensor.entity_id, "sensor.dyson_1")
|
||||
|
||||
sensor = dyson.DysonTemperatureSensor(self.hass,
|
||||
_get_with_state(),
|
||||
sensor = dyson.DysonTemperatureSensor(_get_with_state(),
|
||||
TEMP_FAHRENHEIT)
|
||||
sensor.hass = self.hass
|
||||
sensor.entity_id = "sensor.dyson_1"
|
||||
self.assertFalse(sensor.should_poll)
|
||||
self.assertEqual(sensor.state, 71.3)
|
||||
self.assertEqual(sensor.unit_of_measurement, '°F')
|
||||
self.assertEqual(sensor.name, "Device_name temperature")
|
||||
self.assertEqual(sensor.name, "Device_name Temperature")
|
||||
self.assertEqual(sensor.entity_id, "sensor.dyson_1")
|
||||
|
||||
def test_dyson_temperature_standby_monitoring(self):
|
||||
"""Test temperature sensor while device is in standby monitoring."""
|
||||
sensor = dyson.DysonTemperatureSensor(self.hass,
|
||||
_get_with_standby_monitoring(),
|
||||
sensor = dyson.DysonTemperatureSensor(_get_with_standby_monitoring(),
|
||||
TEMP_CELSIUS)
|
||||
sensor.hass = self.hass
|
||||
sensor.entity_id = "sensor.dyson_1"
|
||||
self.assertFalse(sensor.should_poll)
|
||||
self.assertEqual(sensor.state, STATE_OFF)
|
||||
self.assertEqual(sensor.unit_of_measurement, '°C')
|
||||
self.assertEqual(sensor.name, "Device_name temperature")
|
||||
self.assertEqual(sensor.name, "Device_name Temperature")
|
||||
self.assertEqual(sensor.entity_id, "sensor.dyson_1")
|
||||
|
||||
def test_dyson_air_quality_sensor(self):
|
||||
"""Test air quality sensor with no value."""
|
||||
sensor = dyson.DysonAirQualitySensor(self.hass,
|
||||
_get_device_without_state())
|
||||
sensor = dyson.DysonAirQualitySensor(_get_device_without_state())
|
||||
sensor.hass = self.hass
|
||||
sensor.entity_id = "sensor.dyson_1"
|
||||
self.assertFalse(sensor.should_poll)
|
||||
self.assertIsNone(sensor.state)
|
||||
self.assertEqual(sensor.unit_of_measurement, 'level')
|
||||
self.assertEqual(sensor.name, "Device_name air quality")
|
||||
self.assertEqual(sensor.unit_of_measurement, None)
|
||||
self.assertEqual(sensor.name, "Device_name AQI")
|
||||
self.assertEqual(sensor.entity_id, "sensor.dyson_1")
|
||||
|
||||
def test_dyson_air_quality_sensor_with_values(self):
|
||||
"""Test air quality sensor with values."""
|
||||
sensor = dyson.DysonAirQualitySensor(self.hass, _get_with_state())
|
||||
sensor = dyson.DysonAirQualitySensor(_get_with_state())
|
||||
sensor.hass = self.hass
|
||||
sensor.entity_id = "sensor.dyson_1"
|
||||
self.assertFalse(sensor.should_poll)
|
||||
self.assertEqual(sensor.state, 2)
|
||||
self.assertEqual(sensor.unit_of_measurement, 'level')
|
||||
self.assertEqual(sensor.name, "Device_name air quality")
|
||||
self.assertEqual(sensor.unit_of_measurement, None)
|
||||
self.assertEqual(sensor.name, "Device_name AQI")
|
||||
self.assertEqual(sensor.entity_id, "sensor.dyson_1")
|
||||
|
||||
Reference in New Issue
Block a user