1
0
mirror of https://github.com/home-assistant/core.git synced 2025-12-24 12:59:34 +00:00

Use voluptuous for mFi switch (#3168)

* Migrate to voluptuous

* Take change configuration into account
This commit is contained in:
Fabian Affolter
2016-09-04 04:32:35 +02:00
committed by Teagan Glenn
parent 8467d07a3d
commit 3c615e2319
4 changed files with 65 additions and 62 deletions

View File

@@ -24,16 +24,14 @@ class TestMfiSensorSetup(unittest.TestCase):
'port': 6123,
'username': 'user',
'password': 'pass',
'use_tls': True,
'verify_tls': True,
'ssl': True,
'verify_ssl': True,
}
}
def setup_method(self, method):
"""Setup things to be run when tests are started."""
self.hass = get_test_home_assistant()
self.hass.config.latitude = 32.87336
self.hass.config.longitude = 117.22743
def teardown_method(self, method):
"""Stop everything that was started."""
@@ -54,9 +52,8 @@ class TestMfiSensorSetup(unittest.TestCase):
mock_client.FailedToLogin = Exception()
mock_client.MFiClient.side_effect = mock_client.FailedToLogin
self.assertFalse(
self.PLATFORM.setup_platform(self.hass,
dict(self.GOOD_CONFIG),
None))
self.PLATFORM.setup_platform(
self.hass, dict(self.GOOD_CONFIG), None))
@mock.patch('mficlient.client')
def test_setup_failed_connect(self, mock_client):
@@ -64,9 +61,8 @@ class TestMfiSensorSetup(unittest.TestCase):
mock_client.FailedToLogin = Exception()
mock_client.MFiClient.side_effect = requests.exceptions.ConnectionError
self.assertFalse(
self.PLATFORM.setup_platform(self.hass,
dict(self.GOOD_CONFIG),
None))
self.PLATFORM.setup_platform(
self.hass, dict(self.GOOD_CONFIG), None))
@mock.patch('mficlient.client.MFiClient')
def test_setup_minimum(self, mock_client):
@@ -74,9 +70,8 @@ class TestMfiSensorSetup(unittest.TestCase):
config = dict(self.GOOD_CONFIG)
del config[self.THING]['port']
assert self.COMPONENT.setup(self.hass, config)
mock_client.assert_called_once_with('foo', 'user', 'pass',
port=6443, use_tls=True,
verify=True)
mock_client.assert_called_once_with(
'foo', 'user', 'pass', port=6443, use_tls=True, verify=True)
@mock.patch('mficlient.client.MFiClient')
def test_setup_with_port(self, mock_client):
@@ -84,21 +79,19 @@ class TestMfiSensorSetup(unittest.TestCase):
config = dict(self.GOOD_CONFIG)
config[self.THING]['port'] = 6123
assert self.COMPONENT.setup(self.hass, config)
mock_client.assert_called_once_with('foo', 'user', 'pass',
port=6123, use_tls=True,
verify=True)
mock_client.assert_called_once_with(
'foo', 'user', 'pass', port=6123, use_tls=True, verify=True)
@mock.patch('mficlient.client.MFiClient')
def test_setup_with_tls_disabled(self, mock_client):
"""Test setup without TLS."""
config = dict(self.GOOD_CONFIG)
del config[self.THING]['port']
config[self.THING]['use_tls'] = False
config[self.THING]['verify_tls'] = False
config[self.THING]['ssl'] = False
config[self.THING]['verify_ssl'] = False
assert self.COMPONENT.setup(self.hass, config)
mock_client.assert_called_once_with('foo', 'user', 'pass',
port=6080, use_tls=False,
verify=False)
mock_client.assert_called_once_with(
'foo', 'user', 'pass', port=6080, use_tls=False, verify=False)
@mock.patch('mficlient.client.MFiClient')
@mock.patch('homeassistant.components.sensor.mfi.MfiSensor')
@@ -123,8 +116,6 @@ class TestMfiSensor(unittest.TestCase):
def setup_method(self, method):
"""Setup things to be run when tests are started."""
self.hass = get_test_home_assistant()
self.hass.config.latitude = 32.87336
self.hass.config.longitude = 117.22743
self.port = mock.MagicMock()
self.sensor = mfi.MfiSensor(self.port, self.hass)