Home-Assistant/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-12-24 21:06:19 +00:00
Code Activity

Fix config modules being imported in the event loop (#112462)

Browse Source 
* Fix config modules being imported in the event loop

There was a late import in this integration because of the circular import.

The code has been rearranged to avoid the circular imports

* fixes

* fixes

* fix patching

* make eager

* remove unrelated change from this branch
This commit is contained in:
J. Nick Koston
2024-03-05 16:18:57 -10:00
committed by GitHub
parent f03be2fd9e
commit 3f9dbd3e25
11 changed files with 317 additions and 287 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/components/config/test_script.py
View File

@@ -8,6 +8,7 @@ import pytest
from homeassistant.bootstrap import async_setup_component
from homeassistant.components import config
from homeassistant.components.config import script
from homeassistant.const import STATE_OFF, STATE_UNAVAILABLE
from homeassistant.core import HomeAssistant
from homeassistant.helpers import entity_registry as er
@@ -32,7 +33,7 @@ async def test_get_script_config(
hass: HomeAssistant, hass_client: ClientSessionGenerator, hass_config_store
) -> None:
"""Test getting script config."""
with patch.object(config, "SECTIONS", ["script"]):
with patch.object(config, "SECTIONS", [script]):
await async_setup_component(hass, "config", {})
client = await hass_client()
@@ -55,7 +56,7 @@ async def test_update_script_config(
hass: HomeAssistant, hass_client: ClientSessionGenerator, hass_config_store
) -> None:
"""Test updating script config."""
with patch.object(config, "SECTIONS", ["script"]):
with patch.object(config, "SECTIONS", [script]):
await async_setup_component(hass, "config", {})
assert sorted(hass.states.async_entity_ids("script")) == []
@@ -91,7 +92,7 @@ async def test_invalid_object_id(
hass: HomeAssistant, hass_client: ClientSessionGenerator, hass_config_store
) -> None:
"""Test creating a script with an invalid object_id."""
with patch.object(config, "SECTIONS", ["script"]):
with patch.object(config, "SECTIONS", [script]):
await async_setup_component(hass, "config", {})
assert sorted(hass.states.async_entity_ids("script")) == []
@@ -156,7 +157,7 @@ async def test_update_script_config_with_error(
validation_error: str,
) -> None:
"""Test updating script config with errors."""
with patch.object(config, "SECTIONS", ["script"]):
with patch.object(config, "SECTIONS", [script]):
await async_setup_component(hass, "config", {})
assert sorted(hass.states.async_entity_ids("script")) == []
@@ -207,7 +208,7 @@ async def test_update_script_config_with_blueprint_substitution_error(
validation_error: str,
) -> None:
"""Test updating script config with errors."""
with patch.object(config, "SECTIONS", ["script"]):
with patch.object(config, "SECTIONS", [script]):
await async_setup_component(hass, "config", {})
assert sorted(hass.states.async_entity_ids("script")) == []
@@ -240,7 +241,7 @@ async def test_update_remove_key_script_config(
hass: HomeAssistant, hass_client: ClientSessionGenerator, hass_config_store
) -> None:
"""Test updating script config while removing a key."""
with patch.object(config, "SECTIONS", ["script"]):
with patch.object(config, "SECTIONS", [script]):
await async_setup_component(hass, "config", {})
assert sorted(hass.states.async_entity_ids("script")) == []
@@ -287,7 +288,7 @@ async def test_delete_script(
hass_config_store,
) -> None:
"""Test deleting a script."""
with patch.object(config, "SECTIONS", ["script"]):
with patch.object(config, "SECTIONS", [script]):
await async_setup_component(hass, "config", {})
assert sorted(hass.states.async_entity_ids("script")) == [
@@ -326,7 +327,7 @@ async def test_api_calls_require_admin(
hass_config_store,
) -> None:
"""Test script APIs endpoints do not work as a normal user."""
with patch.object(config, "SECTIONS", ["script"]):
with patch.object(config, "SECTIONS", [script]):
await async_setup_component(hass, "config", {})
hass_config_store["scripts.yaml"] = {