Home-Assistant/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-12-26 22:18:40 +00:00
Code Activity

Removing calls to mock.assert_called_once_with (#3896)

Browse Source 
If a mock's assert_called_once_with method is misspelled (e.g. asert_called_once_with) then the test will appear as passing.  Therefore, this commit removes all instances of assert_called_once_with calls and replaces them with two assertions:

        self.assertEqual(mock.call_count, 1)
        self.assertEqual(mock.call_args, mock.call(call_args))
This commit is contained in:
Rob Capellini
2016-10-16 19:13:27 -04:00
committed by Paulus Schoutsen
parent 10c9132046
commit 4891ca1610
18 changed files with 308 additions and 109 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
tests/components/test_influxdb.py
View File

@@ -131,7 +131,13 @@ class TestInfluxDB(unittest.TestCase):
},
}]
self.handler_method(event)
mock_client.return_value.write_points.assert_called_once_with(body)
self.assertEqual(
mock_client.return_value.write_points.call_count, 1
)
self.assertEqual(
mock_client.return_value.write_points.call_args,
mock.call(body)
)
mock_client.return_value.write_points.reset_mock()
def test_event_listener_no_units(self, mock_client):
@@ -162,7 +168,13 @@ class TestInfluxDB(unittest.TestCase):
},
}]
self.handler_method(event)
mock_client.return_value.write_points.assert_called_once_with(body)
self.assertEqual(
mock_client.return_value.write_points.call_count, 1
)
self.assertEqual(
mock_client.return_value.write_points.call_args,
mock.call(body)
)
mock_client.return_value.write_points.reset_mock()
def test_event_listener_fail_write(self, mock_client):
@@ -205,8 +217,13 @@ class TestInfluxDB(unittest.TestCase):
}]
self.handler_method(event)
if state_state == 1:
mock_client.return_value.write_points.assert_called_once_with(
body)
self.assertEqual(
mock_client.return_value.write_points.call_count, 1
)
self.assertEqual(
mock_client.return_value.write_points.call_args,
mock.call(body)
)
else:
self.assertFalse(mock_client.return_value.write_points.called)
mock_client.return_value.write_points.reset_mock()
@@ -236,8 +253,13 @@ class TestInfluxDB(unittest.TestCase):
}]
self.handler_method(event)
if entity_id == 'ok':
mock_client.return_value.write_points.assert_called_once_with(
body)
self.assertEqual(
mock_client.return_value.write_points.call_count, 1
)
self.assertEqual(
mock_client.return_value.write_points.call_args,
mock.call(body)
)
else:
self.assertFalse(mock_client.return_value.write_points.called)
mock_client.return_value.write_points.reset_mock()