From 5a4d51e57a59d705160eae8732e804cf8ea548b5 Mon Sep 17 00:00:00 2001 From: epenet <6771947+epenet@users.noreply.github.com> Date: Fri, 28 Nov 2025 12:46:01 +0100 Subject: [PATCH] Mark config-flow-test-coverage as done in SFR Box IQS (#157485) --- homeassistant/components/sfr_box/manifest.json | 1 + homeassistant/components/sfr_box/quality_scale.yaml | 4 +--- script/hassfest/quality_scale.py | 1 - tests/components/sfr_box/test_config_flow.py | 4 ++++ 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/homeassistant/components/sfr_box/manifest.json b/homeassistant/components/sfr_box/manifest.json index 4582b44694c..d61dec61b46 100644 --- a/homeassistant/components/sfr_box/manifest.json +++ b/homeassistant/components/sfr_box/manifest.json @@ -6,5 +6,6 @@ "documentation": "https://www.home-assistant.io/integrations/sfr_box", "integration_type": "device", "iot_class": "local_polling", + "quality_scale": "bronze", "requirements": ["sfrbox-api==0.1.0"] } diff --git a/homeassistant/components/sfr_box/quality_scale.yaml b/homeassistant/components/sfr_box/quality_scale.yaml index 50fb1db0cd9..467745d9677 100644 --- a/homeassistant/components/sfr_box/quality_scale.yaml +++ b/homeassistant/components/sfr_box/quality_scale.yaml @@ -3,9 +3,7 @@ rules: config-flow: done test-before-configure: done unique-config-entry: done - config-flow-test-coverage: - status: todo - comment: We should test created mac address + config-flow-test-coverage: done runtime-data: done test-before-setup: done appropriate-polling: done diff --git a/script/hassfest/quality_scale.py b/script/hassfest/quality_scale.py index 3a455ba7b7c..c895f9c2b9e 100644 --- a/script/hassfest/quality_scale.py +++ b/script/hassfest/quality_scale.py @@ -1879,7 +1879,6 @@ INTEGRATIONS_WITHOUT_SCALE = [ "sesame", "seven_segments", "seventeentrack", - "sfr_box", "sharkiq", "shell_command", "shodan", diff --git a/tests/components/sfr_box/test_config_flow.py b/tests/components/sfr_box/test_config_flow.py index c1c99862913..1138a348d79 100644 --- a/tests/components/sfr_box/test_config_flow.py +++ b/tests/components/sfr_box/test_config_flow.py @@ -56,6 +56,7 @@ async def test_config_flow_skip_auth( assert result["type"] is FlowResultType.CREATE_ENTRY assert result["title"] == "SFR Box" assert result["data"] == {CONF_HOST: "192.168.0.1"} + assert result["context"]["unique_id"] == "e4:5d:51:00:11:22" assert len(mock_setup_entry.mock_calls) == 1 @@ -112,6 +113,7 @@ async def test_config_flow_skip_auth_failure( assert result["type"] is FlowResultType.CREATE_ENTRY assert result["title"] == "SFR Box" assert result["data"] == {CONF_HOST: "192.168.0.1"} + assert result["context"]["unique_id"] == "e4:5d:51:00:11:22" assert len(mock_setup_entry.mock_calls) == 1 @@ -167,6 +169,7 @@ async def test_config_flow_with_auth( CONF_USERNAME: "admin", CONF_PASSWORD: "valid", } + assert result["context"]["unique_id"] == "e4:5d:51:00:11:22" assert len(mock_setup_entry.mock_calls) == 1 @@ -237,6 +240,7 @@ async def test_config_flow_with_auth_failure( CONF_USERNAME: "admin", CONF_PASSWORD: "valid", } + assert result["context"]["unique_id"] == "e4:5d:51:00:11:22" assert len(mock_setup_entry.mock_calls) == 1