Home-Assistant/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-12-24 21:06:19 +00:00
Code Activity

Use external temp if needed in Broadlink (#118375)

Browse Source 
* Use external temp for current temp depends on the sensor state

* Add SensorMode enum

* Add tests for Broadlink climate

* Check is the sensor included in the data

* Use IntEnum as parent of SensorMode

* Use SensorMode enum value for sensor test data

* Parametrizing tests

* Readd accidentally removed assert

* Use local sensor variable

Co-authored-by: Robert Resch <robert@resch.dev>

* Refactor test_climate. Check call_counts.

* Add parameter types

Co-authored-by: Robert Resch <robert@resch.dev>

* Update homeassistant/components/broadlink/climate.py

---------

Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
This commit is contained in:
fustom
2024-07-23 12:30:06 +02:00
committed by GitHub
parent 632dec614a
commit 77282ed4b0
2 changed files with 199 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

180
tests/components/broadlink/test_climate.py Normal file
View File

@@ -0,0 +1,180 @@
"""Tests for Broadlink climate."""
from typing import Any
import pytest
from homeassistant.components.broadlink.climate import SensorMode
from homeassistant.components.broadlink.const import DOMAIN
from homeassistant.components.climate import (
ATTR_TEMPERATURE,
DOMAIN as CLIMATE_DOMAIN,
SERVICE_SET_TEMPERATURE,
SERVICE_TURN_OFF,
SERVICE_TURN_ON,
HVACAction,
HVACMode,
)
from homeassistant.const import ATTR_ENTITY_ID, Platform
from homeassistant.core import HomeAssistant
from homeassistant.helpers import device_registry as dr, entity_registry as er
from homeassistant.helpers.entity_component import async_update_entity
from . import get_device
@pytest.mark.parametrize(
(
"api_return_value",
"expected_state",
"expected_current_temperature",
"expected_temperature",
"expected_hvac_action",
),
[
(
{
"sensor": SensorMode.INNER_SENSOR_CONTROL.value,
"power": 1,
"auto_mode": 0,
"active": 1,
"room_temp": 22,
"thermostat_temp": 23,
"external_temp": 30,
},
HVACMode.HEAT,
22,
23,
HVACAction.HEATING,
),
(
{
"sensor": SensorMode.OUTER_SENSOR_CONTROL.value,
"power": 1,
"auto_mode": 1,
"active": 0,
"room_temp": 22,
"thermostat_temp": 23,
"external_temp": 30,
},
HVACMode.AUTO,
30,
23,
HVACAction.IDLE,
),
(
{
"sensor": SensorMode.INNER_SENSOR_CONTROL.value,
"power": 0,
"auto_mode": 0,
"active": 0,
"room_temp": 22,
"thermostat_temp": 23,
"external_temp": 30,
},
HVACMode.OFF,
22,
23,
HVACAction.OFF,
),
],
)
async def test_climate(
api_return_value: dict[str, Any],
expected_state: HVACMode,
expected_current_temperature: int,
expected_temperature: int,
expected_hvac_action: HVACAction,
hass: HomeAssistant,
device_registry: dr.DeviceRegistry,
entity_registry: er.EntityRegistry,
) -> None:
"""Test Broadlink climate."""
device = get_device("Guest room")
mock_setup = await device.setup_entry(hass)
device_entry = device_registry.async_get_device(
identifiers={(DOMAIN, mock_setup.entry.unique_id)}
)
entries = er.async_entries_for_device(entity_registry, device_entry.id)
climates = [entry for entry in entries if entry.domain == Platform.CLIMATE]
assert len(climates) == 1
climate = climates[0]
mock_setup.api.get_full_status.return_value = api_return_value
await async_update_entity(hass, climate.entity_id)
assert mock_setup.api.get_full_status.call_count == 2
state = hass.states.get(climate.entity_id)
assert state.state == expected_state
assert state.attributes["current_temperature"] == expected_current_temperature
assert state.attributes["temperature"] == expected_temperature
assert state.attributes["hvac_action"] == expected_hvac_action
async def test_climate_set_temperature_turn_off_turn_on(
hass: HomeAssistant,
device_registry: dr.DeviceRegistry,
entity_registry: er.EntityRegistry,
) -> None:
"""Test Broadlink climate."""
device = get_device("Guest room")
mock_setup = await device.setup_entry(hass)
device_entry = device_registry.async_get_device(
identifiers={(DOMAIN, mock_setup.entry.unique_id)}
)
entries = er.async_entries_for_device(entity_registry, device_entry.id)
climates = [entry for entry in entries if entry.domain == Platform.CLIMATE]
assert len(climates) == 1
climate = climates[0]
await hass.services.async_call(
CLIMATE_DOMAIN,
SERVICE_SET_TEMPERATURE,
{
ATTR_ENTITY_ID: climate.entity_id,
ATTR_TEMPERATURE: "24",
},
blocking=True,
)
state = hass.states.get(climate.entity_id)
assert mock_setup.api.set_temp.call_count == 1
assert mock_setup.api.set_power.call_count == 0
assert mock_setup.api.set_mode.call_count == 0
assert state.attributes["temperature"] == 24
await hass.services.async_call(
CLIMATE_DOMAIN,
SERVICE_TURN_OFF,
{
ATTR_ENTITY_ID: climate.entity_id,
},
blocking=True,
)
state = hass.states.get(climate.entity_id)
assert mock_setup.api.set_temp.call_count == 1
assert mock_setup.api.set_power.call_count == 1
assert mock_setup.api.set_mode.call_count == 0
assert state.state == HVACMode.OFF
await hass.services.async_call(
CLIMATE_DOMAIN,
SERVICE_TURN_ON,
{
ATTR_ENTITY_ID: climate.entity_id,
},
blocking=True,
)
state = hass.states.get(climate.entity_id)
assert mock_setup.api.set_temp.call_count == 1
assert mock_setup.api.set_power.call_count == 2
assert mock_setup.api.set_mode.call_count == 1
assert state.state == HVACMode.HEAT