Home-Assistant/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-12-24 21:06:19 +00:00
Code Activity

Fix shutdown deadlock with run_callback_threadsafe (#45807)

Browse Source
This commit is contained in:
J. Nick Koston
2021-01-31 23:54:39 -10:00
committed by GitHub
parent 31a84555b9
commit 9f59515bb8
4 changed files with 122 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/test_core.py
View File

@@ -169,6 +169,30 @@ async def test_stage_shutdown(hass):
assert len(test_all) == 2
async def test_shutdown_calls_block_till_done_after_shutdown_run_callback_threadsafe(
hass,
):
"""Ensure shutdown_run_callback_threadsafe is called before the final async_block_till_done."""
stop_calls = []
async def _record_block_till_done():
nonlocal stop_calls
stop_calls.append("async_block_till_done")
def _record_shutdown_run_callback_threadsafe(loop):
nonlocal stop_calls
stop_calls.append(("shutdown_run_callback_threadsafe", loop))
with patch.object(hass, "async_block_till_done", _record_block_till_done), patch(
"homeassistant.core.shutdown_run_callback_threadsafe",
_record_shutdown_run_callback_threadsafe,
):
await hass.async_stop()
assert stop_calls[-2] == ("shutdown_run_callback_threadsafe", hass.loop)
assert stop_calls[-1] == "async_block_till_done"
async def test_pending_sheduler(hass):
"""Add a coro to pending tasks."""
call_count = []