Home-Assistant/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-12-24 12:59:34 +00:00
Code Activity

Make typing checks more strict (#14429)

Browse Source 
## Description:

Make typing checks more strict: add `--strict-optional` flag that forbids implicit None return type. This flag will become default in the next version of mypy (0.600)

Add `homeassistant/util/` to checked dirs.

## Checklist:
  - [x] The code change is tested and works locally.
  - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**
This commit is contained in:
Andrey
2018-07-13 13:24:51 +03:00
committed by GitHub
parent b6ca03ce47
commit c2fe0d0120
17 changed files with 107 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
homeassistant/setup.py
View File

@@ -50,7 +50,7 @@ async def async_setup_component(hass: core.HomeAssistant, domain: str,
if setup_tasks is None:
setup_tasks = hass.data[DATA_SETUP] = {}
task = setup_tasks[domain] = hass.async_add_job(
task = setup_tasks[domain] = hass.async_create_task(
_async_setup_component(hass, domain, config))
return await task
@@ -142,7 +142,7 @@ async def _async_setup_component(hass: core.HomeAssistant,
result = await component.async_setup( # type: ignore
hass, processed_config)
else:
result = await hass.async_add_job(
result = await hass.async_add_executor_job(
component.setup, hass, processed_config) # type: ignore
except Exception: # pylint: disable=broad-except
_LOGGER.exception("Error during setup of component %s", domain)