Home-Assistant/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-12-24 21:06:19 +00:00
Code Activity

Remove redundant entity_id collision check in entity registry (#143660)

Browse Source 
* Remove redundant entity_id collision check in entity registry

* Update test
This commit is contained in:
Erik Montnemery
2025-04-28 07:50:26 +02:00
committed by GitHub
parent dd9dad80be
commit cec8db173b
3 changed files with 16 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/helpers/test_entity_registry.py
View File

@@ -2017,7 +2017,9 @@ async def test_disabled_entities_excluded_from_entity_list(
) == [entry1, entry2]
async def test_entity_max_length_exceeded(entity_registry: er.EntityRegistry) -> None:
async def test_entity_max_length_exceeded(
hass: HomeAssistant, entity_registry: er.EntityRegistry
) -> None:
"""Test that an exception is raised when the max character length is exceeded."""
long_domain_name = (
@@ -2042,20 +2044,13 @@ async def test_entity_max_length_exceeded(entity_registry: er.EntityRegistry) ->
"1234567890123456789012345678901234567"
)
known = []
new_id = entity_registry.async_generate_entity_id(
"sensor", long_entity_id_name, known
)
new_id = entity_registry.async_generate_entity_id("sensor", long_entity_id_name)
assert new_id == "sensor." + long_entity_id_name[: 255 - 7]
known.append(new_id)
new_id = entity_registry.async_generate_entity_id(
"sensor", long_entity_id_name, known
)
hass.states.async_reserve(new_id)
new_id = entity_registry.async_generate_entity_id("sensor", long_entity_id_name)
assert new_id == "sensor." + long_entity_id_name[: 255 - 7 - 2] + "_2"
known.append(new_id)
new_id = entity_registry.async_generate_entity_id(
"sensor", long_entity_id_name, known
)
hass.states.async_reserve(new_id)
new_id = entity_registry.async_generate_entity_id("sensor", long_entity_id_name)
assert new_id == "sensor." + long_entity_id_name[: 255 - 7 - 2] + "_3"