Sentry integration enhancements (#38833)

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>

tests/components/sentry/test_config_flow.py

@@ -1,25 +1,37 @@
 """Test the sentry config flow."""
+import logging
+
 from sentry_sdk.utils import BadDsn
 
-from homeassistant import config_entries, setup
-from homeassistant.components.sentry.const import DOMAIN
+from homeassistant.components.sentry.const import (
+    CONF_ENVIRONMENT,
+    CONF_EVENT_CUSTOM_COMPONENTS,
+    CONF_EVENT_HANDLED,
+    CONF_EVENT_THIRD_PARTY_PACKAGES,
+    CONF_LOGGING_EVENT_LEVEL,
+    CONF_LOGGING_LEVEL,
+    CONF_TRACING,
+    CONF_TRACING_SAMPLE_RATE,
+    DOMAIN,
+)
+from homeassistant.config_entries import SOURCE_USER
+from homeassistant.data_entry_flow import RESULT_TYPE_ABORT, RESULT_TYPE_FORM
+from homeassistant.setup import async_setup_component
 
 from tests.async_mock import patch
+from tests.common import MockConfigEntry
 
 
-async def test_form(hass):
+async def test_full_user_flow_implementation(hass):
     """Test we get the form."""
-    await setup.async_setup_component(hass, "persistent_notification", {})
+    await async_setup_component(hass, "persistent_notification", {})
     result = await hass.config_entries.flow.async_init(
-        DOMAIN, context={"source": config_entries.SOURCE_USER}
+        DOMAIN, context={"source": SOURCE_USER}
     )
-    assert result["type"] == "form"
+    assert result["type"] == RESULT_TYPE_FORM
     assert result["errors"] == {}
 
-    with patch(
-        "homeassistant.components.sentry.config_flow.validate_input",
-        return_value={"title": "Sentry"},
-    ), patch(
+    with patch("homeassistant.components.sentry.config_flow.Dsn"), patch(
         "homeassistant.components.sentry.async_setup", return_value=True
     ) as mock_setup, patch(
         "homeassistant.components.sentry.async_setup_entry", return_value=True,
@@ -34,23 +46,94 @@ async def test_form(hass):
         "dsn": "http://public@sentry.local/1",
     }
     await hass.async_block_till_done()
+
     assert len(mock_setup.mock_calls) == 1
     assert len(mock_setup_entry.mock_calls) == 1
 
 
-async def test_form_bad_dsn(hass):
+async def test_integration_already_exists(hass):
+    """Test we only allow a single config flow."""
+    MockConfigEntry(domain=DOMAIN).add_to_hass(hass)
+
+    result = await hass.config_entries.flow.async_init(
+        DOMAIN, context={"source": SOURCE_USER}
+    )
+    assert result["type"] == RESULT_TYPE_ABORT
+    assert result["reason"] == "single_instance_allowed"
+
+
+async def test_user_flow_bad_dsn(hass):
     """Test we handle bad dsn error."""
     result = await hass.config_entries.flow.async_init(
-        DOMAIN, context={"source": config_entries.SOURCE_USER}
+        DOMAIN, context={"source": SOURCE_USER}
     )
 
     with patch(
-        "homeassistant.components.sentry.config_flow.validate_input",
-        side_effect=BadDsn,
+        "homeassistant.components.sentry.config_flow.Dsn", side_effect=BadDsn,
     ):
         result2 = await hass.config_entries.flow.async_configure(
             result["flow_id"], {"dsn": "foo"},
         )
 
-    assert result2["type"] == "form"
+    assert result2["type"] == RESULT_TYPE_FORM
     assert result2["errors"] == {"base": "bad_dsn"}
+
+
+async def test_user_flow_unkown_exception(hass):
+    """Test we handle any unknown exception error."""
+    result = await hass.config_entries.flow.async_init(
+        DOMAIN, context={"source": SOURCE_USER}
+    )
+
+    with patch(
+        "homeassistant.components.sentry.config_flow.Dsn", side_effect=Exception,
+    ):
+        result2 = await hass.config_entries.flow.async_configure(
+            result["flow_id"], {"dsn": "foo"},
+        )
+
+    assert result2["type"] == RESULT_TYPE_FORM
+    assert result2["errors"] == {"base": "unknown"}
+
+
+async def test_options_flow(hass):
+    """Test options config flow."""
+    entry = MockConfigEntry(
+        domain=DOMAIN, data={"dsn": "http://public@sentry.local/1"},
+    )
+    entry.add_to_hass(hass)
+
+    with patch("homeassistant.components.sentry.async_setup_entry", return_value=True):
+        assert await hass.config_entries.async_setup(entry.entry_id)
+        await hass.async_block_till_done()
+
+    result = await hass.config_entries.options.async_init(entry.entry_id)
+
+    assert result["type"] == RESULT_TYPE_FORM
+    assert result["step_id"] == "init"
+
+    result = await hass.config_entries.options.async_configure(
+        result["flow_id"],
+        user_input={
+            CONF_ENVIRONMENT: "Test",
+            CONF_EVENT_CUSTOM_COMPONENTS: True,
+            CONF_EVENT_HANDLED: True,
+            CONF_EVENT_THIRD_PARTY_PACKAGES: True,
+            CONF_LOGGING_EVENT_LEVEL: logging.DEBUG,
+            CONF_LOGGING_LEVEL: logging.DEBUG,
+            CONF_TRACING: True,
+            CONF_TRACING_SAMPLE_RATE: 0.5,
+        },
+    )
+
+    assert result["type"] == "create_entry"
+    assert result["data"] == {
+        CONF_ENVIRONMENT: "Test",
+        CONF_EVENT_CUSTOM_COMPONENTS: True,
+        CONF_EVENT_HANDLED: True,
+        CONF_EVENT_THIRD_PARTY_PACKAGES: True,
+        CONF_LOGGING_EVENT_LEVEL: logging.DEBUG,
+        CONF_LOGGING_LEVEL: logging.DEBUG,
+        CONF_TRACING: True,
+        CONF_TRACING_SAMPLE_RATE: 0.5,
+    }