From d5915c88119a3a3b85ae8e0dcc62899822169171 Mon Sep 17 00:00:00 2001 From: Erik Montnemery Date: Fri, 13 Mar 2026 07:54:51 +0100 Subject: [PATCH] Add motion triggers (#165373) --- CODEOWNERS | 2 + homeassistant/bootstrap.py | 1 + .../components/automation/__init__.py | 1 + homeassistant/components/motion/__init__.py | 17 + homeassistant/components/motion/icons.json | 10 + homeassistant/components/motion/manifest.json | 8 + homeassistant/components/motion/strings.json | 38 ++ homeassistant/components/motion/trigger.py | 53 +++ homeassistant/components/motion/triggers.yaml | 25 ++ script/hassfest/manifest.py | 1 + script/hassfest/quality_scale.py | 1 + tests/components/motion/__init__.py | 1 + tests/components/motion/test_trigger.py | 327 ++++++++++++++++++ tests/snapshots/test_bootstrap.ambr | 2 + 14 files changed, 487 insertions(+) create mode 100644 homeassistant/components/motion/__init__.py create mode 100644 homeassistant/components/motion/icons.json create mode 100644 homeassistant/components/motion/manifest.json create mode 100644 homeassistant/components/motion/strings.json create mode 100644 homeassistant/components/motion/trigger.py create mode 100644 homeassistant/components/motion/triggers.yaml create mode 100644 tests/components/motion/__init__.py create mode 100644 tests/components/motion/test_trigger.py diff --git a/CODEOWNERS b/CODEOWNERS index 7fe7458bea6..cb6550f8086 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1071,6 +1071,8 @@ build.json @home-assistant/supervisor /tests/components/moon/ @fabaff @frenck /homeassistant/components/mopeka/ @bdraco /tests/components/mopeka/ @bdraco +/homeassistant/components/motion/ @home-assistant/core +/tests/components/motion/ @home-assistant/core /homeassistant/components/motion_blinds/ @starkillerOG /tests/components/motion_blinds/ @starkillerOG /homeassistant/components/motionblinds_ble/ @LennP @jerrybboy diff --git a/homeassistant/bootstrap.py b/homeassistant/bootstrap.py index 0efef6cf9ab..45499892be5 100644 --- a/homeassistant/bootstrap.py +++ b/homeassistant/bootstrap.py @@ -245,6 +245,7 @@ DEFAULT_INTEGRATIONS = { "garage_door", "gate", "humidity", + "motion", "window", } DEFAULT_INTEGRATIONS_RECOVERY_MODE = { diff --git a/homeassistant/components/automation/__init__.py b/homeassistant/components/automation/__init__.py index 39020a80d45..07730491dc3 100644 --- a/homeassistant/components/automation/__init__.py +++ b/homeassistant/components/automation/__init__.py @@ -152,6 +152,7 @@ _EXPERIMENTAL_TRIGGER_PLATFORMS = { "light", "lock", "media_player", + "motion", "person", "remote", "scene", diff --git a/homeassistant/components/motion/__init__.py b/homeassistant/components/motion/__init__.py new file mode 100644 index 00000000000..218a103eea4 --- /dev/null +++ b/homeassistant/components/motion/__init__.py @@ -0,0 +1,17 @@ +"""Integration for motion triggers.""" + +from __future__ import annotations + +from homeassistant.core import HomeAssistant +from homeassistant.helpers import config_validation as cv +from homeassistant.helpers.typing import ConfigType + +DOMAIN = "motion" +CONFIG_SCHEMA = cv.empty_config_schema(DOMAIN) + +__all__ = [] + + +async def async_setup(hass: HomeAssistant, config: ConfigType) -> bool: + """Set up the component.""" + return True diff --git a/homeassistant/components/motion/icons.json b/homeassistant/components/motion/icons.json new file mode 100644 index 00000000000..79b18493b1e --- /dev/null +++ b/homeassistant/components/motion/icons.json @@ -0,0 +1,10 @@ +{ + "triggers": { + "cleared": { + "trigger": "mdi:motion-sensor-off" + }, + "detected": { + "trigger": "mdi:motion-sensor" + } + } +} diff --git a/homeassistant/components/motion/manifest.json b/homeassistant/components/motion/manifest.json new file mode 100644 index 00000000000..62ac119f5f0 --- /dev/null +++ b/homeassistant/components/motion/manifest.json @@ -0,0 +1,8 @@ +{ + "domain": "motion", + "name": "Motion", + "codeowners": ["@home-assistant/core"], + "documentation": "https://www.home-assistant.io/integrations/motion", + "integration_type": "system", + "quality_scale": "internal" +} diff --git a/homeassistant/components/motion/strings.json b/homeassistant/components/motion/strings.json new file mode 100644 index 00000000000..c94c30585ed --- /dev/null +++ b/homeassistant/components/motion/strings.json @@ -0,0 +1,38 @@ +{ + "common": { + "trigger_behavior_description": "The behavior of the targeted motion sensors to trigger on.", + "trigger_behavior_name": "Behavior" + }, + "selector": { + "trigger_behavior": { + "options": { + "any": "Any", + "first": "First", + "last": "Last" + } + } + }, + "title": "Motion", + "triggers": { + "cleared": { + "description": "Triggers after one or more motion sensors stop detecting motion.", + "fields": { + "behavior": { + "description": "[%key:component::motion::common::trigger_behavior_description%]", + "name": "[%key:component::motion::common::trigger_behavior_name%]" + } + }, + "name": "Motion cleared" + }, + "detected": { + "description": "Triggers after one or more motion sensors start detecting motion.", + "fields": { + "behavior": { + "description": "[%key:component::motion::common::trigger_behavior_description%]", + "name": "[%key:component::motion::common::trigger_behavior_name%]" + } + }, + "name": "Motion detected" + } + } +} diff --git a/homeassistant/components/motion/trigger.py b/homeassistant/components/motion/trigger.py new file mode 100644 index 00000000000..eb2fc4fe551 --- /dev/null +++ b/homeassistant/components/motion/trigger.py @@ -0,0 +1,53 @@ +"""Provides triggers for motion.""" + +from homeassistant.components.binary_sensor import ( + DOMAIN as BINARY_SENSOR_DOMAIN, + BinarySensorDeviceClass, +) +from homeassistant.const import STATE_OFF, STATE_ON +from homeassistant.core import HomeAssistant +from homeassistant.helpers.trigger import ( + EntityTargetStateTriggerBase, + EntityTriggerBase, + Trigger, + get_device_class_or_undefined, +) + + +class _MotionBinaryTriggerBase(EntityTriggerBase): + """Base trigger for motion binary sensor state changes.""" + + _domains = {BINARY_SENSOR_DOMAIN} + + def entity_filter(self, entities: set[str]) -> set[str]: + """Filter entities by motion device class.""" + entities = super().entity_filter(entities) + return { + entity_id + for entity_id in entities + if get_device_class_or_undefined(self._hass, entity_id) + == BinarySensorDeviceClass.MOTION + } + + +class MotionDetectedTrigger(_MotionBinaryTriggerBase, EntityTargetStateTriggerBase): + """Trigger for motion detected (binary sensor ON).""" + + _to_states = {STATE_ON} + + +class MotionClearedTrigger(_MotionBinaryTriggerBase, EntityTargetStateTriggerBase): + """Trigger for motion cleared (binary sensor OFF).""" + + _to_states = {STATE_OFF} + + +TRIGGERS: dict[str, type[Trigger]] = { + "detected": MotionDetectedTrigger, + "cleared": MotionClearedTrigger, +} + + +async def async_get_triggers(hass: HomeAssistant) -> dict[str, type[Trigger]]: + """Return the triggers for motion.""" + return TRIGGERS diff --git a/homeassistant/components/motion/triggers.yaml b/homeassistant/components/motion/triggers.yaml new file mode 100644 index 00000000000..1be6124ed17 --- /dev/null +++ b/homeassistant/components/motion/triggers.yaml @@ -0,0 +1,25 @@ +.trigger_common_fields: &trigger_common_fields + behavior: + required: true + default: any + selector: + select: + translation_key: trigger_behavior + options: + - first + - last + - any + +detected: + fields: *trigger_common_fields + target: + entity: + - domain: binary_sensor + device_class: motion + +cleared: + fields: *trigger_common_fields + target: + entity: + - domain: binary_sensor + device_class: motion diff --git a/script/hassfest/manifest.py b/script/hassfest/manifest.py index 344264c1e54..18fde39f30c 100644 --- a/script/hassfest/manifest.py +++ b/script/hassfest/manifest.py @@ -102,6 +102,7 @@ NO_IOT_CLASS = [ "logger", "lovelace", "media_source", + "motion", "my", "onboarding", "panel_custom", diff --git a/script/hassfest/quality_scale.py b/script/hassfest/quality_scale.py index 5a7f717fbc1..6566f11d2dc 100644 --- a/script/hassfest/quality_scale.py +++ b/script/hassfest/quality_scale.py @@ -2137,6 +2137,7 @@ NO_QUALITY_SCALE = [ "logger", "lovelace", "media_source", + "motion", "my", "onboarding", "panel_custom", diff --git a/tests/components/motion/__init__.py b/tests/components/motion/__init__.py new file mode 100644 index 00000000000..c3403b6e153 --- /dev/null +++ b/tests/components/motion/__init__.py @@ -0,0 +1 @@ +"""Tests for the motion integration.""" diff --git a/tests/components/motion/test_trigger.py b/tests/components/motion/test_trigger.py new file mode 100644 index 00000000000..8b80cfd93da --- /dev/null +++ b/tests/components/motion/test_trigger.py @@ -0,0 +1,327 @@ +"""Test motion trigger.""" + +from typing import Any + +import pytest + +from homeassistant.const import ( + ATTR_DEVICE_CLASS, + ATTR_LABEL_ID, + CONF_ENTITY_ID, + STATE_OFF, + STATE_ON, +) +from homeassistant.core import HomeAssistant, ServiceCall + +from tests.components import ( + TriggerStateDescription, + arm_trigger, + parametrize_target_entities, + parametrize_trigger_states, + set_or_remove_state, + target_entities, +) + + +@pytest.fixture +async def target_binary_sensors(hass: HomeAssistant) -> dict[str, list[str]]: + """Create multiple binary sensor entities associated with different targets.""" + return await target_entities(hass, "binary_sensor") + + +@pytest.mark.parametrize( + "trigger_key", + [ + "motion.detected", + "motion.cleared", + ], +) +async def test_motion_triggers_gated_by_labs_flag( + hass: HomeAssistant, caplog: pytest.LogCaptureFixture, trigger_key: str +) -> None: + """Test the motion triggers are gated by the labs flag.""" + await arm_trigger(hass, trigger_key, None, {ATTR_LABEL_ID: "test_label"}) + assert ( + "Unnamed automation failed to setup triggers and has been disabled: Trigger " + f"'{trigger_key}' requires the experimental 'New triggers and conditions' " + "feature to be enabled in Home Assistant Labs settings (feature flag: " + "'new_triggers_conditions')" + ) in caplog.text + + +@pytest.mark.usefixtures("enable_labs_preview_features") +@pytest.mark.parametrize( + ("trigger_target_config", "entity_id", "entities_in_target"), + parametrize_target_entities("binary_sensor"), +) +@pytest.mark.parametrize( + ("trigger", "trigger_options", "states"), + [ + *parametrize_trigger_states( + trigger="motion.detected", + target_states=[STATE_ON], + other_states=[STATE_OFF], + additional_attributes={ATTR_DEVICE_CLASS: "motion"}, + trigger_from_none=False, + ), + *parametrize_trigger_states( + trigger="motion.cleared", + target_states=[STATE_OFF], + other_states=[STATE_ON], + additional_attributes={ATTR_DEVICE_CLASS: "motion"}, + trigger_from_none=False, + ), + ], +) +async def test_motion_trigger_binary_sensor_behavior_any( + hass: HomeAssistant, + service_calls: list[ServiceCall], + target_binary_sensors: dict[str, list[str]], + trigger_target_config: dict, + entity_id: str, + entities_in_target: int, + trigger: str, + trigger_options: dict[str, Any], + states: list[TriggerStateDescription], +) -> None: + """Test motion trigger fires for binary_sensor entities with device_class motion.""" + other_entity_ids = set(target_binary_sensors["included"]) - {entity_id} + excluded_entity_ids = set(target_binary_sensors["excluded"]) - {entity_id} + + for eid in target_binary_sensors["included"]: + set_or_remove_state(hass, eid, states[0]["included"]) + await hass.async_block_till_done() + for eid in excluded_entity_ids: + set_or_remove_state(hass, eid, states[0]["excluded"]) + await hass.async_block_till_done() + + await arm_trigger(hass, trigger, {}, trigger_target_config) + + for state in states[1:]: + excluded_state = state["excluded"] + included_state = state["included"] + set_or_remove_state(hass, entity_id, included_state) + await hass.async_block_till_done() + assert len(service_calls) == state["count"] + for service_call in service_calls: + assert service_call.data[CONF_ENTITY_ID] == entity_id + service_calls.clear() + + for other_entity_id in other_entity_ids: + set_or_remove_state(hass, other_entity_id, included_state) + await hass.async_block_till_done() + for excluded_entity_id in excluded_entity_ids: + set_or_remove_state(hass, excluded_entity_id, excluded_state) + await hass.async_block_till_done() + assert len(service_calls) == (entities_in_target - 1) * state["count"] + service_calls.clear() + + +@pytest.mark.usefixtures("enable_labs_preview_features") +@pytest.mark.parametrize( + ("trigger_target_config", "entity_id", "entities_in_target"), + parametrize_target_entities("binary_sensor"), +) +@pytest.mark.parametrize( + ("trigger", "trigger_options", "states"), + [ + *parametrize_trigger_states( + trigger="motion.detected", + target_states=[STATE_ON], + other_states=[STATE_OFF], + additional_attributes={ATTR_DEVICE_CLASS: "motion"}, + trigger_from_none=False, + ), + *parametrize_trigger_states( + trigger="motion.cleared", + target_states=[STATE_OFF], + other_states=[STATE_ON], + additional_attributes={ATTR_DEVICE_CLASS: "motion"}, + trigger_from_none=False, + ), + ], +) +async def test_motion_trigger_binary_sensor_behavior_first( + hass: HomeAssistant, + service_calls: list[ServiceCall], + target_binary_sensors: dict[str, list[str]], + trigger_target_config: dict, + entity_id: str, + entities_in_target: int, + trigger: str, + trigger_options: dict[str, Any], + states: list[TriggerStateDescription], +) -> None: + """Test motion trigger fires on the first binary_sensor state change.""" + other_entity_ids = set(target_binary_sensors["included"]) - {entity_id} + excluded_entity_ids = set(target_binary_sensors["excluded"]) - {entity_id} + + for eid in target_binary_sensors["included"]: + set_or_remove_state(hass, eid, states[0]["included"]) + await hass.async_block_till_done() + for eid in excluded_entity_ids: + set_or_remove_state(hass, eid, states[0]["excluded"]) + await hass.async_block_till_done() + + await arm_trigger(hass, trigger, {"behavior": "first"}, trigger_target_config) + + for state in states[1:]: + excluded_state = state["excluded"] + included_state = state["included"] + set_or_remove_state(hass, entity_id, included_state) + await hass.async_block_till_done() + assert len(service_calls) == state["count"] + for service_call in service_calls: + assert service_call.data[CONF_ENTITY_ID] == entity_id + service_calls.clear() + + for other_entity_id in other_entity_ids: + set_or_remove_state(hass, other_entity_id, excluded_state) + await hass.async_block_till_done() + for excluded_entity_id in excluded_entity_ids: + set_or_remove_state(hass, excluded_entity_id, excluded_state) + await hass.async_block_till_done() + assert len(service_calls) == 0 + + +@pytest.mark.usefixtures("enable_labs_preview_features") +@pytest.mark.parametrize( + ("trigger_target_config", "entity_id", "entities_in_target"), + parametrize_target_entities("binary_sensor"), +) +@pytest.mark.parametrize( + ("trigger", "trigger_options", "states"), + [ + *parametrize_trigger_states( + trigger="motion.detected", + target_states=[STATE_ON], + other_states=[STATE_OFF], + additional_attributes={ATTR_DEVICE_CLASS: "motion"}, + trigger_from_none=False, + ), + *parametrize_trigger_states( + trigger="motion.cleared", + target_states=[STATE_OFF], + other_states=[STATE_ON], + additional_attributes={ATTR_DEVICE_CLASS: "motion"}, + trigger_from_none=False, + ), + ], +) +async def test_motion_trigger_binary_sensor_behavior_last( + hass: HomeAssistant, + service_calls: list[ServiceCall], + target_binary_sensors: dict[str, list[str]], + trigger_target_config: dict, + entity_id: str, + entities_in_target: int, + trigger: str, + trigger_options: dict[str, Any], + states: list[TriggerStateDescription], +) -> None: + """Test motion trigger fires when the last binary_sensor changes state.""" + other_entity_ids = set(target_binary_sensors["included"]) - {entity_id} + excluded_entity_ids = set(target_binary_sensors["excluded"]) - {entity_id} + + for eid in target_binary_sensors["included"]: + set_or_remove_state(hass, eid, states[0]["included"]) + await hass.async_block_till_done() + for eid in excluded_entity_ids: + set_or_remove_state(hass, eid, states[0]["excluded"]) + await hass.async_block_till_done() + + await arm_trigger(hass, trigger, {"behavior": "last"}, trigger_target_config) + + for state in states[1:]: + excluded_state = state["excluded"] + included_state = state["included"] + for other_entity_id in other_entity_ids: + set_or_remove_state(hass, other_entity_id, excluded_state) + await hass.async_block_till_done() + assert len(service_calls) == 0 + + set_or_remove_state(hass, entity_id, included_state) + await hass.async_block_till_done() + assert len(service_calls) == state["count"] + for service_call in service_calls: + assert service_call.data[CONF_ENTITY_ID] == entity_id + service_calls.clear() + + for excluded_entity_id in excluded_entity_ids: + set_or_remove_state(hass, excluded_entity_id, excluded_state) + await hass.async_block_till_done() + assert len(service_calls) == 0 + + +# --- Device class exclusion tests --- + + +@pytest.mark.usefixtures("enable_labs_preview_features") +@pytest.mark.parametrize( + ( + "trigger_key", + "trigger_options", + "initial_state", + "target_state", + ), + [ + ( + "motion.detected", + {}, + STATE_OFF, + STATE_ON, + ), + ( + "motion.cleared", + {}, + STATE_ON, + STATE_OFF, + ), + ], +) +async def test_motion_trigger_excludes_non_motion_binary_sensor( + hass: HomeAssistant, + service_calls: list[ServiceCall], + trigger_key: str, + trigger_options: dict[str, Any], + initial_state: str, + target_state: str, +) -> None: + """Test motion trigger does not fire for entities without device_class motion.""" + entity_id_motion = "binary_sensor.test_motion" + entity_id_occupancy = "binary_sensor.test_occupancy" + + # Set initial states + hass.states.async_set( + entity_id_motion, initial_state, {ATTR_DEVICE_CLASS: "motion"} + ) + hass.states.async_set( + entity_id_occupancy, initial_state, {ATTR_DEVICE_CLASS: "occupancy"} + ) + await hass.async_block_till_done() + + await arm_trigger( + hass, + trigger_key, + trigger_options, + { + CONF_ENTITY_ID: [ + entity_id_motion, + entity_id_occupancy, + ] + }, + ) + + # Motion binary_sensor changes - should trigger + hass.states.async_set(entity_id_motion, target_state, {ATTR_DEVICE_CLASS: "motion"}) + await hass.async_block_till_done() + assert len(service_calls) == 1 + assert service_calls[0].data[CONF_ENTITY_ID] == entity_id_motion + service_calls.clear() + + # Occupancy binary_sensor changes - should NOT trigger (wrong device class) + hass.states.async_set( + entity_id_occupancy, target_state, {ATTR_DEVICE_CLASS: "occupancy"} + ) + await hass.async_block_till_done() + assert len(service_calls) == 0 diff --git a/tests/snapshots/test_bootstrap.ambr b/tests/snapshots/test_bootstrap.ambr index a8368b1eae2..8049401a812 100644 --- a/tests/snapshots/test_bootstrap.ambr +++ b/tests/snapshots/test_bootstrap.ambr @@ -65,6 +65,7 @@ 'lovelace', 'media_player', 'media_source', + 'motion', 'network', 'notify', 'number', @@ -167,6 +168,7 @@ 'lovelace', 'media_player', 'media_source', + 'motion', 'network', 'notify', 'number',