Home-Assistant/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2026-04-02 00:27:49 +01:00
Code Activity

Hide section when all cards are hidden (#51281)

Browse Source
This commit is contained in:
Paul Bottein
2026-03-31 08:38:09 +02:00
committed by GitHub
parent cd1c273d5a
commit 0e3bcfad5e
1 changed files with 30 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/panels/lovelace/sections/hui-section.ts
View File

@@ -110,11 +110,19 @@ export class HuiSection extends ConditionalListenerMixin<LovelaceSectionConfig>(
public disconnectedCallback() { public disconnectedCallback() {
super.disconnectedCallback(); super.disconnectedCallback();
this.removeEventListener(
"card-visibility-changed",
this._cardVisibilityChanged
);
} }
public connectedCallback() { public connectedCallback() {
super.connectedCallback(); super.connectedCallback();
this._updateVisibility(); this._updateVisibility();
this.addEventListener(
"card-visibility-changed",
this._cardVisibilityChanged
);
} }
protected update(changedProperties) { protected update(changedProperties) {
@@ -144,7 +152,11 @@ export class HuiSection extends ConditionalListenerMixin<LovelaceSectionConfig>(
if (changedProperties.has("_cards")) { if (changedProperties.has("_cards")) {
this._layoutElement.cards = this._cards; this._layoutElement.cards = this._cards;
} }
if (changedProperties.has("hass") || changedProperties.has("preview")) { if (
changedProperties.has("hass") ||
changedProperties.has("preview") ||
changedProperties.has("_cards")
) {
this._updateVisibility(); this._updateVisibility();
} }
} }
@@ -200,6 +212,10 @@ export class HuiSection extends ConditionalListenerMixin<LovelaceSectionConfig>(
} }
} }
private _cardVisibilityChanged = () => {
this._updateVisibility();
};
protected _updateVisibility(conditionsMet?: boolean) { protected _updateVisibility(conditionsMet?: boolean) {
if (!this._layoutElement || !this._config) { if (!this._layoutElement || !this._config) {
return; return;
@@ -220,7 +236,16 @@ export class HuiSection extends ConditionalListenerMixin<LovelaceSectionConfig>(
(!this._config.visibility || (!this._config.visibility ||
checkConditionsMet(this._config.visibility, this.hass)); checkConditionsMet(this._config.visibility, this.hass));
this._setElementVisibility(visible); if (!visible) {
this._setElementVisibility(false);
return;
}
// Hide section when all cards are conditionally hidden
const allCardsHidden =
this._cards.length > 0 && this._cards.every((card) => card.hidden);
this._setElementVisibility(!allCardsHidden);
} }
private _setElementVisibility(visible: boolean) { private _setElementVisibility(visible: boolean) {
@@ -232,9 +257,9 @@ export class HuiSection extends ConditionalListenerMixin<LovelaceSectionConfig>(
fireEvent(this, "section-visibility-changed", { value: visible }); fireEvent(this, "section-visibility-changed", { value: visible });
} }
if (!visible && this._layoutElement.parentElement) { // Always keep layout element connected so cards can still update
this.removeChild(this._layoutElement); // their visibility and bubble events back to the section.
} else if (visible && !this._layoutElement.parentElement) { if (!this._layoutElement.parentElement) {
this.appendChild(this._layoutElement); this.appendChild(this._layoutElement);
} }
} }