Addon startup waits for healthy (#4376)

* Addon startup waits for healthy

* fix import for pylint

* wait_for to 5 in tests

* Adjust tests to simplify async tasks

* Remove wait_boot time from addons.boot tests

* Eliminate async task race conditions in tests

tests/api/test_store.py

@@ -1,13 +1,25 @@
 """Test Store API."""
-from unittest.mock import patch
+
+import asyncio
+from unittest.mock import MagicMock, PropertyMock, patch
 
 from aiohttp.test_utils import TestClient
 import pytest
 
+from supervisor.addons.addon import Addon
+from supervisor.arch import CpuArch
+from supervisor.const import AddonState
 from supervisor.coresys import CoreSys
+from supervisor.docker.addon import DockerAddon
+from supervisor.docker.const import ContainerState
+from supervisor.docker.interface import DockerInterface
+from supervisor.docker.monitor import DockerContainerStateEvent
 from supervisor.store.addon import AddonStore
 from supervisor.store.repository import Repository
 
+from tests.common import load_json_fixture
+from tests.const import TEST_ADDON_SLUG
+
 REPO_URL = "https://github.com/awesome-developer/awesome-repo"
 
 
@@ -102,3 +114,74 @@ async def test_api_store_remove_repository(
     assert response.status == 200
     assert repository.source not in coresys.store.repository_urls
     assert repository.slug not in coresys.store.repositories
+
+
+async def test_api_store_update_healthcheck(
+    api_client: TestClient,
+    coresys: CoreSys,
+    install_addon_ssh: Addon,
+    container: MagicMock,
+    tmp_supervisor_data,
+    path_extern,
+):
+    """Test updating an addon with healthcheck waits for health status."""
+    container.status = "running"
+    container.attrs["Config"] = {"Healthcheck": "exists"}
+    install_addon_ssh.path_data.mkdir()
+    await install_addon_ssh.load()
+    with patch(
+        "supervisor.store.data.read_json_or_yaml_file",
+        return_value=load_json_fixture("addon-config-add-image.json"),
+    ):
+        await coresys.store.data.update()
+
+    assert install_addon_ssh.need_update is True
+
+    state_changes: list[AddonState] = []
+
+    async def container_events():
+        nonlocal state_changes
+        await asyncio.sleep(0.01)
+
+        await install_addon_ssh.container_state_changed(
+            DockerContainerStateEvent(
+                name=f"addon_{TEST_ADDON_SLUG}",
+                state=ContainerState.STOPPED,
+                id="abc123",
+                time=1,
+            )
+        )
+
+        state_changes.append(install_addon_ssh.state)
+        await install_addon_ssh.container_state_changed(
+            DockerContainerStateEvent(
+                name=f"addon_{TEST_ADDON_SLUG}",
+                state=ContainerState.RUNNING,
+                id="abc123",
+                time=1,
+            )
+        )
+
+        state_changes.append(install_addon_ssh.state)
+        await install_addon_ssh.container_state_changed(
+            DockerContainerStateEvent(
+                name=f"addon_{TEST_ADDON_SLUG}",
+                state=ContainerState.HEALTHY,
+                id="abc123",
+                time=1,
+            )
+        )
+
+    async def container_events_task(*args, **kwargs):
+        asyncio.create_task(container_events())
+
+    with patch.object(DockerAddon, "run", new=container_events_task), patch.object(
+        DockerInterface, "_install"
+    ), patch.object(DockerAddon, "_is_running", return_value=False), patch.object(
+        CpuArch, "supported", new=PropertyMock(return_value=["amd64"])
+    ):
+        resp = await api_client.post(f"/store/addons/{TEST_ADDON_SLUG}/update")
+
+    assert state_changes == [AddonState.STOPPED, AddonState.STARTUP]
+    assert install_addon_ssh.state == AddonState.STARTED
+    assert resp.status == 200