mirror of
https://github.com/home-assistant/supervisor.git
synced 2026-05-08 08:58:31 +01:00
Fix submounts of /dev being read-only with Docker 25+ (#4997)
As described in #4996, Docker 25+ changes made sub-mounts of the /dev filesystem to be mounted read-only. Revert to the previous behavior by adjusting the ReadOnlyNonRecursive option. Cleaner way would be to upstream support for setting this option via Mount class arguments, so this change is meant to be rather a hotfix for the issue. Even better approach would be mounting /dev non-recursively, and taking care of creating all necessary filesystems when creating containers in Supervisor.
This commit is contained in:
@@ -19,6 +19,7 @@ from supervisor.resolution.const import ContextType, IssueType
|
||||
from supervisor.resolution.data import Issue
|
||||
|
||||
from ..common import load_json_fixture
|
||||
from . import DEV_MOUNT
|
||||
|
||||
|
||||
@pytest.fixture(name="addonsdata_system")
|
||||
@@ -66,11 +67,8 @@ def test_base_volumes_included(
|
||||
coresys, addonsdata_system, "basic-addon-config.json"
|
||||
)
|
||||
|
||||
# Dev added as ro
|
||||
assert (
|
||||
Mount(type="bind", source="/dev", target="/dev", read_only=True)
|
||||
in docker_addon.mounts
|
||||
)
|
||||
# Dev added as ro with bind-recursive=writable option
|
||||
assert DEV_MOUNT in docker_addon.mounts
|
||||
|
||||
# Data added as rw
|
||||
assert (
|
||||
|
||||
Reference in New Issue
Block a user