mirror of
https://github.com/home-assistant/supervisor.git
synced 2026-08-20 21:27:46 +01:00
Stefan AgnerandGitHub
ed91b18c4b
* tests: enable flake8-pytest-style (PT) ruff rules Enable the `PT` ruff rule set and fix the resulting violations across the test suite: - PT006: pass parametrize argument names as tuples instead of a single comma-separated string. - PT022: switch fixtures that have no teardown from `yield` to `return` so the lack of cleanup is obvious at a glance. - PT011: add `match=` to broad `pytest.raises(ValueError)` blocks so the expected error is anchored to a specific message. - PT012: hoist setup (patches, branching) out of `pytest.raises()` blocks so only the call that is expected to raise remains inside. - PT013: replace `from pytest import X` with `import pytest` and access attributes via the module. - PT015: replace `try/except` + `assert False` patterns with `pytest.raises(...)`. - PT017: replace `assert` on exceptions inside `except` blocks with `pytest.raises(...) as exc_info` and assert on `exc_info.value`. No behavioral changes to the tests; the full suite still passes. * tests: address review feedback on PT ruff rule enablement - Fix fixture return-type annotations after switching `yield` to `return` in tests/conftest.py: drop the `Generator[...]`/`AsyncGenerator[...]` wrapper for `dns_manager_service`, `supervisor_internet`, `websession`, and `mock_update_data` so the annotation matches what the fixture actually returns. - Correct the return-type annotation of `fixture_ip6config_service` from `IP4ConfigService` to `IP6ConfigService`. - Fix recurring "excepiton" typo in tests/utils/test_exception_helper.py. * tests: verify backup cleanup on permission error After `test_new_backup_permission_error` raises `BackupPermissionError`, assert that no tarfile was left behind and `tmp_path` is empty. The previous version only checked that the exception was raised, which missed any regression where a partial tarfile would survive the failed create. * tests: rename DNS_GOOD_V6 to DNS_V6_UNSUPPORTED The constant was named "good" but its tests assert that the URLs are rejected by the DNS validator. The IPv6 URLs are well-formed but currently rejected because IPv6 doesn't work with the Docker network (see `dns_url` in supervisor/validate.py). Rename the constant and the related test to make the intent obvious.
121 lines
3.5 KiB
Python
121 lines
3.5 KiB
Python
"""Test rauc dbus interface."""
|
|
|
|
# pylint: disable=import-error
|
|
from dbus_fast.aio.message_bus import MessageBus
|
|
import pytest
|
|
|
|
from supervisor.dbus.const import RaucState
|
|
from supervisor.dbus.rauc import Rauc
|
|
from supervisor.exceptions import DBusNotConnectedError
|
|
|
|
from tests.common import mock_dbus_services
|
|
from tests.dbus_service_mocks.rauc import Rauc as RaucService
|
|
|
|
|
|
@pytest.fixture(name="rauc_service")
|
|
async def fixture_rauc_service(dbus_session_bus: MessageBus) -> RaucService:
|
|
"""Mock rauc dbus service."""
|
|
return (await mock_dbus_services({"rauc": None}, dbus_session_bus))["rauc"]
|
|
|
|
|
|
async def test_rauc_info(rauc_service: RaucService, dbus_session_bus: MessageBus):
|
|
"""Test rauc properties."""
|
|
rauc = Rauc()
|
|
|
|
assert rauc.boot_slot is None
|
|
assert rauc.operation is None
|
|
assert rauc.last_error is None
|
|
|
|
await rauc.connect(dbus_session_bus)
|
|
|
|
assert rauc.boot_slot == "B"
|
|
assert rauc.operation == "idle"
|
|
assert rauc.last_error == ""
|
|
|
|
rauc_service.emit_properties_changed({"LastError": "Error!"})
|
|
await rauc_service.ping()
|
|
assert rauc.last_error == "Error!"
|
|
|
|
rauc_service.emit_properties_changed({}, ["LastError"])
|
|
await rauc_service.ping()
|
|
await rauc_service.ping() # To process the follow-up get all properties call
|
|
assert rauc.last_error == ""
|
|
|
|
|
|
async def test_install(rauc_service: RaucService, dbus_session_bus: MessageBus):
|
|
"""Test install."""
|
|
rauc = Rauc()
|
|
|
|
with pytest.raises(DBusNotConnectedError):
|
|
await rauc.install("rauc_file")
|
|
|
|
await rauc.connect(dbus_session_bus)
|
|
|
|
async with rauc.signal_completed() as signal:
|
|
assert await rauc.install("rauc_file") is None
|
|
assert await signal.wait_for_signal() == [0]
|
|
|
|
|
|
async def test_get_slot_status(rauc_service: RaucService, dbus_session_bus: MessageBus):
|
|
"""Test get slot status."""
|
|
rauc = Rauc()
|
|
|
|
with pytest.raises(DBusNotConnectedError):
|
|
await rauc.get_slot_status()
|
|
|
|
await rauc.connect(dbus_session_bus)
|
|
|
|
slot_status = await rauc.get_slot_status()
|
|
assert len(slot_status) == 6
|
|
assert slot_status[0][0] == "kernel.0"
|
|
assert slot_status[0][1]["boot-status"] == "good"
|
|
assert slot_status[0][1]["device"] == "/dev/disk/by-partlabel/hassos-kernel0"
|
|
assert slot_status[0][1]["bootname"] == "A"
|
|
assert slot_status[4][0] == "kernel.1"
|
|
assert slot_status[4][1]["boot-status"] == "good"
|
|
assert slot_status[4][1]["device"] == "/dev/disk/by-partlabel/hassos-kernel1"
|
|
assert slot_status[4][1]["bootname"] == "B"
|
|
|
|
|
|
async def test_mark(rauc_service: RaucService, dbus_session_bus: MessageBus):
|
|
"""Test mark."""
|
|
rauc = Rauc()
|
|
|
|
with pytest.raises(DBusNotConnectedError):
|
|
await rauc.mark(RaucState.GOOD, "booted")
|
|
|
|
await rauc.connect(dbus_session_bus)
|
|
|
|
mark = await rauc.mark(RaucState.GOOD, "booted")
|
|
assert mark[0] == "kernel.1"
|
|
assert mark[1] == "marked slot kernel.1 as good"
|
|
|
|
|
|
async def test_dbus_rauc_connect_error(
|
|
dbus_session_bus: MessageBus, caplog: pytest.LogCaptureFixture
|
|
):
|
|
"""Test connecting to rauc error."""
|
|
rauc = Rauc()
|
|
await rauc.connect(dbus_session_bus)
|
|
assert "Host has no rauc support" in caplog.text
|
|
|
|
|
|
async def test_test_slot_status(
|
|
rauc_service: RaucService, dbus_session_bus: MessageBus
|
|
):
|
|
"""Test get slot status."""
|
|
rauc = Rauc()
|
|
|
|
await rauc.connect(dbus_session_bus)
|
|
|
|
slot_status = await rauc.get_slot_status()
|
|
out = {}
|
|
for slot in slot_status:
|
|
for k in slot[1]:
|
|
if k in out:
|
|
out[k] += 1
|
|
else:
|
|
out[k] = 1
|
|
|
|
assert out
|