mirror of
https://github.com/home-assistant/supervisor.git
synced 2026-08-18 19:02:33 +01:00
Stefan AgnerandGitHub
ed91b18c4b
* tests: enable flake8-pytest-style (PT) ruff rules Enable the `PT` ruff rule set and fix the resulting violations across the test suite: - PT006: pass parametrize argument names as tuples instead of a single comma-separated string. - PT022: switch fixtures that have no teardown from `yield` to `return` so the lack of cleanup is obvious at a glance. - PT011: add `match=` to broad `pytest.raises(ValueError)` blocks so the expected error is anchored to a specific message. - PT012: hoist setup (patches, branching) out of `pytest.raises()` blocks so only the call that is expected to raise remains inside. - PT013: replace `from pytest import X` with `import pytest` and access attributes via the module. - PT015: replace `try/except` + `assert False` patterns with `pytest.raises(...)`. - PT017: replace `assert` on exceptions inside `except` blocks with `pytest.raises(...) as exc_info` and assert on `exc_info.value`. No behavioral changes to the tests; the full suite still passes. * tests: address review feedback on PT ruff rule enablement - Fix fixture return-type annotations after switching `yield` to `return` in tests/conftest.py: drop the `Generator[...]`/`AsyncGenerator[...]` wrapper for `dns_manager_service`, `supervisor_internet`, `websession`, and `mock_update_data` so the annotation matches what the fixture actually returns. - Correct the return-type annotation of `fixture_ip6config_service` from `IP4ConfigService` to `IP6ConfigService`. - Fix recurring "excepiton" typo in tests/utils/test_exception_helper.py. * tests: verify backup cleanup on permission error After `test_new_backup_permission_error` raises `BackupPermissionError`, assert that no tarfile was left behind and `tmp_path` is empty. The previous version only checked that the exception was raised, which missed any regression where a partial tarfile would survive the failed create. * tests: rename DNS_GOOD_V6 to DNS_V6_UNSUPPORTED The constant was named "good" but its tests assert that the URLs are rejected by the DNS validator. The IPv6 URLs are well-formed but currently rejected because IPv6 doesn't work with the Docker network (see `dns_url` in supervisor/validate.py). Rename the constant and the related test to make the intent obvious.
106 lines
3.2 KiB
Python
106 lines
3.2 KiB
Python
"""Test TimeDate dbus interface."""
|
|
|
|
# pylint: disable=import-error
|
|
from datetime import UTC, datetime
|
|
|
|
from dbus_fast.aio.message_bus import MessageBus
|
|
import pytest
|
|
|
|
from supervisor.dbus.timedate import TimeDate
|
|
from supervisor.exceptions import DBusNotConnectedError
|
|
|
|
from tests.common import mock_dbus_services
|
|
from tests.dbus_service_mocks.timedate import TimeDate as TimeDateService
|
|
|
|
|
|
@pytest.fixture(name="timedate_service")
|
|
async def fixture_timedate_service(dbus_session_bus: MessageBus) -> TimeDateService:
|
|
"""Mock timedate dbus service."""
|
|
return (await mock_dbus_services({"timedate": None}, dbus_session_bus))["timedate"]
|
|
|
|
|
|
async def test_timedate_info(
|
|
timedate_service: TimeDateService, dbus_session_bus: MessageBus
|
|
):
|
|
"""Test timedate properties."""
|
|
timedate = TimeDate()
|
|
|
|
assert timedate.ntp is None
|
|
|
|
await timedate.connect(dbus_session_bus)
|
|
|
|
assert timedate.ntp is True
|
|
|
|
timedate_service.emit_properties_changed({"NTP": False})
|
|
await timedate_service.ping()
|
|
assert timedate.ntp is False
|
|
|
|
timedate_service.emit_properties_changed({}, ["NTP"])
|
|
await timedate_service.ping()
|
|
await timedate_service.ping() # To process the follow-up get all properties call
|
|
assert timedate.ntp is True
|
|
|
|
|
|
async def test_dbus_settime(
|
|
timedate_service: TimeDateService, dbus_session_bus: MessageBus
|
|
):
|
|
"""Set timestamp on backend."""
|
|
timedate_service.SetTime.calls.clear()
|
|
timedate = TimeDate()
|
|
|
|
test_dt = datetime(2021, 5, 19, 8, 36, 54, 405718, tzinfo=UTC)
|
|
|
|
with pytest.raises(DBusNotConnectedError):
|
|
await timedate.set_time(test_dt)
|
|
|
|
await timedate.connect(dbus_session_bus)
|
|
|
|
assert await timedate.set_time(test_dt) is None
|
|
assert timedate_service.SetTime.calls == [(1621413414405718, False, False)]
|
|
|
|
|
|
async def test_dbus_setntp(
|
|
timedate_service: TimeDateService, dbus_session_bus: MessageBus
|
|
):
|
|
"""Disable NTP on backend."""
|
|
timedate_service.SetNTP.calls.clear()
|
|
timedate = TimeDate()
|
|
|
|
with pytest.raises(DBusNotConnectedError):
|
|
await timedate.set_ntp(False)
|
|
|
|
await timedate.connect(dbus_session_bus)
|
|
|
|
assert timedate.ntp is True
|
|
assert await timedate.set_ntp(False) is None
|
|
assert timedate_service.SetNTP.calls == [(False, False)]
|
|
await timedate_service.ping()
|
|
assert timedate.ntp is False
|
|
|
|
|
|
async def test_dbus_set_timezone(
|
|
timedate_service: TimeDateService, dbus_session_bus: MessageBus
|
|
):
|
|
"""Test setting of host timezone."""
|
|
timedate_service.SetTimezone.calls.clear()
|
|
timedate = TimeDate()
|
|
|
|
with pytest.raises(DBusNotConnectedError):
|
|
await timedate.set_timezone("Europe/Prague")
|
|
|
|
await timedate.connect(dbus_session_bus)
|
|
|
|
assert await timedate.set_timezone("Europe/Prague") is None
|
|
assert timedate_service.SetTimezone.calls == [("Europe/Prague", False)]
|
|
await timedate_service.ping()
|
|
assert timedate.timezone == "Europe/Prague"
|
|
|
|
|
|
async def test_dbus_timedate_connect_error(
|
|
dbus_session_bus: MessageBus, caplog: pytest.LogCaptureFixture
|
|
):
|
|
"""Test connecting to timedate error."""
|
|
timedate = TimeDate()
|
|
await timedate.connect(dbus_session_bus)
|
|
assert "No timedate support on the host" in caplog.text
|