1
0
mirror of https://github.com/home-assistant/supervisor.git synced 2026-04-02 08:12:47 +01:00
Files
supervisor/tests/backups/test_backup.py
Stefan Agner e630ec1ac4 Include Docker registry configurations in backups (#6674)
* Include Docker registry configurations in backups

Docker registry credentials were removed from backup metadata in a prior
change to avoid exposing secrets in unencrypted data. Now that the encrypted
supervisor.tar inner archive exists, add docker.json alongside mounts.json
to securely backup and restore registry configurations.

On restore, registries from the backup are merged with any existing ones.
Old backups without docker.json are handled gracefully.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Increase test coverage by testing more error paths

* Address review feedback for Docker registry backup

Remove unnecessary dict() copy when serializing registries for backup
since the property already returns a dict.

Change DockerConfig.registries to use direct key access instead of
.get() with a default. The schema guarantees the key exists, and
.get() with a default would return a detached temporary dict that
silently discards updates.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-30 18:34:27 +02:00

639 lines
22 KiB
Python

"""Test backups."""
from contextlib import AbstractContextManager, nullcontext as does_not_raise
from os import listdir
from pathlib import Path
from shutil import copy
import tarfile
from unittest.mock import MagicMock, patch
import pytest
from securetar import AddFileError, InvalidPasswordError, SecureTarReadError
from supervisor.addons.addon import Addon
from supervisor.backups.backup import Backup, BackupLocation
from supervisor.backups.const import BackupType
from supervisor.coresys import CoreSys
from supervisor.exceptions import (
AddonsError,
BackupError,
BackupFileExistError,
BackupFileNotFoundError,
BackupInvalidError,
BackupPermissionError,
)
from supervisor.jobs import JobSchedulerOptions
from supervisor.mounts.mount import Mount
from tests.common import get_fixture_path
async def test_new_backup_stays_in_folder(coresys: CoreSys, tmp_path: Path):
"""Test making a new backup operates entirely within folder where backup will be stored."""
backup = Backup(coresys, tmp_path / "my_backup.tar", "test", None)
backup.new("test", "2023-07-21T21:05:00.000000+00:00", BackupType.FULL)
assert not listdir(tmp_path)
async with backup.create():
assert len(listdir(tmp_path)) == 1
assert backup.tarfile.exists()
assert len(listdir(tmp_path)) == 1
assert backup.tarfile.exists()
async def test_new_backup_permission_error(coresys: CoreSys, tmp_path: Path):
"""Test if a permission error is correctly handled when a new backup is created."""
backup = Backup(coresys, tmp_path / "my_backup.tar", "test", None)
backup.new("test", "2023-07-21T21:05:00.000000+00:00", BackupType.FULL)
assert not listdir(tmp_path)
with (
patch(
"tarfile.open",
MagicMock(side_effect=PermissionError),
),
pytest.raises(BackupPermissionError),
):
async with backup.create():
assert len(listdir(tmp_path)) == 1
assert backup.tarfile.exists()
async def test_new_backup_exists_error(coresys: CoreSys, tmp_path: Path):
"""Test if a permission error is correctly handled when a new backup is created."""
backup_file = tmp_path / "my_backup.tar"
backup = Backup(coresys, backup_file, "test", None)
backup.new("test", "2023-07-21T21:05:00.000000+00:00", BackupType.FULL)
backup_file.touch()
with (
pytest.raises(BackupFileExistError),
):
async with backup.create():
pass
async def test_backup_error_addon(
coresys: CoreSys, install_addon_ssh: Addon, tmp_path: Path
):
"""Test if errors during add-on backup is correctly recorded in jobs."""
backup_file = tmp_path / "my_backup.tar"
backup = Backup(coresys, backup_file, "test", None)
backup.new("test", "2023-07-21T21:05:00.000000+00:00", BackupType.FULL)
install_addon_ssh.backup = MagicMock(
side_effect=(err := AddonsError("Fake add-on backup error"))
)
async with backup.create():
# Validate that the add-on exception is collected in the main job
backup_store_addons_job, backup_task = coresys.jobs.schedule_job(
backup.store_addons, JobSchedulerOptions(), [install_addon_ssh]
)
await backup_task
assert len(backup_store_addons_job.errors) == 1
assert str(err) in backup_store_addons_job.errors[0].message
# Check backup_addon_restore child job has the same error
child_jobs = [
job
for job in coresys.jobs.jobs
if job.parent_id == backup_store_addons_job.uuid
]
assert len(child_jobs) == 1
assert child_jobs[0].errors[0].message == str(err)
async def test_backup_error_folder(
coresys: CoreSys, tmp_supervisor_data: Path, tmp_path: Path
):
"""Test if errors during folder backup is correctly recorded in jobs."""
backup_file = tmp_path / "my_backup.tar"
backup = Backup(coresys, backup_file, "test", None)
backup.new("test", "2023-07-21T21:05:00.000000+00:00", BackupType.FULL)
async with backup.create():
# Validate that the folder exception is collected in the main job
with patch(
"supervisor.backups.backup.atomic_contents_add",
MagicMock(
side_effect=(err := AddFileError(".", "Fake folder backup error"))
),
):
backup_store_folders, backup_task = coresys.jobs.schedule_job(
backup.store_folders, JobSchedulerOptions(), ["media"]
)
await backup_task
assert len(backup_store_folders.errors) == 1
assert str(err) in backup_store_folders.errors[0].message
# Check backup_folder_save child job has the same error
child_jobs = [
job
for job in coresys.jobs.jobs
if job.parent_id == backup_store_folders.uuid
]
assert len(child_jobs) == 1
assert str(err) in child_jobs[0].errors[0].message
async def test_consolidate_conflict_varied_encryption(
coresys: CoreSys, tmp_path: Path, caplog: pytest.LogCaptureFixture
):
"""Test consolidate with two backups in same location and varied encryption."""
enc_tar = Path(copy(get_fixture_path("test_consolidate.tar"), tmp_path))
enc_backup = Backup(coresys, enc_tar, "test", None)
await enc_backup.load()
unc_tar = Path(copy(get_fixture_path("test_consolidate_unc.tar"), tmp_path))
unc_backup = Backup(coresys, unc_tar, "test", None)
await unc_backup.load()
enc_backup.consolidate(unc_backup)
assert (
f"Backup d9c48f8b exists in two files in locations None. Ignoring {enc_tar.as_posix()}"
in caplog.text
)
assert enc_backup.all_locations == {
None: BackupLocation(path=unc_tar, protected=False, size_bytes=10240),
}
async def test_consolidate(
coresys: CoreSys,
tmp_path: Path,
tmp_supervisor_data: Path,
caplog: pytest.LogCaptureFixture,
):
"""Test consolidate with two backups in different location and varied encryption."""
(mount_dir := coresys.config.path_mounts / "backup_test").mkdir()
enc_tar = Path(copy(get_fixture_path("test_consolidate.tar"), tmp_path))
enc_backup = Backup(coresys, enc_tar, "test", None)
await enc_backup.load()
unc_tar = Path(copy(get_fixture_path("test_consolidate_unc.tar"), mount_dir))
unc_backup = Backup(coresys, unc_tar, "test", "backup_test")
await unc_backup.load()
enc_backup.consolidate(unc_backup)
assert (
"Backup in backup_test and None both have slug d9c48f8b but are not the same!"
not in caplog.text
)
assert enc_backup.all_locations == {
None: BackupLocation(path=enc_tar, protected=True, size_bytes=10240),
"backup_test": BackupLocation(path=unc_tar, protected=False, size_bytes=10240),
}
@pytest.mark.usefixtures("tmp_supervisor_data")
async def test_consolidate_failure(coresys: CoreSys, tmp_path: Path):
"""Test consolidate with two backups that are not the same."""
(mount_dir := coresys.config.path_mounts / "backup_test").mkdir()
tar1 = Path(copy(get_fixture_path("test_consolidate_unc.tar"), tmp_path))
backup1 = Backup(coresys, tar1, "test", None)
await backup1.load()
tar2 = Path(copy(get_fixture_path("backup_example.tar"), mount_dir))
backup2 = Backup(coresys, tar2, "test", "backup_test")
await backup2.load()
with pytest.raises(
ValueError,
match=f"Backup {backup1.slug} and {backup2.slug} are not the same backup",
):
backup1.consolidate(backup2)
# Force slugs to be the same to run the fields check
backup1._data["slug"] = backup2.slug # pylint: disable=protected-access
with pytest.raises(
BackupInvalidError,
match=f"Cannot consolidate backups in {backup2.location} and {backup1.location} with slug {backup1.slug}",
):
backup1.consolidate(backup2)
@pytest.mark.parametrize(
(
"tarfile_side_effect",
"securetar_side_effect",
"expected_exception",
),
[
(None, None, does_not_raise()), # Successful validation
(
FileNotFoundError,
None,
pytest.raises(
BackupFileNotFoundError,
match=r"Cannot validate backup at [^, ]+, file does not exist!",
),
), # File not found
(
None,
tarfile.ReadError,
pytest.raises(
BackupInvalidError, match="Invalid password for backup 93b462f8"
),
), # Invalid password (legacy securetar exception)
(
None,
SecureTarReadError,
pytest.raises(
BackupInvalidError, match="Invalid password for backup 93b462f8"
),
), # Invalid password (securetar >= 2026.2.0 raises SecureTarReadError)
(
None,
InvalidPasswordError,
pytest.raises(
BackupInvalidError, match="Invalid password for backup 93b462f8"
),
), # Invalid password (securetar >= 2026.2.0 with v3 backup raises InvalidPasswordError)
],
)
async def test_validate_backup(
coresys: CoreSys,
tmp_path: Path,
tarfile_side_effect: type[Exception] | None,
securetar_side_effect: type[Exception] | None,
expected_exception: AbstractContextManager,
):
"""Parameterized test for validate_backup.
Note that it is paramount that BackupInvalidError is raised for invalid password
cases, as this is used by the Core to determine if a backup password is invalid
and offer a input field to the user to input the correct password.
"""
enc_tar = Path(copy(get_fixture_path("backup_example_enc.tar"), tmp_path))
enc_backup = Backup(coresys, enc_tar, "test", None)
await enc_backup.load()
backup_tar_mock = MagicMock(spec_set=tarfile.TarFile)
backup_tar_mock.getmembers.return_value = [
MagicMock(name="test.tar.gz")
] # Fake tar entries
backup_tar_mock.extractfile.return_value = MagicMock()
backup_context_mock = MagicMock()
backup_context_mock.__enter__.return_value = backup_tar_mock
backup_context_mock.__exit__.return_value = False
with (
patch(
"tarfile.open",
MagicMock(
return_value=backup_context_mock,
side_effect=tarfile_side_effect,
),
),
patch(
"supervisor.backups.backup.SecureTarFile",
MagicMock(side_effect=securetar_side_effect),
),
expected_exception,
):
await enc_backup.validate_backup(None)
@pytest.mark.parametrize(
("password", "expected_exception"),
[
("supervisor", does_not_raise()),
(
"wrong_password",
pytest.raises(
BackupInvalidError, match="Invalid password for backup f92f0339"
),
),
(
None,
pytest.raises(
BackupInvalidError, match="Invalid password for backup f92f0339"
),
),
(
"",
pytest.raises(
BackupInvalidError, match="Invalid password for backup f92f0339"
),
),
],
)
async def test_validate_backup_v3(
coresys: CoreSys,
tmp_path: Path,
password: str | None,
expected_exception: AbstractContextManager,
):
"""Test validate_backup with a real SecureTar v3 encrypted backup.
SecureTar v3 uses Argon2id key derivation and raises InvalidPasswordError
on wrong passwords. It is paramount that BackupInvalidError is raised for
invalid password cases, as this is used by the Core to determine if a backup
password is invalid and offer a dialog to the user to input the correct
password.
"""
v3_tar = Path(copy(get_fixture_path("backup_example_sec_v3.tar"), tmp_path))
v3_backup = Backup(coresys, v3_tar, "test", None)
await v3_backup.load()
v3_backup.set_password(password)
with expected_exception:
await v3_backup.validate_backup(None)
@pytest.mark.parametrize(
("password", "expect_protected"),
[
("my_password", True),
(None, False),
("", False),
],
)
async def test_new_backup_empty_password_not_protected(
coresys: CoreSys,
tmp_path: Path,
password: str | None,
expect_protected: bool,
):
"""Test that empty string password is treated as no password on backup creation."""
backup = Backup(coresys, tmp_path / "my_backup.tar", "test", None)
backup.new(
"test", "2023-07-21T21:05:00.000000+00:00", BackupType.FULL, password=password
)
assert backup.protected is expect_protected
@pytest.mark.parametrize(
("password", "expected_password"),
[
("my_password", "my_password"),
(None, None),
("", None),
],
)
def test_set_password_empty_string_is_none(
coresys: CoreSys,
tmp_path: Path,
password: str | None,
expected_password: str | None,
):
"""Test that set_password treats empty string as None."""
backup = Backup(coresys, tmp_path / "my_backup.tar", "test", None)
backup.set_password(password)
assert backup._password == expected_password # pylint: disable=protected-access
async def test_store_supervisor_config_nothing_to_backup(
coresys: CoreSys, tmp_path: Path
):
"""Test storing supervisor config when no mounts or registries configured."""
backup = Backup(coresys, tmp_path / "my_backup.tar", "test", None)
backup.new("test", "2023-07-21T21:05:00.000000+00:00", BackupType.FULL)
# Create backup context to enable store_supervisor_config
async with backup.create():
# Store config (should do nothing when nothing to back up)
await backup.store_supervisor_config()
async def test_store_supervisor_config_with_mounts(coresys: CoreSys, tmp_path: Path):
"""Test storing supervisor config when mounts are configured."""
# Add a test mount directly to manager state (avoids needing dbus)
mount = Mount.from_dict(
coresys,
{
"name": "test_backup_share",
"usage": "backup",
"type": "cifs",
"server": "192.168.1.100",
"share": "backup_share",
},
)
coresys.mounts._mounts[mount.name] = mount # noqa: SLF001 # pylint: disable=protected-access
backup = Backup(coresys, tmp_path / "my_backup.tar", "test", None)
backup.new("test", "2023-07-21T21:05:00.000000+00:00", BackupType.FULL)
# Create backup context and store supervisor config
async with backup.create():
await backup.store_supervisor_config()
async def test_store_supervisor_config_with_registries(
coresys: CoreSys, tmp_path: Path
):
"""Test storing supervisor config when docker registries are configured."""
coresys.docker.config.registries["ghcr.io"] = {
"username": "user",
"password": "secret",
}
backup = Backup(coresys, tmp_path / "my_backup.tar", "test", None)
backup.new("test", "2023-07-21T21:05:00.000000+00:00", BackupType.FULL)
async with backup.create():
await backup.store_supervisor_config()
async def test_store_supervisor_config_with_mounts_and_registries(
coresys: CoreSys, tmp_path: Path
):
"""Test storing supervisor config with both mounts and registries."""
mount = Mount.from_dict(
coresys,
{
"name": "test_share",
"usage": "backup",
"type": "cifs",
"server": "192.168.1.100",
"share": "backup_share",
},
)
coresys.mounts._mounts[mount.name] = mount # noqa: SLF001 # pylint: disable=protected-access
coresys.docker.config.registries["ghcr.io"] = {
"username": "user",
"password": "secret",
}
backup = Backup(coresys, tmp_path / "my_backup.tar", "test", None)
backup.new("test", "2023-07-21T21:05:00.000000+00:00", BackupType.FULL)
async with backup.create():
await backup.store_supervisor_config()
async def test_restore_supervisor_config_no_tar(coresys: CoreSys, tmp_path: Path):
"""Test restoring supervisor config when backup has no supervisor tar."""
backup = Backup(coresys, tmp_path / "my_backup.tar", "test", None)
backup.new("test", "2023-07-21T21:05:00.000000+00:00", BackupType.FULL)
# Create the backup (no mounts or registries, so no supervisor.tar inside)
async with backup.create():
pass
# Open and restore - should succeed with nothing to do
async with backup.open(None):
success, tasks = await backup.restore_supervisor_config()
assert success is True
assert tasks == []
async def test_restore_supervisor_config_with_registries(
coresys: CoreSys, tmp_path: Path
):
"""Test restoring docker registries from supervisor config in backup."""
# Configure registries and create a backup
coresys.docker.config.registries["ghcr.io"] = {
"username": "user",
"password": "secret",
}
coresys.docker.config.registries["docker.io"] = {
"username": "docker_user",
"password": "docker_pass",
}
backup = Backup(coresys, tmp_path / "my_backup.tar", "test", None)
backup.new("test", "2023-07-21T21:05:00.000000+00:00", BackupType.FULL)
async with backup.create():
await backup.store_supervisor_config()
# Clear registries
coresys.docker.config.registries.clear()
assert not coresys.docker.config.registries
# Restore from backup
async with backup.open(None):
success, tasks = await backup.restore_supervisor_config()
assert success is True
assert tasks == []
# Verify registries were restored
assert "ghcr.io" in coresys.docker.config.registries
assert coresys.docker.config.registries["ghcr.io"]["username"] == "user"
assert coresys.docker.config.registries["ghcr.io"]["password"] == "secret"
assert "docker.io" in coresys.docker.config.registries
assert coresys.docker.config.registries["docker.io"]["username"] == "docker_user"
async def test_restore_supervisor_config_registries_merge(
coresys: CoreSys, tmp_path: Path
):
"""Test that restored registries merge with existing ones."""
# Set up a registry that will be in the backup
coresys.docker.config.registries["ghcr.io"] = {
"username": "ghcr_user",
"password": "ghcr_pass",
}
backup = Backup(coresys, tmp_path / "my_backup.tar", "test", None)
backup.new("test", "2023-07-21T21:05:00.000000+00:00", BackupType.FULL)
async with backup.create():
await backup.store_supervisor_config()
# Clear backup registry, add a different one
coresys.docker.config.registries.clear()
coresys.docker.config.registries["docker.io"] = {
"username": "hub_user",
"password": "hub_pass",
}
# Restore - should merge backup registries with existing
async with backup.open(None):
success, tasks = await backup.restore_supervisor_config()
assert success is True
assert tasks == []
# Both registries should exist
assert "ghcr.io" in coresys.docker.config.registries
assert "docker.io" in coresys.docker.config.registries
assert coresys.docker.config.registries["ghcr.io"]["username"] == "ghcr_user"
async def test_restore_supervisor_config_invalid_docker_data(
coresys: CoreSys, tmp_path: Path
):
"""Test restore with invalid docker.json reports failure but doesn't crash."""
# Create a backup with valid registries
coresys.docker.config.registries["ghcr.io"] = {
"username": "user",
"password": "secret",
}
backup = Backup(coresys, tmp_path / "my_backup.tar", "test", None)
backup.new("test", "2023-07-21T21:05:00.000000+00:00", BackupType.FULL)
async with backup.create():
await backup.store_supervisor_config()
# Patch the executor to return invalid docker data
original_run = coresys.run_in_executor
async def _patched_run(func, *args, **kwargs):
result = await original_run(func, *args, **kwargs)
if isinstance(result, tuple) and len(result) == 2:
# Return mounts_data unchanged, but corrupt docker_data
return (result[0], {"registries": {"bad": "not_a_valid_registry"}})
return result
coresys.docker.config.registries.clear()
async with backup.open(None):
with patch.object(coresys, "run_in_executor", side_effect=_patched_run):
success, tasks = await backup.restore_supervisor_config()
assert success is False
assert tasks == []
# No registries should have been restored
assert not coresys.docker.config.registries
async def test_store_supervisor_config_tar_error(coresys: CoreSys, tmp_path: Path):
"""Test store_supervisor_config handles tar errors."""
coresys.docker.config.registries["ghcr.io"] = {
"username": "user",
"password": "secret",
}
backup = Backup(coresys, tmp_path / "my_backup.tar", "test", None)
backup.new("test", "2023-07-21T21:05:00.000000+00:00", BackupType.FULL)
async with backup.create():
with (
patch.object(
coresys, "run_in_executor", side_effect=tarfile.TarError("test error")
),
pytest.raises(BackupError, match="Can't write supervisor config tarfile"),
):
await backup.store_supervisor_config()
async def test_restore_supervisor_config_tar_read_error(
coresys: CoreSys, tmp_path: Path
):
"""Test restore handles tar read errors gracefully."""
# Create a backup with registries so supervisor.tar exists
coresys.docker.config.registries["ghcr.io"] = {
"username": "user",
"password": "secret",
}
backup = Backup(coresys, tmp_path / "my_backup.tar", "test", None)
backup.new("test", "2023-07-21T21:05:00.000000+00:00", BackupType.FULL)
async with backup.create():
await backup.store_supervisor_config()
async with backup.open(None):
with patch.object(
coresys,
"run_in_executor",
side_effect=tarfile.TarError("corrupted tar"),
):
success, tasks = await backup.restore_supervisor_config()
assert success is False
assert tasks == []