1
0
mirror of https://github.com/home-assistant/supervisor.git synced 2026-05-19 22:28:52 +01:00
Files
supervisor/tests/api/test_services.py
T
Mike Degatano bc24fb5449 Refactor API registration to support v1/v2 via shared methods (#6769)
* Refactor API registration to support v1/v2 via shared methods

- Add AppVersion StrEnum (V1, V2) to supervisor/api/const.py
- Replace self.v2_app with self._v2_app and expose a versions property
  (dict[AppVersion, web.Application]) computed dynamically so that test
  fixtures reassigning self.webapp are automatically reflected in V1
- All _register_* methods now accept a required app: web.Application
  parameter; version-specific routes are gated with
  "if app is self.versions[AppVersion.V1/V2]:"
- load() loops over enabled_versions (V1 always, V2 when feature-flagged)
  and calls each registration method once per version, no duplication
- Static resources are registered before webapp.add_subapp() to avoid
  registering into a frozen router
- add_subapp uses self.webapp directly for readability
- Fold _register_v2_apps/_register_v2_backups/_register_v2_store into
  their respective unified methods; remove the now-defunct _register_v2_*
  helpers and the _api_apps/_api_backups/_api_store instance vars
- _register_proxy and _register_ingress updated to accept app; legacy
  /homeassistant/* proxy routes gated behind V1 conditional

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add dual v1/v2 parametrization to API tests

All 163 tests across 17 API modules that register identically on both
v1 and v2 now run against both versions via api_client_with_prefix.

- tests/api/conftest.py: advanced_logs_tester switched to
  api_client_with_prefix so log-endpoint tests are auto-parametrized;
  accepts optional v2_path_prefix kwarg for paths that differ by version
- tests/api/test_{auth,discovery,dns,docker,hardware,host,ingress,
  jobs,mounts,network,os,resolution,security,services,supervisor}.py:
  api_client -> api_client_with_prefix with path prefix unpacking
- supervisor/api/__init__.py: _register_panel() moved outside the
  version loop -- frontend static assets are V1-only
- tests/api/test_panel.py: kept on plain api_client (V1-only)

Tests intentionally kept V1-only:
- auth/discovery: use indirect api_client parametrize for addon context
- homeassistant: all tests call legacy /homeassistant/* paths (V1-only)
- jobs (4 tests): inner @Job-decorated classes register names into a
  module-level set; re-running the same test raises RuntimeError

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Extend dual v1/v2 parametrization to homeassistant and jobs tests

tests/api/conftest.py:
- Add core_api_client_with_root fixture parametrized over three paths:
    v1-core:   /core/...          (canonical v1 path)
    v1-legacy: /homeassistant/... (legacy v1 alias, same handlers)
    v2-core:   /v2/core/...       (canonical v2 path)

tests/api/test_homeassistant.py:
- Switch all 17 api_client tests to core_api_client_with_root so each
  test runs against all three access paths (v1 canonical, v1 legacy
  alias, v2 canonical), exercising every registered route

tests/api/test_jobs.py:
- Promote four inner TestClass definitions to module-level helpers
  (_JobsTreeTestHelper, _JobManualCleanupTestHelper,
  _JobsSortedTestHelper, _JobWithErrorTestHelper) so that @Job name
  registration into the global _JOB_NAMES set only happens once at
  import time rather than on each parametrized test run
- Replace closure references to outer-scope coresys with self.coresys
- Use api_client_with_prefix for dual-version coverage

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix typo

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-04-27 23:39:47 +02:00

82 lines
2.7 KiB
Python

"""Test services API."""
from aiohttp.test_utils import TestClient
import pytest
from supervisor.addons.addon import App
from supervisor.const import ATTR_SERVICES
from supervisor.coresys import CoreSys
from tests.const import TEST_ADDON_SLUG
@pytest.mark.parametrize(
("method", "url"),
[("get", "/services/bad"), ("post", "/services/bad"), ("delete", "/services/bad")],
)
async def test_service_not_found(
api_client_with_prefix: tuple[TestClient, str], method: str, url: str
):
"""Test service not found error."""
api_client, prefix = api_client_with_prefix
resp = await api_client.request(method, f"{prefix}{url}")
assert resp.status == 404
body = await resp.json()
assert body["message"] == "Service does not exist"
@pytest.mark.parametrize("service", ["mqtt", "mysql"])
@pytest.mark.parametrize("api_client", [TEST_ADDON_SLUG], indirect=True)
async def test_set_service_already_provided(
api_client: TestClient,
coresys: CoreSys,
install_app_ssh: App,
service: str,
):
"""Test setting service data when another app already provides it returns 409."""
install_app_ssh.data[ATTR_SERVICES] = [f"{service}:provide"]
await coresys.services.load()
coresys.services.data._data[service].update( # pylint: disable=protected-access
{"host": "existing", "port": 1883, "addon": "core_mosquitto"}
)
resp = await api_client.post(
f"/services/{service}",
json={"host": "new.example.com", "port": 1883},
)
assert resp.status == 409
body = await resp.json()
assert body["result"] == "error"
assert body["error_key"] == "service_already_provided_error"
assert body["extra_fields"] == {"service": service, "app": "core_mosquitto"}
assert (
body["message"]
== f"The {service} service is already provided by core_mosquitto"
)
@pytest.mark.parametrize("service", ["mqtt", "mysql"])
@pytest.mark.parametrize("api_client", [TEST_ADDON_SLUG], indirect=True)
async def test_del_service_not_provided(
api_client: TestClient,
coresys: CoreSys,
install_app_ssh: App,
service: str,
):
"""Test deleting service data when no app provides it returns 404."""
install_app_ssh.data[ATTR_SERVICES] = [f"{service}:provide"]
await coresys.services.load()
coresys.services.data._data[service].clear() # pylint: disable=protected-access
resp = await api_client.delete(f"/services/{service}")
assert resp.status == 404
body = await resp.json()
assert body["result"] == "error"
assert body["error_key"] == "service_not_provided_error"
assert body["extra_fields"] == {"service": service}
assert (
body["message"] == f"The {service} service is not currently provided by any app"
)