1
0
mirror of https://github.com/home-assistant/supervisor.git synced 2026-05-20 14:48:54 +01:00
Files
supervisor/tests/resolution/fixup/test_addon_execute_remove.py
T
Mike Degatano ba8c49935b Refactor internal addon references to app/apps (#6717)
* Rename addon→app in docstrings and comments

Updates all docstrings and inline comments across supervisor/ and
tests/ to use the new app/apps terminology. No runtime behaviour
is changed by this commit.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Rename addon→app in code (variables, args, class names, functions)

Renames all internal Python identifiers from addon/addons to app/apps:
- Variable and argument names
- Function and method names
- Class names (Addon→App, AddonManager→AppManager, DockerAddon→DockerApp,
  all exception, check, and fixup classes, etc.)
- String literals used as Python identifiers (pytest fixtures,
  parametrize param names, patch.object attribute strings,
  URL route match_info keys)

External API contracts are preserved: JSON keys, error codes,
discovery protocol fields, TypedDict/attr.s field names.
Import module paths (supervisor/addons/) are also unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix partial backup/restore API to remap addons key to apps

The external API accepts `addons` as the request body key (since
ATTR_APPS = "addons"), but do_backup_partial and do_restore_partial
now take an `apps` parameter after the rename. The **body expansion
in both endpoints would pass `addons=...` causing a TypeError.

Remap the key before expansion in both backup_partial and
restore_partial:

    if ATTR_APPS in body:
        body["apps"] = body.pop(ATTR_APPS)

Also adds test_restore_partial_with_addons_key to verify the restore
path correctly receives apps= when addons is passed in the request
body. This path had no existing test coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix merge error

* Adjust AppLoggerAdapter to use app_name

Co-authored-by: Stefan Agner <stefan@agner.ch>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Stefan Agner <stefan@agner.ch>
2026-04-14 16:47:20 +02:00

68 lines
1.9 KiB
Python

"""Test evaluation base."""
from unittest.mock import patch
from supervisor.addons.addon import App
from supervisor.coresys import CoreSys
from supervisor.resolution.const import ContextType, IssueType, SuggestionType
from supervisor.resolution.data import Issue, Suggestion
from supervisor.resolution.fixups.addon_execute_remove import FixupAppExecuteRemove
async def test_fixup(coresys: CoreSys, install_app_ssh: App):
"""Test fixup."""
app_execute_remove = FixupAppExecuteRemove(coresys)
assert app_execute_remove.auto is False
coresys.resolution.add_suggestion(
Suggestion(
SuggestionType.EXECUTE_REMOVE,
ContextType.ADDON,
reference=install_app_ssh.slug,
)
)
coresys.resolution.add_issue(
Issue(
IssueType.DETACHED_ADDON_REMOVED,
ContextType.ADDON,
reference=install_app_ssh.slug,
)
)
with patch.object(App, "uninstall") as uninstall:
await app_execute_remove()
assert uninstall.called
assert len(coresys.resolution.suggestions) == 0
assert len(coresys.resolution.issues) == 0
async def test_fixup_deprecated_arch_app(coresys: CoreSys, install_app_ssh: App):
"""Test fixup for deprecated arch app issue."""
app_execute_remove = FixupAppExecuteRemove(coresys)
coresys.resolution.add_suggestion(
Suggestion(
SuggestionType.EXECUTE_REMOVE,
ContextType.ADDON,
reference=install_app_ssh.slug,
)
)
coresys.resolution.add_issue(
Issue(
IssueType.DEPRECATED_ARCH_ADDON,
ContextType.ADDON,
reference=install_app_ssh.slug,
)
)
with patch.object(App, "uninstall") as uninstall:
await app_execute_remove()
assert uninstall.called
assert len(coresys.resolution.suggestions) == 0
assert len(coresys.resolution.issues) == 0