mirror of
https://github.com/home-assistant/supervisor.git
synced 2026-07-06 21:35:10 +01:00
Stefan Agner
ed91b18c4b
* tests: enable flake8-pytest-style (PT) ruff rules Enable the `PT` ruff rule set and fix the resulting violations across the test suite: - PT006: pass parametrize argument names as tuples instead of a single comma-separated string. - PT022: switch fixtures that have no teardown from `yield` to `return` so the lack of cleanup is obvious at a glance. - PT011: add `match=` to broad `pytest.raises(ValueError)` blocks so the expected error is anchored to a specific message. - PT012: hoist setup (patches, branching) out of `pytest.raises()` blocks so only the call that is expected to raise remains inside. - PT013: replace `from pytest import X` with `import pytest` and access attributes via the module. - PT015: replace `try/except` + `assert False` patterns with `pytest.raises(...)`. - PT017: replace `assert` on exceptions inside `except` blocks with `pytest.raises(...) as exc_info` and assert on `exc_info.value`. No behavioral changes to the tests; the full suite still passes. * tests: address review feedback on PT ruff rule enablement - Fix fixture return-type annotations after switching `yield` to `return` in tests/conftest.py: drop the `Generator[...]`/`AsyncGenerator[...]` wrapper for `dns_manager_service`, `supervisor_internet`, `websession`, and `mock_update_data` so the annotation matches what the fixture actually returns. - Correct the return-type annotation of `fixture_ip6config_service` from `IP4ConfigService` to `IP6ConfigService`. - Fix recurring "excepiton" typo in tests/utils/test_exception_helper.py. * tests: verify backup cleanup on permission error After `test_new_backup_permission_error` raises `BackupPermissionError`, assert that no tarfile was left behind and `tmp_path` is empty. The previous version only checked that the exception was raised, which missed any regression where a partial tarfile would survive the failed create. * tests: rename DNS_GOOD_V6 to DNS_V6_UNSUPPORTED The constant was named "good" but its tests assert that the URLs are rejected by the DNS validator. The IPv6 URLs are well-formed but currently rejected because IPv6 doesn't work with the Docker network (see `dns_url` in supervisor/validate.py). Rename the constant and the related test to make the intent obvious.
48 lines
1.4 KiB
Python
48 lines
1.4 KiB
Python
"""Test NetworkWireless AP object."""
|
|
|
|
from dbus_fast.aio.message_bus import MessageBus
|
|
import pytest
|
|
|
|
from supervisor.dbus.network.accesspoint import NetworkWirelessAP
|
|
|
|
from tests.common import mock_dbus_services
|
|
from tests.dbus_service_mocks.network_access_point import (
|
|
AccessPoint as AccessPointService,
|
|
)
|
|
|
|
|
|
@pytest.fixture(name="access_point_service", autouse=True)
|
|
async def fixture_access_point_service(
|
|
dbus_session_bus: MessageBus,
|
|
) -> AccessPointService:
|
|
"""Mock Access Point service."""
|
|
return (
|
|
await mock_dbus_services(
|
|
{
|
|
"network_access_point": "/org/freedesktop/NetworkManager/AccessPoint/43099"
|
|
},
|
|
dbus_session_bus,
|
|
)
|
|
)["network_access_point"]
|
|
|
|
|
|
async def test_accesspoint(
|
|
access_point_service: AccessPointService, dbus_session_bus: MessageBus
|
|
):
|
|
"""Test accesspoint."""
|
|
wireless_ap = NetworkWirelessAP("/org/freedesktop/NetworkManager/AccessPoint/43099")
|
|
|
|
assert wireless_ap.mac is None
|
|
assert wireless_ap.mode is None
|
|
|
|
await wireless_ap.connect(dbus_session_bus)
|
|
|
|
assert wireless_ap.mac == "E4:57:40:A9:D7:DE"
|
|
assert wireless_ap.mode == 2
|
|
assert wireless_ap.strength == 47
|
|
|
|
# We don't listen for property changes on access points, too noisy
|
|
access_point_service.emit_properties_changed({"Strength": 74})
|
|
await access_point_service.ping()
|
|
assert wireless_ap.strength == 47
|