mirror of
https://github.com/home-assistant/supervisor.git
synced 2026-07-07 05:45:06 +01:00
Stefan Agner
ed91b18c4b
* tests: enable flake8-pytest-style (PT) ruff rules Enable the `PT` ruff rule set and fix the resulting violations across the test suite: - PT006: pass parametrize argument names as tuples instead of a single comma-separated string. - PT022: switch fixtures that have no teardown from `yield` to `return` so the lack of cleanup is obvious at a glance. - PT011: add `match=` to broad `pytest.raises(ValueError)` blocks so the expected error is anchored to a specific message. - PT012: hoist setup (patches, branching) out of `pytest.raises()` blocks so only the call that is expected to raise remains inside. - PT013: replace `from pytest import X` with `import pytest` and access attributes via the module. - PT015: replace `try/except` + `assert False` patterns with `pytest.raises(...)`. - PT017: replace `assert` on exceptions inside `except` blocks with `pytest.raises(...) as exc_info` and assert on `exc_info.value`. No behavioral changes to the tests; the full suite still passes. * tests: address review feedback on PT ruff rule enablement - Fix fixture return-type annotations after switching `yield` to `return` in tests/conftest.py: drop the `Generator[...]`/`AsyncGenerator[...]` wrapper for `dns_manager_service`, `supervisor_internet`, `websession`, and `mock_update_data` so the annotation matches what the fixture actually returns. - Correct the return-type annotation of `fixture_ip6config_service` from `IP4ConfigService` to `IP6ConfigService`. - Fix recurring "excepiton" typo in tests/utils/test_exception_helper.py. * tests: verify backup cleanup on permission error After `test_new_backup_permission_error` raises `BackupPermissionError`, assert that no tarfile was left behind and `tmp_path` is empty. The previous version only checked that the exception was raised, which missed any regression where a partial tarfile would survive the failed create. * tests: rename DNS_GOOD_V6 to DNS_V6_UNSUPPORTED The constant was named "good" but its tests assert that the URLs are rejected by the DNS validator. The IPv6 URLs are well-formed but currently rejected because IPv6 doesn't work with the Docker network (see `dns_url` in supervisor/validate.py). Rename the constant and the related test to make the intent obvious.
67 lines
2.3 KiB
Python
67 lines
2.3 KiB
Python
"""Test Network Manager Connection Settings Profile Manager."""
|
|
|
|
from dbus_fast.aio.message_bus import MessageBus
|
|
import pytest
|
|
|
|
from supervisor.dbus.network.settings import NetworkManagerSettings
|
|
from supervisor.exceptions import DBusNotConnectedError
|
|
|
|
from tests.common import mock_dbus_services
|
|
from tests.dbus_service_mocks.network_connection_settings import SETTINGS_1_FIXTURE
|
|
from tests.dbus_service_mocks.network_settings import Settings as SettingsService
|
|
|
|
|
|
@pytest.fixture(name="settings_service")
|
|
async def fixture_settings_service(dbus_session_bus: MessageBus) -> SettingsService:
|
|
"""Mock Settings service."""
|
|
return (
|
|
await mock_dbus_services(
|
|
{"network_settings": None, "network_connection_settings": None},
|
|
dbus_session_bus,
|
|
)
|
|
)["network_settings"]
|
|
|
|
|
|
async def test_add_connection(
|
|
settings_service: SettingsService, dbus_session_bus: MessageBus
|
|
):
|
|
"""Test adding settings connection."""
|
|
settings_service.AddConnection.calls.clear()
|
|
settings = NetworkManagerSettings()
|
|
|
|
with pytest.raises(DBusNotConnectedError):
|
|
await settings.add_connection(SETTINGS_1_FIXTURE)
|
|
|
|
await settings.connect(dbus_session_bus)
|
|
|
|
connection_settings = await settings.add_connection(SETTINGS_1_FIXTURE)
|
|
assert connection_settings.connection.uuid == "0c23631e-2118-355c-bbb0-8943229cb0d6"
|
|
assert connection_settings.ipv4.method == "auto"
|
|
|
|
assert settings_service.AddConnection.calls == [(SETTINGS_1_FIXTURE,)]
|
|
|
|
|
|
async def test_reload_connections(
|
|
settings_service: SettingsService, dbus_session_bus: MessageBus
|
|
):
|
|
"""Test reload connections."""
|
|
settings_service.ReloadConnections.calls.clear()
|
|
settings = NetworkManagerSettings()
|
|
|
|
with pytest.raises(DBusNotConnectedError):
|
|
await settings.reload_connections()
|
|
|
|
await settings.connect(dbus_session_bus)
|
|
|
|
assert await settings.reload_connections() is True
|
|
assert settings_service.ReloadConnections.calls == [()]
|
|
|
|
|
|
async def test_dbus_network_settings_connect_error(
|
|
dbus_session_bus: MessageBus, caplog: pytest.LogCaptureFixture
|
|
):
|
|
"""Test connecting to network settings error."""
|
|
settings = NetworkManagerSettings()
|
|
await settings.connect(dbus_session_bus)
|
|
assert "No Network Manager Settings support on the host" in caplog.text
|