mirror of
https://github.com/home-assistant/supervisor.git
synced 2026-07-07 05:45:06 +01:00
Stefan Agner
ed91b18c4b
* tests: enable flake8-pytest-style (PT) ruff rules Enable the `PT` ruff rule set and fix the resulting violations across the test suite: - PT006: pass parametrize argument names as tuples instead of a single comma-separated string. - PT022: switch fixtures that have no teardown from `yield` to `return` so the lack of cleanup is obvious at a glance. - PT011: add `match=` to broad `pytest.raises(ValueError)` blocks so the expected error is anchored to a specific message. - PT012: hoist setup (patches, branching) out of `pytest.raises()` blocks so only the call that is expected to raise remains inside. - PT013: replace `from pytest import X` with `import pytest` and access attributes via the module. - PT015: replace `try/except` + `assert False` patterns with `pytest.raises(...)`. - PT017: replace `assert` on exceptions inside `except` blocks with `pytest.raises(...) as exc_info` and assert on `exc_info.value`. No behavioral changes to the tests; the full suite still passes. * tests: address review feedback on PT ruff rule enablement - Fix fixture return-type annotations after switching `yield` to `return` in tests/conftest.py: drop the `Generator[...]`/`AsyncGenerator[...]` wrapper for `dns_manager_service`, `supervisor_internet`, `websession`, and `mock_update_data` so the annotation matches what the fixture actually returns. - Correct the return-type annotation of `fixture_ip6config_service` from `IP4ConfigService` to `IP6ConfigService`. - Fix recurring "excepiton" typo in tests/utils/test_exception_helper.py. * tests: verify backup cleanup on permission error After `test_new_backup_permission_error` raises `BackupPermissionError`, assert that no tarfile was left behind and `tmp_path` is empty. The previous version only checked that the exception was raised, which missed any regression where a partial tarfile would survive the failed create. * tests: rename DNS_GOOD_V6 to DNS_V6_UNSUPPORTED The constant was named "good" but its tests assert that the URLs are rejected by the DNS validator. The IPv6 URLs are well-formed but currently rejected because IPv6 doesn't work with the Docker network (see `dns_url` in supervisor/validate.py). Rename the constant and the related test to make the intent obvious.
90 lines
3.0 KiB
Python
90 lines
3.0 KiB
Python
"""Test Network Manager Wireless object."""
|
|
|
|
from dbus_fast.aio.message_bus import MessageBus
|
|
import pytest
|
|
|
|
from supervisor.dbus.network import NetworkManager
|
|
from supervisor.dbus.network.wireless import NetworkWireless
|
|
|
|
from tests.const import TEST_INTERFACE_WLAN_NAME
|
|
from tests.dbus_service_mocks.base import DBusServiceMock
|
|
from tests.dbus_service_mocks.network_device_wireless import (
|
|
DeviceWireless as DeviceWirelessService,
|
|
)
|
|
|
|
|
|
@pytest.fixture(name="device_wireless_service", autouse=True)
|
|
async def fixture_device_wireless_service(
|
|
network_manager_services: dict[str, DBusServiceMock | dict[str, DBusServiceMock]],
|
|
) -> DeviceWirelessService:
|
|
"""Mock Device Wireless service."""
|
|
return network_manager_services["network_device_wireless"]
|
|
|
|
|
|
async def test_wireless(
|
|
device_wireless_service: DeviceWirelessService, dbus_session_bus: MessageBus
|
|
):
|
|
"""Test wireless properties."""
|
|
wireless = NetworkWireless("/org/freedesktop/NetworkManager/Devices/3")
|
|
|
|
assert wireless.bitrate is None
|
|
|
|
await wireless.connect(dbus_session_bus)
|
|
|
|
assert wireless.bitrate == 0
|
|
assert wireless.active is None
|
|
|
|
device_wireless_service.emit_properties_changed(
|
|
{"ActiveAccessPoint": "/org/freedesktop/NetworkManager/AccessPoint/43099"}
|
|
)
|
|
await device_wireless_service.ping()
|
|
assert wireless.active is not None
|
|
assert (
|
|
wireless.active.object_path
|
|
== "/org/freedesktop/NetworkManager/AccessPoint/43099"
|
|
)
|
|
|
|
device_wireless_service.emit_properties_changed({}, ["ActiveAccessPoint"])
|
|
await device_wireless_service.ping()
|
|
await device_wireless_service.ping()
|
|
assert wireless.active is None
|
|
|
|
|
|
async def test_request_scan(
|
|
network_manager: NetworkManager, device_wireless_service: DeviceWirelessService
|
|
):
|
|
"""Test request scan."""
|
|
device_wireless_service.RequestScan.calls.clear()
|
|
assert (
|
|
await network_manager.get(TEST_INTERFACE_WLAN_NAME).wireless.request_scan()
|
|
is None
|
|
)
|
|
assert device_wireless_service.RequestScan.calls == [({},)]
|
|
|
|
|
|
async def test_get_all_access_points(network_manager: NetworkManager):
|
|
"""Test get all access points."""
|
|
accesspoints = await network_manager.get(
|
|
TEST_INTERFACE_WLAN_NAME
|
|
).wireless.get_all_accesspoints()
|
|
assert len(accesspoints) == 2
|
|
assert accesspoints[0].mac == "E4:57:40:A9:D7:DE"
|
|
assert accesspoints[0].mode == 2
|
|
assert accesspoints[1].mac == "18:4B:0D:23:A1:9C"
|
|
assert accesspoints[1].mode == 2
|
|
|
|
|
|
async def test_old_active_ap_disconnects(network_manager: NetworkManager):
|
|
"""Test old access point disconnects on active ap change."""
|
|
wireless = network_manager.get(TEST_INTERFACE_WLAN_NAME).wireless
|
|
|
|
await wireless.update(
|
|
{"ActiveAccessPoint": "/org/freedesktop/NetworkManager/AccessPoint/43099"}
|
|
)
|
|
active = wireless.active
|
|
assert active.is_connected is True
|
|
|
|
await wireless.update({"ActiveAccessPoint": "/"})
|
|
assert wireless.active is None
|
|
assert active.is_connected is False
|