mirror of
https://github.com/home-assistant/supervisor.git
synced 2026-07-03 03:45:45 +01:00
Stefan Agner
ed91b18c4b
* tests: enable flake8-pytest-style (PT) ruff rules Enable the `PT` ruff rule set and fix the resulting violations across the test suite: - PT006: pass parametrize argument names as tuples instead of a single comma-separated string. - PT022: switch fixtures that have no teardown from `yield` to `return` so the lack of cleanup is obvious at a glance. - PT011: add `match=` to broad `pytest.raises(ValueError)` blocks so the expected error is anchored to a specific message. - PT012: hoist setup (patches, branching) out of `pytest.raises()` blocks so only the call that is expected to raise remains inside. - PT013: replace `from pytest import X` with `import pytest` and access attributes via the module. - PT015: replace `try/except` + `assert False` patterns with `pytest.raises(...)`. - PT017: replace `assert` on exceptions inside `except` blocks with `pytest.raises(...) as exc_info` and assert on `exc_info.value`. No behavioral changes to the tests; the full suite still passes. * tests: address review feedback on PT ruff rule enablement - Fix fixture return-type annotations after switching `yield` to `return` in tests/conftest.py: drop the `Generator[...]`/`AsyncGenerator[...]` wrapper for `dns_manager_service`, `supervisor_internet`, `websession`, and `mock_update_data` so the annotation matches what the fixture actually returns. - Correct the return-type annotation of `fixture_ip6config_service` from `IP4ConfigService` to `IP6ConfigService`. - Fix recurring "excepiton" typo in tests/utils/test_exception_helper.py. * tests: verify backup cleanup on permission error After `test_new_backup_permission_error` raises `BackupPermissionError`, assert that no tarfile was left behind and `tmp_path` is empty. The previous version only checked that the exception was raised, which missed any regression where a partial tarfile would survive the failed create. * tests: rename DNS_GOOD_V6 to DNS_V6_UNSUPPORTED The constant was named "good" but its tests assert that the URLs are rejected by the DNS validator. The IPv6 URLs are well-formed but currently rejected because IPv6 doesn't work with the Docker network (see `dns_url` in supervisor/validate.py). Rename the constant and the related test to make the intent obvious.
114 lines
3.6 KiB
Python
114 lines
3.6 KiB
Python
"""Test systemd-resolved dbus interface."""
|
|
# pylint: disable=import-error
|
|
|
|
from socket import AF_INET6, inet_aton, inet_pton
|
|
|
|
from dbus_fast.aio.message_bus import MessageBus
|
|
import pytest
|
|
|
|
from supervisor.dbus.const import (
|
|
DNSOverTLSEnabled,
|
|
DNSSECValidation,
|
|
DNSStubListenerEnabled,
|
|
MulticastProtocolEnabled,
|
|
ResolvConfMode,
|
|
)
|
|
from supervisor.dbus.resolved import Resolved
|
|
|
|
from tests.common import mock_dbus_services
|
|
from tests.dbus_service_mocks.resolved import Resolved as ResolvedService
|
|
|
|
|
|
@pytest.fixture(name="resolved_service")
|
|
async def fixture_resolved_service(dbus_session_bus: MessageBus) -> ResolvedService:
|
|
"""Mock resolved dbus service."""
|
|
return (await mock_dbus_services({"resolved": None}, dbus_session_bus))["resolved"]
|
|
|
|
|
|
async def test_dbus_resolved_info(
|
|
resolved_service: ResolvedService, dbus_session_bus: MessageBus
|
|
):
|
|
"""Test systemd-resolved dbus connection."""
|
|
resolved = Resolved()
|
|
|
|
assert resolved.dns is None
|
|
|
|
await resolved.connect(dbus_session_bus)
|
|
|
|
assert resolved.llmnr_hostname == "homeassistant"
|
|
assert resolved.llmnr == MulticastProtocolEnabled.YES
|
|
assert resolved.multicast_dns == MulticastProtocolEnabled.RESOLVE
|
|
assert resolved.dns_over_tls == DNSOverTLSEnabled.NO
|
|
|
|
assert len(resolved.dns) == 2
|
|
assert resolved.dns[0] == (0, 2, inet_aton("127.0.0.1"))
|
|
assert resolved.dns[1] == (0, 10, inet_pton(AF_INET6, "::1"))
|
|
assert len(resolved.dns_ex) == 2
|
|
assert resolved.dns_ex[0] == (0, 2, inet_aton("127.0.0.1"), 0, "")
|
|
assert resolved.dns_ex[1] == (0, 10, inet_pton(AF_INET6, "::1"), 0, "")
|
|
|
|
assert len(resolved.fallback_dns) == 2
|
|
assert resolved.fallback_dns[0] == (0, 2, inet_aton("1.1.1.1"))
|
|
assert resolved.fallback_dns[1] == (
|
|
0,
|
|
10,
|
|
inet_pton(AF_INET6, "2606:4700:4700::1111"),
|
|
)
|
|
assert len(resolved.fallback_dns_ex) == 2
|
|
assert resolved.fallback_dns_ex[0] == (
|
|
0,
|
|
2,
|
|
inet_aton("1.1.1.1"),
|
|
0,
|
|
"cloudflare-dns.com",
|
|
)
|
|
assert resolved.fallback_dns_ex[1] == (
|
|
0,
|
|
10,
|
|
inet_pton(AF_INET6, "2606:4700:4700::1111"),
|
|
0,
|
|
"cloudflare-dns.com",
|
|
)
|
|
|
|
assert resolved.current_dns_server == (0, 2, inet_aton("127.0.0.1"))
|
|
assert resolved.current_dns_server_ex == (
|
|
0,
|
|
2,
|
|
inet_aton("127.0.0.1"),
|
|
0,
|
|
"",
|
|
)
|
|
|
|
assert len(resolved.domains) == 1
|
|
assert resolved.domains[0] == (0, "local.hass.io", False)
|
|
|
|
assert resolved.transaction_statistics == (0, 100000)
|
|
assert resolved.cache_statistics == (10, 50000, 10000)
|
|
assert resolved.dnssec == DNSSECValidation.NO
|
|
assert resolved.dnssec_statistics == (0, 0, 0, 0)
|
|
assert resolved.dnssec_supported is False
|
|
assert resolved.dnssec_negative_trust_anchors == [
|
|
"168.192.in-addr.arpa",
|
|
"local",
|
|
]
|
|
assert resolved.dns_stub_listener == DNSStubListenerEnabled.NO
|
|
assert resolved.resolv_conf_mode == ResolvConfMode.FOREIGN
|
|
|
|
resolved_service.emit_properties_changed({"LLMNRHostname": "test"})
|
|
await resolved_service.ping()
|
|
assert resolved.llmnr_hostname == "test"
|
|
|
|
resolved_service.emit_properties_changed({}, ["LLMNRHostname"])
|
|
await resolved_service.ping()
|
|
await resolved_service.ping() # To process the follow-up get all properties call
|
|
assert resolved.llmnr_hostname == "homeassistant"
|
|
|
|
|
|
async def test_dbus_resolved_connect_error(
|
|
dbus_session_bus: MessageBus, caplog: pytest.LogCaptureFixture
|
|
):
|
|
"""Test connecting to resolved error."""
|
|
resolved = Resolved()
|
|
await resolved.connect(dbus_session_bus)
|
|
assert "Host has no systemd-resolved support" in caplog.text
|