Home-Assistant/supervisor
1
0
Fork 0
mirror of https://github.com/home-assistant/supervisor.git synced 2026-09-29 21:13:50 +01:00
Code Activity
Files
d0d259cf73e9191185b00a2a14c8f8f04b42f9c2
supervisor/tests/api/test_homeassistant.py
T
Mike Degatano 0e7c4175c5 Block start/restart/rebuild/update APIs while Supervisor is not fully running (#7194) 
* Block start/restart/rebuild/update APIs while Supervisor is not fully running

Supervisor boots apps and Home Assistant Core in a specific order, and
replays a similarly ordered sequence while restoring a backup (during
which it is in the freeze state). Calling start/restart/rebuild/update
via the API while one of those sequences is still in progress risks
running it out of order, or blocking a scheduled start from that
sequence outright via job concurrency.

Add a require_running_system decorator that rejects these API calls
unless Supervisor is fully started (CoreState.RUNNING), and apply it to:
- App start/restart/rebuild (fixes #7189) and update
- Home Assistant Core start/restart/rebuild/update
- Plugin (audio/dns/multicast) restart/update, and cli/observer update

Also add a translatable APISystemNotReadyError so the API returns a
clean, user-facing message and error_key instead of leaking the
technical JobConditionException message.

* Address review: neutral error wording + require_running_system test coverage

- Reword APISystemNotReadyError so it no longer implies the block is only
  due to startup, since the same guard also applies while frozen for a
  backup restore.
- Add tests/api/test_require_running_system.py covering the rejection path
  (400 + system_not_ready_error, business logic not invoked) for app
  start/restart/rebuild, app update via the store API, Core
  start/restart/rebuild/update, and all plugin update/restart routes,
  parametrized across SETUP/STARTUP/FREEZE.

* Simplify APISystemNotReadyError message wording

* Switch status code to 503
2026-09-15 14:45:26 +02:00

844 lines
30 KiB
Python
Raw Blame History

"""Test homeassistant api."""
import asyncio
from pathlib import Path
from unittest.mock import AsyncMock, Mock, PropertyMock, patch
from aiodocker.containers import DockerContainer
from aiohttp.test_utils import TestClient
from awesomeversion import AwesomeVersion
import pytest
from supervisor.backups.manager import BackupManager
from supervisor.const import DNS_SUFFIX, CoreState
from supervisor.coresys import CoreSys
from supervisor.docker.homeassistant import DockerHomeAssistant
from supervisor.docker.interface import DockerInterface
from supervisor.docker.manager import DockerAPI
from supervisor.exceptions import DockerError, HomeAssistantError
from supervisor.homeassistant.api import APIState, HomeAssistantAPI
from supervisor.homeassistant.const import WSEvent
import supervisor.homeassistant.core as ha_core
from supervisor.homeassistant.core import HomeAssistantCore
from supervisor.homeassistant.module import HomeAssistant
from supervisor.resolution.const import ContextType, IssueType
from supervisor.resolution.data import Issue
from supervisor.updater import Updater
from tests.common import AsyncIterator, load_json_fixture
@pytest.fixture(autouse=True)
async def running_state(coresys: CoreSys) -> None:
"""Set the default state to a fully started system.
Starting/restarting/rebuilding Home Assistant Core via the API is only
allowed once Supervisor has fully started (see require_running_system).
Tests exercising other states set them explicitly.
"""
await coresys.core.set_state(CoreState.RUNNING)
@pytest.mark.parametrize("legacy_route", [True, False])
async def test_api_core_logs(
advanced_logs_tester: AsyncMock,
legacy_route: bool,
):
"""Test core logs."""
await advanced_logs_tester(
f"/{'homeassistant' if legacy_route else 'core'}",
"homeassistant",
v2_path_prefix="/core",
)
async def test_api_stats(
core_api_client_with_root: tuple[TestClient, str], container: DockerContainer
):
"""Test stats."""
api_client, root = core_api_client_with_root
container.show.return_value["State"]["Status"] = "running"
container.show.return_value["State"]["Running"] = True
if root.startswith("/v2"):
# V2 always requests one-shot stats
stats_fixture = load_json_fixture("container_stats.json")
del stats_fixture["precpu_stats"]
with patch.object(
DockerAPI,
"_query_one_shot_stats",
AsyncMock(return_value=stats_fixture),
):
resp = await api_client.get(f"{root}/stats")
else:
container.stats = AsyncMock(
return_value=[load_json_fixture("container_stats.json")]
)
resp = await api_client.get(f"{root}/stats")
assert resp.status == 200
result = await resp.json()
if root.startswith("/v2"):
assert "cpu_percent" not in result["data"]
else:
assert result["data"]["cpu_percent"] == 90.0
assert result["data"]["cpu_usage"] == 190
assert result["data"]["cpu_system_usage"] == 200
assert result["data"]["online_cpus"] == 24
assert result["data"]["memory_usage"] == 59700000
assert result["data"]["memory_limit"] == 4000000000
assert result["data"]["memory_percent"] == 1.49
async def test_api_stats_one_shot(
core_api_client_with_root: tuple[TestClient, str],
container: DockerContainer,
):
"""Test stats one-shot mode skips the calculated window.
V1 opts in via the ``one_shot`` query string; v2 always requests
one-shot stats and has no query string option (see test_api_stats).
"""
api_client, root = core_api_client_with_root
if root.startswith("/v2"):
pytest.skip("v2 always uses one-shot; covered by test_api_stats")
container.show.return_value["State"]["Status"] = "running"
container.show.return_value["State"]["Running"] = True
stats_fixture = load_json_fixture("container_stats.json")
del stats_fixture["precpu_stats"]
with patch.object(
DockerAPI, "_query_one_shot_stats", AsyncMock(return_value=stats_fixture)
):
resp = await api_client.get(f"{root}/stats?one_shot")
assert resp.status == 200
result = await resp.json()
assert result["data"]["cpu_percent"] is None
assert result["data"]["cpu_usage"] == 190
assert result["data"]["cpu_system_usage"] == 200
assert result["data"]["online_cpus"] == 24
container.stats.assert_not_called()
async def test_api_set_options(core_api_client_with_root: tuple[TestClient, str]):
"""Test setting options for homeassistant."""
api_client, root = core_api_client_with_root
resp = await api_client.get(f"{root}/info")
assert resp.status == 200
result = await resp.json()
assert result["data"]["watchdog"] is True
assert result["data"]["backups_exclude_database"] is False
with patch.object(HomeAssistant, "save_data") as save_data:
resp = await api_client.post(
f"{root}/options",
json={"backups_exclude_database": True, "watchdog": False},
)
assert resp.status == 200
save_data.assert_called_once()
resp = await api_client.get(f"{root}/info")
assert resp.status == 200
result = await resp.json()
assert result["data"]["watchdog"] is False
assert result["data"]["backups_exclude_database"] is True
async def test_api_set_image(
core_api_client_with_root: tuple[TestClient, str], coresys: CoreSys
):
"""Test changing the image for homeassistant."""
api_client, root = core_api_client_with_root
assert (
coresys.homeassistant.image == "ghcr.io/home-assistant/qemux86-64-homeassistant"
)
assert coresys.homeassistant.override_image is False
with patch.object(HomeAssistant, "save_data"):
resp = await api_client.post(
f"{root}/options",
json={"image": "test_image"},
)
assert resp.status == 200
assert coresys.homeassistant.image == "test_image"
assert coresys.homeassistant.override_image is True
with patch.object(HomeAssistant, "save_data"):
resp = await api_client.post(
f"{root}/options",
json={"image": "ghcr.io/home-assistant/qemux86-64-homeassistant"},
)
assert resp.status == 200
assert (
coresys.homeassistant.image == "ghcr.io/home-assistant/qemux86-64-homeassistant"
)
assert coresys.homeassistant.override_image is False
async def test_api_restart(
core_api_client_with_root: tuple[TestClient, str],
container: DockerContainer,
tmp_supervisor_data: Path,
):
"""Test restarting homeassistant."""
api_client, root = core_api_client_with_root
safe_mode_marker = tmp_supervisor_data / "homeassistant" / "safe-mode"
with patch.object(HomeAssistantCore, "_block_till_run"):
await api_client.post(f"{root}/restart")
container.restart.assert_called_once()
assert not safe_mode_marker.exists()
with patch.object(HomeAssistantCore, "_block_till_run"):
await api_client.post(f"{root}/restart", json={"safe_mode": True})
assert container.restart.call_count == 2
assert safe_mode_marker.exists()
@pytest.mark.usefixtures("path_extern")
async def test_api_rebuild(
core_api_client_with_root: tuple[TestClient, str],
coresys: CoreSys,
container: DockerContainer,
tmp_supervisor_data: Path,
):
"""Test rebuilding homeassistant."""
api_client, root = core_api_client_with_root
coresys.homeassistant.version = AwesomeVersion("2023.09.0")
safe_mode_marker = tmp_supervisor_data / "homeassistant" / "safe-mode"
with patch.object(HomeAssistantCore, "_block_till_run"):
await api_client.post(f"{root}/rebuild")
assert container.delete.call_count == 2
container.start.assert_called_once()
assert not safe_mode_marker.exists()
with patch.object(HomeAssistantCore, "_block_till_run"):
await api_client.post(f"{root}/rebuild", json={"safe_mode": True})
assert container.delete.call_count == 4
assert container.start.call_count == 2
assert safe_mode_marker.exists()
@pytest.mark.parametrize("action", ["rebuild", "restart", "stop", "update"])
async def test_migration_blocks_stopping_core(
core_api_client_with_root: tuple[TestClient, str], coresys: CoreSys, action: str
):
"""Test that an offline db migration in progress stops users from stopping/restarting core."""
api_client, root = core_api_client_with_root
coresys.homeassistant.api.get_api_state.return_value = APIState("NOT_RUNNING", True)
resp = await api_client.post(f"{root}/{action}")
assert resp.status == 503
result = await resp.json()
assert (
result["message"]
== "Offline database migration in progress, try again after it has completed"
)
async def test_force_rebuild_during_migration(
core_api_client_with_root: tuple[TestClient, str], coresys: CoreSys
):
"""Test force option rebuilds even during a migration."""
api_client, root = core_api_client_with_root
coresys.homeassistant.api.get_api_state.return_value = APIState("NOT_RUNNING", True)
with patch.object(HomeAssistantCore, "rebuild") as rebuild:
await api_client.post(f"{root}/rebuild", json={"force": True})
rebuild.assert_called_once()
async def test_force_restart_during_migration(
core_api_client_with_root: tuple[TestClient, str], coresys: CoreSys
):
"""Test force option restarts even during a migration."""
api_client, root = core_api_client_with_root
coresys.homeassistant.api.get_api_state.return_value = APIState("NOT_RUNNING", True)
with patch.object(HomeAssistantCore, "restart") as restart:
await api_client.post(f"{root}/restart", json={"force": True})
restart.assert_called_once()
async def test_force_stop_during_migration(
core_api_client_with_root: tuple[TestClient, str], coresys: CoreSys
):
"""Test force option stops even during a migration."""
api_client, root = core_api_client_with_root
coresys.homeassistant.api.get_api_state.return_value = APIState("NOT_RUNNING", True)
with patch.object(HomeAssistantCore, "stop") as stop:
await api_client.post(f"{root}/stop", json={"force": True})
stop.assert_called_once()
@pytest.mark.parametrize(
("make_backup", "backup_called", "update_called"),
[(True, True, False), (False, False, True)],
)
async def test_home_assistant_background_update(
core_api_client_with_root: tuple[TestClient, str],
coresys: CoreSys,
make_backup: bool,
backup_called: bool,
update_called: bool,
):
"""Test background update of Home Assistant."""
api_client, root = core_api_client_with_root
coresys.hardware.disk.get_disk_free_space = lambda x: 5000
event = asyncio.Event()
mock_update_called = mock_backup_called = False
# Mock backup/update as long-running tasks
async def mock_docker_interface_update(*args, **kwargs):
nonlocal mock_update_called
mock_update_called = True
await event.wait()
async def mock_partial_backup(*args, **kwargs):
nonlocal mock_backup_called
mock_backup_called = True
await event.wait()
with (
patch.object(DockerInterface, "update", new=mock_docker_interface_update),
patch.object(BackupManager, "do_backup_partial", new=mock_partial_backup),
patch.object(
DockerInterface,
"version",
new=PropertyMock(return_value=AwesomeVersion("2025.8.0")),
),
):
resp = await api_client.post(
f"{root}/update",
json={"background": True, "backup": make_backup, "version": "2025.8.3"},
)
assert mock_backup_called is backup_called
assert mock_update_called is update_called
assert resp.status == 200
body = await resp.json()
assert (job := coresys.jobs.get_job(body["data"]["job_id"]))
assert job.name == "home_assistant_core_update"
event.set()
async def test_background_home_assistant_update_fails_fast(
core_api_client_with_root: tuple[TestClient, str], coresys: CoreSys
):
"""Test background Home Assistant update returns error not job if validation doesn't succeed."""
api_client, root = core_api_client_with_root
coresys.hardware.disk.get_disk_free_space = lambda x: 5000
with (
patch.object(
DockerInterface,
"version",
new=PropertyMock(return_value=AwesomeVersion("2025.8.3")),
),
):
resp = await api_client.post(
f"{root}/update",
json={"background": True, "version": "2025.8.3"},
)
assert resp.status == 400
body = await resp.json()
assert body["message"] == "Home Assistant version 2025.8.3 is already installed"
assert body["error_key"] == "homeassistant_update_already_installed_error"
@pytest.mark.usefixtures("tmp_supervisor_data")
async def test_api_progress_updates_home_assistant_update(
core_api_client_with_root: tuple[TestClient, str],
coresys: CoreSys,
ha_ws_client: AsyncMock,
):
"""Test progress updates sent to Home Assistant for updates."""
api_client, root = core_api_client_with_root
coresys.hardware.disk.get_disk_free_space = lambda x: 5000
coresys.core.set_state(CoreState.RUNNING)
logs = load_json_fixture("docker_pull_image_log.json")
coresys.docker.images.pull.return_value = AsyncIterator(logs)
coresys.homeassistant.version = AwesomeVersion("2025.8.0")
with (
patch.object(
DockerHomeAssistant,
"version",
new=PropertyMock(return_value=AwesomeVersion("2025.8.0")),
),
patch.object(
HomeAssistantAPI,
"get_config",
return_value={"components": ["http", "frontend", "websocket_api"]},
),
patch.object(ha_core, "verify_frontend", AsyncMock(return_value=True)),
):
resp = await api_client.post(f"{root}/update", json={"version": "2025.8.3"})
assert resp.status == 200
events = [
{
"stage": evt.args[0]["data"]["data"]["stage"],
"progress": evt.args[0]["data"]["data"]["progress"],
"done": evt.args[0]["data"]["data"]["done"],
}
for evt in ha_ws_client.async_send_command.call_args_list
if "data" in evt.args[0]
and evt.args[0]["data"]["event"] == WSEvent.JOB
and evt.args[0]["data"]["data"]["name"] == "home_assistant_core_update"
]
# Count-based progress: 2 layers need pulling (each worth 50%)
# Layers that already exist are excluded from progress calculation
assert events[:5] == [
{
"stage": None,
"progress": 0,
"done": None,
},
{
"stage": None,
"progress": 0,
"done": False,
},
{
"stage": None,
"progress": 9.2,
"done": False,
},
{
"stage": None,
"progress": 25.6,
"done": False,
},
{
"stage": None,
"progress": 35.4,
"done": False,
},
]
assert events[-5:] == [
{
"stage": None,
"progress": 95.5,
"done": False,
},
{
"stage": None,
"progress": 96.9,
"done": False,
},
{
"stage": None,
"progress": 98.2,
"done": False,
},
{
"stage": None,
"progress": 100,
"done": False,
},
{
"stage": None,
"progress": 100,
"done": True,
},
]
@pytest.mark.usefixtures("path_extern")
async def test_config_check(
core_api_client_with_root: tuple[TestClient, str],
coresys: CoreSys,
container: DockerContainer,
):
"""Test config check API."""
api_client, root = core_api_client_with_root
coresys.homeassistant.version = AwesomeVersion("2025.1.0")
result = await api_client.post(f"{root}/check")
assert result.status == 200
coresys.docker.containers.create.assert_called_once_with(
{
"Image": "ghcr.io/home-assistant/qemux86-64-homeassistant:2025.1.0",
"Labels": {"supervisor_managed": ""},
"OpenStdin": False,
"StdinOnce": False,
"AttachStdin": False,
"AttachStdout": False,
"AttachStderr": False,
"HostConfig": {
"NetworkMode": "hassio",
"Init": True,
"Privileged": True,
"Mounts": [
{
"Type": "bind",
"Source": "/mnt/data/supervisor/homeassistant",
"Target": "/config",
"ReadOnly": False,
},
{
"Type": "bind",
"Source": "/mnt/data/supervisor/ssl",
"Target": "/ssl",
"ReadOnly": True,
},
{
"Type": "bind",
"Source": "/mnt/data/supervisor/share",
"Target": "/share",
"ReadOnly": False,
"BindOptions": {"Propagation": "rslave"},
},
],
"Dns": [str(coresys.docker.network.dns)],
"DnsSearch": [DNS_SUFFIX],
"DnsOptions": ["timeout:10"],
},
"Env": ["TZ=Etc/UTC"],
"Entrypoint": [],
"Cmd": [
"python3",
"-m",
"homeassistant",
"-c",
"/config",
"--script",
"check_config",
],
},
name=None,
)
container.start.assert_called_once()
@pytest.mark.usefixtures("path_extern")
async def test_config_check_error(
core_api_client_with_root: tuple[TestClient, str], container: DockerContainer
):
"""Test config check API strips color coding from log output on error."""
api_client, root = core_api_client_with_root
container.log.return_value = [
"\x1b[36mTest logs 1\x1b[0m\n",
"\x1b[36mTest logs 2\x1b[0m\n",
]
container.wait.return_value = {"StatusCode": 1}
result = await api_client.post(f"{root}/check")
assert result.status == 400
resp = await result.json()
assert resp["message"] == "Test logs 1\nTest logs 2\n"
async def test_update_frontend_check_success(
core_api_client_with_root: tuple[TestClient, str], coresys: CoreSys
):
"""Test that update succeeds when frontend check passes."""
api_client, root = core_api_client_with_root
coresys.hardware.disk.get_disk_free_space = lambda x: 5000
coresys.homeassistant.version = AwesomeVersion("2025.8.0")
with (
patch.object(DockerInterface, "is_running", AsyncMock(return_value=True)),
patch.object(
DockerHomeAssistant,
"version",
new=PropertyMock(return_value=AwesomeVersion("2025.8.0")),
),
patch.object(
HomeAssistantAPI,
"get_config",
return_value={"components": ["http", "frontend", "websocket_api"]},
),
patch.object(ha_core, "verify_frontend", AsyncMock(return_value=True)),
patch.object(DockerInterface, "cleanup") as mock_cleanup,
):
resp = await api_client.post(f"{root}/update", json={"version": "2025.8.3"})
assert resp.status == 200
mock_cleanup.assert_called_once()
async def test_update_frontend_check_fails_triggers_rollback(
core_api_client_with_root: tuple[TestClient, str],
coresys: CoreSys,
caplog: pytest.LogCaptureFixture,
tmp_supervisor_data: Path,
):
"""Test that update triggers rollback when health probes fail."""
api_client, root = core_api_client_with_root
coresys.hardware.disk.get_disk_free_space = lambda x: 5000
coresys.homeassistant.version = AwesomeVersion("2025.8.0")
# Mock successful first update, failed frontend check, then successful rollback
update_call_count = 0
async def mock_update(*args, **kwargs):
nonlocal update_call_count
update_call_count += 1
if update_call_count == 1:
# First update succeeds
coresys.homeassistant.version = AwesomeVersion("2025.8.3")
elif update_call_count == 2:
# Rollback succeeds
coresys.homeassistant.version = AwesomeVersion("2025.8.0")
with (
patch.object(DockerInterface, "update", new=mock_update),
patch.object(DockerInterface, "is_running", AsyncMock(return_value=True)),
patch.object(
DockerHomeAssistant,
"version",
new=PropertyMock(return_value=AwesomeVersion("2025.8.0")),
),
patch.object(
HomeAssistantAPI,
"get_config",
return_value={"components": ["http", "frontend", "websocket_api"]},
),
patch.object(ha_core, "verify_frontend", AsyncMock(return_value=False)),
patch.object(DockerInterface, "cleanup") as mock_cleanup,
):
resp = await api_client.post(f"{root}/update", json={"version": "2025.8.3"})
# Update should trigger rollback, which succeeds and returns 200
assert resp.status == 200
assert "HomeAssistant update failed -> rollback!" in caplog.text
# Should have called update twice (once for update, once for rollback)
assert update_call_count == 2
# An update_rollback issue should be created
assert (
Issue(IssueType.UPDATE_ROLLBACK, ContextType.CORE) in coresys.resolution.issues
)
# Old image should not be cleaned up so rollback doesn't need to re-download
mock_cleanup.assert_not_called()
async def test_update_websocket_api_missing_triggers_rollback(
core_api_client_with_root: tuple[TestClient, str],
coresys: CoreSys,
caplog: pytest.LogCaptureFixture,
tmp_supervisor_data: Path,
):
"""Test that update triggers rollback when websocket_api component is not loaded."""
api_client, root = core_api_client_with_root
coresys.hardware.disk.get_disk_free_space = lambda x: 5000
coresys.homeassistant.version = AwesomeVersion("2025.8.0")
update_call_count = 0
async def mock_update(*args, **kwargs):
nonlocal update_call_count
update_call_count += 1
if update_call_count == 1:
coresys.homeassistant.version = AwesomeVersion("2025.8.3")
elif update_call_count == 2:
coresys.homeassistant.version = AwesomeVersion("2025.8.0")
with (
patch.object(DockerInterface, "update", new=mock_update),
patch.object(DockerInterface, "is_running", AsyncMock(return_value=True)),
patch.object(
DockerHomeAssistant,
"version",
new=PropertyMock(return_value=AwesomeVersion("2025.8.0")),
),
patch.object(
HomeAssistantAPI,
"get_config",
return_value={"components": ["http", "frontend"]},
),
patch.object(
ha_core, "verify_frontend", AsyncMock(return_value=True)
) as mock_frontend_check,
patch.object(DockerInterface, "cleanup") as mock_cleanup,
):
resp = await api_client.post(f"{root}/update", json={"version": "2025.8.3"})
assert resp.status == 200
assert "API responds but websocket_api is not loaded" in caplog.text
assert "HomeAssistant update failed -> rollback!" in caplog.text
assert update_call_count == 2
mock_frontend_check.assert_not_called()
assert (
Issue(IssueType.UPDATE_ROLLBACK, ContextType.CORE) in coresys.resolution.issues
)
mock_cleanup.assert_not_called()
async def test_update_get_config_error_triggers_rollback(
core_api_client_with_root: tuple[TestClient, str],
coresys: CoreSys,
caplog: pytest.LogCaptureFixture,
tmp_supervisor_data: Path,
):
"""Test that update triggers rollback when get_config raises HomeAssistantError."""
api_client, root = core_api_client_with_root
coresys.hardware.disk.get_disk_free_space = lambda x: 5000
coresys.homeassistant.version = AwesomeVersion("2025.8.0")
update_call_count = 0
async def mock_update(*args, **kwargs):
nonlocal update_call_count
update_call_count += 1
if update_call_count == 1:
coresys.homeassistant.version = AwesomeVersion("2025.8.3")
elif update_call_count == 2:
coresys.homeassistant.version = AwesomeVersion("2025.8.0")
with (
patch.object(DockerInterface, "update", new=mock_update),
patch.object(DockerInterface, "is_running", AsyncMock(return_value=True)),
patch.object(
DockerHomeAssistant,
"version",
new=PropertyMock(return_value=AwesomeVersion("2025.8.0")),
),
patch.object(HomeAssistantAPI, "get_config", side_effect=HomeAssistantError),
patch.object(
ha_core, "verify_frontend", AsyncMock(return_value=True)
) as mock_frontend_check,
patch.object(DockerInterface, "cleanup") as mock_cleanup,
):
resp = await api_client.post(f"{root}/update", json={"version": "2025.8.3"})
assert resp.status == 200
assert "HomeAssistant update failed -> rollback!" in caplog.text
assert update_call_count == 2
mock_frontend_check.assert_not_called()
assert (
Issue(IssueType.UPDATE_ROLLBACK, ContextType.CORE) in coresys.resolution.issues
)
mock_cleanup.assert_not_called()
async def test_update_image_install_failure_surfaces_error(
core_api_client_with_root: tuple[TestClient, str],
coresys: CoreSys,
capture_exception: Mock,
caplog: pytest.LogCaptureFixture,
tmp_supervisor_data: Path,
):
"""Test that a failed image install surfaces a clean translated error.
When the target version does not exist the image pull fails before the
running Core is touched. The post-update health check would otherwise pass
against the still-healthy old version and mask the failure. The error is
modeled as a client-facing APIError so it does not reach Sentry.
"""
api_client, root = core_api_client_with_root
coresys.hardware.disk.get_disk_free_space = lambda x: 5000
coresys.homeassistant.version = AwesomeVersion("2025.8.0")
with (
patch.object(
DockerInterface, "update", side_effect=DockerError("404 not found")
),
patch.object(DockerInterface, "is_running", AsyncMock(return_value=True)),
patch.object(
DockerHomeAssistant,
"version",
new=PropertyMock(return_value=AwesomeVersion("2025.8.0")),
),
patch.object(HomeAssistantAPI, "get_config") as mock_get_config,
patch.object(ha_core, "verify_frontend", AsyncMock(return_value=True)),
patch.object(DockerInterface, "cleanup") as mock_cleanup,
):
resp = await api_client.post(f"{root}/update", json={"version": "2025.8.3"})
# The update reports a clean client error with a translatable key.
assert resp.status == 400
body = await resp.json()
assert body["result"] == "error"
assert body["error_key"] == "homeassistant_update_image_error"
assert "2025.8.3" in body["message"]
# A client error must not be captured as an unexpected error in Sentry.
capture_exception.assert_not_called()
assert "Unexpected error during API call" not in caplog.text
# No health check or rollback should run since the old Core is untouched.
mock_get_config.assert_not_called()
assert "HomeAssistant update failed -> rollback!" not in caplog.text
mock_cleanup.assert_not_called()
# Version is unchanged and no rollback issue is created.
assert coresys.homeassistant.version == AwesomeVersion("2025.8.0")
assert (
Issue(IssueType.UPDATE_ROLLBACK, ContextType.CORE)
not in coresys.resolution.issues
)
async def test_update_skips_health_check_when_core_not_running(
coresys: CoreSys,
caplog: pytest.LogCaptureFixture,
tmp_supervisor_data: Path,
):
"""Test that update skips health check and rollback when Core was stopped on entry.
Reproduces the backup-restore regression: the restore flow stops and
removes Core before calling core.update(); the post-update API check
must not fire because Core hasn't been started yet, otherwise it
triggers a spurious rollback that overwrites the restored image.
"""
coresys.hardware.disk.get_disk_free_space = lambda x: 5000
coresys.homeassistant.version = AwesomeVersion("2026.5.0b0")
coresys.homeassistant.set_image("ghcr.io/home-assistant/qemux86-64-homeassistant")
update_call_count = 0
async def mock_update(*args, **kwargs):
nonlocal update_call_count
update_call_count += 1
coresys.homeassistant.version = AwesomeVersion("2026.4.4")
with (
patch.object(DockerInterface, "update", new=mock_update),
patch.object(DockerInterface, "is_running", AsyncMock(return_value=False)),
patch.object(DockerInterface, "exists", AsyncMock(return_value=False)),
patch.object(
Updater,
"image_homeassistant",
new=PropertyMock(
return_value="ghcr.io/home-assistant/qemux86-64-homeassistant"
),
),
patch.object(
DockerHomeAssistant,
"version",
new=PropertyMock(return_value=AwesomeVersion("2026.4.4")),
),
patch.object(HomeAssistantAPI, "get_config") as mock_get_config,
patch.object(ha_core, "verify_frontend", AsyncMock()) as mock_frontend,
patch.object(DockerInterface, "cleanup") as mock_cleanup,
):
await coresys.homeassistant.core.update(AwesomeVersion("2026.4.4"))
# Only one update call: no rollback fired.
assert update_call_count == 1
assert "HomeAssistant update failed -> rollback!" not in caplog.text
# Health check must not run when Core wasn't running on entry.
mock_get_config.assert_not_called()
mock_frontend.assert_not_called()
# Caller (restore flow) is responsible for cleanup later.
mock_cleanup.assert_not_called()
assert (
Issue(IssueType.UPDATE_ROLLBACK, ContextType.CORE)
not in coresys.resolution.issues
)
assert coresys.homeassistant.version == AwesomeVersion("2026.4.4")
View Git Blame Copy Permalink