mirror of
https://github.com/home-assistant/supervisor.git
synced 2026-02-15 07:27:13 +00:00
* Raise HomeAssistantWSError when Core WebSocket is unreachable Previously, async_send_command silently returned None when Home Assistant Core was not reachable, leading to misleading error messages downstream (e.g. "returned invalid response of None instead of a list of users"). Refactor _can_send to _ensure_connected which now raises HomeAssistantWSError on connection failures while still returning False for silent-skip cases (shutdown, unsupported version). async_send_message catches the exception to preserve fire-and-forget behavior. Update callers that don't handle HomeAssistantWSError: _hardware_events and addon auto-update in tasks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Simplify HomeAssistantWebSocket command/message distinction The WebSocket layer had a confusing split between "messages" (fire-and-forget) and "commands" (request/response) that didn't reflect Home Assistant Core's architecture where everything is just a WS command. - Remove dead WSClient.async_send_message (never called) - Rename async_send_message → _async_send_command (private, fire-and-forget) - Rename send_message → send_command (sync wrapper) - Simplify _ensure_connected: drop message param, always raise on failure - Simplify async_send_command: always raise on connection errors - Remove MIN_VERSION gating (minimum supported Core is now 2024.2+) - Remove begin_backup/end_backup version guards for Core < 2022.1.0 - Add debug logging for silently ignored connection errors Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Wait for Core to come up before backup This is crucial since the WebSocket command to Core now fails with the new error handling if Core is not running yet. * Wait for Core install job instead * Use CLI to fetch jobs instead of Supervisor API The Supervisor API needs authentication token, which we have not available at this point in the workflow. Instead of fetching the token, we can use the CLI, which is available in the container. --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
188 lines
6.8 KiB
Python
188 lines
6.8 KiB
Python
"""Test Homeassistant module."""
|
|
|
|
import asyncio
|
|
import errno
|
|
import logging
|
|
from pathlib import Path, PurePath
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
|
|
from supervisor.backups.backup import Backup
|
|
from supervisor.backups.const import BackupType
|
|
from supervisor.const import CoreState
|
|
from supervisor.coresys import CoreSys
|
|
from supervisor.docker.interface import DockerInterface
|
|
from supervisor.exceptions import (
|
|
HomeAssistantBackupError,
|
|
HomeAssistantWSConnectionError,
|
|
)
|
|
from supervisor.homeassistant.module import HomeAssistant
|
|
from supervisor.homeassistant.secrets import HomeAssistantSecrets
|
|
from supervisor.homeassistant.websocket import HomeAssistantWebSocket
|
|
from supervisor.utils.dt import utcnow
|
|
|
|
|
|
async def test_load(
|
|
coresys: CoreSys, tmp_supervisor_data: Path, ha_ws_client: AsyncMock
|
|
):
|
|
"""Test homeassistant module load."""
|
|
with open(
|
|
tmp_supervisor_data / "homeassistant" / "secrets.yaml", "w", encoding="utf-8"
|
|
) as secrets:
|
|
secrets.write("hello: world\n")
|
|
|
|
# Unwrap read_secrets to prevent throttling between tests
|
|
with (
|
|
patch.object(DockerInterface, "attach") as attach,
|
|
patch.object(DockerInterface, "check_image") as check_image,
|
|
patch.object(
|
|
HomeAssistantSecrets,
|
|
"_read_secrets",
|
|
new=HomeAssistantSecrets._read_secrets.__wrapped__, # pylint: disable=protected-access,no-member
|
|
),
|
|
):
|
|
await coresys.homeassistant.load()
|
|
|
|
attach.assert_called_once()
|
|
check_image.assert_called_once()
|
|
|
|
assert coresys.homeassistant.secrets.secrets == {"hello": "world"}
|
|
|
|
await coresys.core.set_state(CoreState.SETUP)
|
|
await coresys.homeassistant.websocket._async_send_command({"lorem": "ipsum"})
|
|
ha_ws_client.async_send_command.assert_not_called()
|
|
|
|
await coresys.core.set_state(CoreState.RUNNING)
|
|
await asyncio.sleep(0)
|
|
assert ha_ws_client.async_send_command.call_args_list[0][0][0] == {"lorem": "ipsum"}
|
|
|
|
|
|
async def test_get_users_none(coresys: CoreSys, ha_ws_client: AsyncMock):
|
|
"""Test get users returning none does not fail."""
|
|
ha_ws_client.async_send_command.return_value = None
|
|
assert (
|
|
await coresys.homeassistant.get_users.__wrapped__(coresys.homeassistant) == []
|
|
)
|
|
|
|
|
|
async def test_write_pulse_error(coresys: CoreSys, caplog: pytest.LogCaptureFixture):
|
|
"""Test errors writing pulse config."""
|
|
with patch(
|
|
"supervisor.homeassistant.module.Path.write_text",
|
|
side_effect=(err := OSError()),
|
|
):
|
|
err.errno = errno.EBUSY
|
|
await coresys.homeassistant.write_pulse()
|
|
|
|
assert "can't write pulse/client.config" in caplog.text
|
|
assert coresys.core.healthy is True
|
|
|
|
caplog.clear()
|
|
err.errno = errno.EBADMSG
|
|
await coresys.homeassistant.write_pulse()
|
|
|
|
assert "can't write pulse/client.config" in caplog.text
|
|
assert coresys.core.healthy is False
|
|
|
|
|
|
async def test_begin_backup_ws_error(coresys: CoreSys):
|
|
"""Test WS error when beginning backup."""
|
|
# pylint: disable-next=protected-access
|
|
coresys.homeassistant.websocket._client.async_send_command.side_effect = (
|
|
HomeAssistantWSConnectionError("Connection was closed")
|
|
)
|
|
with (
|
|
patch.object(HomeAssistantWebSocket, "_ensure_connected", return_value=None),
|
|
pytest.raises(
|
|
HomeAssistantBackupError,
|
|
match="Preparing backup of Home Assistant Core failed. Failed to inform HA Core: Connection was closed.",
|
|
),
|
|
):
|
|
await coresys.homeassistant.begin_backup()
|
|
|
|
|
|
async def test_end_backup_ws_error(coresys: CoreSys, caplog: pytest.LogCaptureFixture):
|
|
"""Test WS error when ending backup."""
|
|
# pylint: disable-next=protected-access
|
|
coresys.homeassistant.websocket._client.async_send_command.side_effect = (
|
|
HomeAssistantWSConnectionError("Connection was closed")
|
|
)
|
|
with patch.object(HomeAssistantWebSocket, "_ensure_connected", return_value=None):
|
|
await coresys.homeassistant.end_backup()
|
|
|
|
assert (
|
|
"Error resuming normal operations after backup of Home Assistant Core. Failed to inform HA Core: Connection was closed."
|
|
in caplog.text
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
("filename", "exclude_db", "expect_excluded", "subfolder"),
|
|
[
|
|
("home-assistant.log", False, True, None),
|
|
("home-assistant.log.1", False, True, None),
|
|
("home-assistant.log.fault", False, True, None),
|
|
("home-assistant.log", False, False, "subfolder"),
|
|
("OZW_Log.txt", False, True, None),
|
|
("OZW_Log.txt", False, False, "subfolder"),
|
|
("home-assistant_v2.db-shm", False, True, None),
|
|
("home-assistant_v2.db-shm", False, False, "subfolder"),
|
|
("home-assistant_v2.db", False, False, None),
|
|
("home-assistant_v2.db", True, True, None),
|
|
("home-assistant_v2.db", True, False, "subfolder"),
|
|
("home-assistant_v2.db-wal", False, False, None),
|
|
("home-assistant_v2.db-wal", True, True, None),
|
|
("home-assistant_v2.db-wal", True, False, "subfolder"),
|
|
("test.tar", False, True, "backups"),
|
|
("test.tar", False, False, "subfolder/backups"),
|
|
("test.tar", False, True, "tmp_backups"),
|
|
("test.tar", False, False, "subfolder/tmp_backups"),
|
|
("test", False, True, "tts"),
|
|
("test", False, False, "subfolder/tts"),
|
|
("test.cpython-312.pyc", False, True, "__pycache__"),
|
|
("test.cpython-312.pyc", False, True, "subfolder/__pycache__"),
|
|
(".DS_Store", False, True, None),
|
|
(".DS_Store", False, True, "subfolder"),
|
|
(
|
|
"core.restore_state.corrupt.2025-03-26T20:55:45.635297+00:00",
|
|
False,
|
|
True,
|
|
".storage",
|
|
),
|
|
],
|
|
)
|
|
@pytest.mark.usefixtures("tmp_supervisor_data")
|
|
async def test_backup_excludes(
|
|
coresys: CoreSys,
|
|
caplog: pytest.LogCaptureFixture,
|
|
filename: str,
|
|
exclude_db: bool,
|
|
expect_excluded: bool,
|
|
subfolder: str | None,
|
|
):
|
|
"""Test excludes in backup."""
|
|
parent = coresys.config.path_homeassistant
|
|
if subfolder:
|
|
test_path = PurePath(subfolder, filename)
|
|
parent = coresys.config.path_homeassistant / subfolder
|
|
parent.mkdir(parents=True)
|
|
else:
|
|
test_path = PurePath(filename)
|
|
|
|
(parent / filename).touch()
|
|
|
|
backup = Backup(coresys, coresys.config.path_backup / "test.tar", "test", None)
|
|
backup.new("test", utcnow().isoformat(), BackupType.PARTIAL)
|
|
async with backup.create():
|
|
with (
|
|
patch.object(HomeAssistant, "begin_backup"),
|
|
patch.object(HomeAssistant, "end_backup"),
|
|
caplog.at_level(logging.DEBUG, logger="supervisor.homeassistant.module"),
|
|
):
|
|
await backup.store_homeassistant(exclude_database=exclude_db)
|
|
|
|
assert (
|
|
f"Ignoring data/{test_path.as_posix()} because of " in caplog.text
|
|
) is expect_excluded
|