Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-20 16:49:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes terminal integration test timing

Browse Source
This commit is contained in:
Eric Amodio
2019-10-17 17:19:42 -04:00
parent 1ab47af535
commit 000006f0d1
1 changed files with 38 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts
View File

@@ -176,10 +176,30 @@ suite('window namespace tests', () => {
const reg2 = window.onDidWriteTerminalData(e => dataEvents.push({ name: e.terminal.name, data: e.data }));
const reg3 = window.onDidCloseTerminal(e => {
closeEvents.push(e.name);
if (closeEvents.length === 1) {
const term2Write = new EventEmitter<string>();
const term2Close = new EventEmitter<void>();
window.createTerminal({
name: 'test2', pty: {
onDidWrite: term2Write.event,
onDidClose: term2Close.event,
open: () => {
term2Write.fire('write2');
// Need to wait to ensure the data will be fired, because it will be buffered for 5ms (currently)
setTimeout(() => term2Close.fire(), 100);
},
close: () => { }
}
});
return;
}
if (closeEvents.length === 2) {
deepEqual(openEvents, [ 'test1', 'test2' ]);
deepEqual(dataEvents, [ { name: 'test1', data: 'write1' }, { name: 'test2', data: 'write2' } ]);
deepEqual(closeEvents, [ 'test1', 'test2' ]);
deepEqual(openEvents, ['test1', 'test2']);
deepEqual(dataEvents, [{ name: 'test1', data: 'write1' }, { name: 'test2', data: 'write2' }]);
deepEqual(closeEvents, ['test1', 'test2']);
reg1.dispose();
reg2.dispose();
reg3.dispose();
@@ -189,26 +209,18 @@ suite('window namespace tests', () => {
const term1Write = new EventEmitter<string>();
const term1Close = new EventEmitter<void>();
window.createTerminal({ name: 'test1', pty: {
onDidWrite: term1Write.event,
onDidClose: term1Close.event,
open: () => {
term1Write.fire('write1');
term1Close.fire();
const term2Write = new EventEmitter<string>();
const term2Close = new EventEmitter<void>();
window.createTerminal({ name: 'test2', pty: {
onDidWrite: term2Write.event,
onDidClose: term2Close.event,
open: () => {
term2Write.fire('write2');
term2Close.fire();
},
close: () => {}
}});
},
close: () => {}
}});
window.createTerminal({
name: 'test1', pty: {
onDidWrite: term1Write.event,
onDidClose: term1Close.event,
open: () => {
term1Write.fire('write1');
// Need to wait to ensure the data will be fired, because it will be buffered for 5ms (currently)
setTimeout(() => term1Close.fire(), 100);
},
close: () => { }
}
});
});
});
@@ -225,8 +237,8 @@ suite('window namespace tests', () => {
});
const pty: Pseudoterminal = {
onDidWrite: new EventEmitter<string>().event,
open: () => {},
close: () => {}
open: () => { },
close: () => { }
};
window.createTerminal({ name: 'c', pty });
});
@@ -303,7 +315,7 @@ suite('window namespace tests', () => {
open: () => {
overrideDimensionsEmitter.fire({ columns: 10, rows: 5 });
},
close: () => {}
close: () => { }
};
const terminal = window.createTerminal({ name: 'foo', pty });
});