From 00bb9bdefcfef4cb0ec92399e52dedee4b223ff7 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Wed, 27 Jul 2022 11:54:24 -0700 Subject: [PATCH] Always log tsserver exit code, even for kill processes (#156378) We suspect that some exit code info is being dropped since 1.61. Changing this code to always log, even when the user manually restarts the server --- .../src/typescriptServiceClient.ts | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/extensions/typescript-language-features/src/typescriptServiceClient.ts b/extensions/typescript-language-features/src/typescriptServiceClient.ts index b09593f6c59..4eec03b0471 100644 --- a/extensions/typescript-language-features/src/typescriptServiceClient.ts +++ b/extensions/typescript-language-features/src/typescriptServiceClient.ts @@ -430,13 +430,7 @@ export default class TypeScriptServiceClient extends Disposable implements IType }); handle.onExit((data: TypeScriptServerExitEvent) => { - if (this.token !== mytoken) { - // this is coming from an old process - return; - } - const { code, signal } = data; - if (code === null || typeof code === 'undefined') { this.info(`TSServer exited. Signal: ${signal}`); } else { @@ -456,6 +450,11 @@ export default class TypeScriptServiceClient extends Disposable implements IType this.logTelemetry('tsserver.exitWithCode', { code, signal: signal ?? undefined }); } + if (this.token !== mytoken) { + // this is coming from an old process + return; + } + if (handle.tsServerLogFile) { this.info(`TSServer log file: ${handle.tsServerLogFile}`); }