From 010f2bee0eb3df8024a26abd012827b17a162dd2 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Thu, 7 Nov 2019 08:56:38 -0800 Subject: [PATCH] Don't use Set ctor --- src/vs/editor/contrib/codeAction/codeActionWidget.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/vs/editor/contrib/codeAction/codeActionWidget.ts b/src/vs/editor/contrib/codeAction/codeActionWidget.ts index 06aa9f062317..03b9b036b8e2 100644 --- a/src/vs/editor/contrib/codeAction/codeActionWidget.ts +++ b/src/vs/editor/contrib/codeAction/codeActionWidget.ts @@ -95,18 +95,18 @@ export class CodeActionWidget extends Disposable { } private resolveKeybindings(actions: readonly CodeActionAction[]): Map { - const codeActionCommands = new Set([ + const codeActionCommands: readonly string[] = [ refactorCommandId, codeActionCommandId, sourceActionCommandId, organizeImportsCommandId, fixAllCommandId - ]); + ]; // Lazy since we may not actually ever read the value const allCodeActionBindings = new Lazy(() => this._keybindingService.getKeybindings() - .filter(item => codeActionCommands.has(item.command!)) + .filter(item => codeActionCommands.indexOf(item.command!) >= 0) .filter(item => item.resolvedKeybinding) .map((item): ResolveCodeActionKeybinding => { // Special case these commands since they come built-in with VS Code and don't use 'commandArgs'