webpack - more defaults for extensions

extensions/shared.webpack.config.js

@@ -6,15 +6,11 @@
 'use strict';
 
 const path = require('path');
+const CopyWebpackPlugin = require('copy-webpack-plugin');
+const merge = require('merge-options');
 
-/**
- * Function that must be invoked with __dirname and that
- * returns a good default configuation for extensions that
- * want to do webpack
- */
-module.exports = function (extensionDir) {
-	return {
-		context: extensionDir,
+module.exports = function withDefaults(extConfig) {
+	let defaultConfig = {
 		mode: 'none', // this leaves the source code as close as possible to the original (when packaging we set this to 'production')
 		target: 'node', // extensions run in a node context
 		resolve: {
@@ -43,14 +39,75 @@ module.exports = function (extensionDir) {
 				}]
 			}]
 		},
+		plugins: [
+			new CopyWebpackPlugin([{ from: './out/nls.*.json', to: '[name].json' }]) // copy nls files
+		],
+		externals: {
+			'vscode': 'commonjs vscode', // ignored because it doesn't exist
+		},
 		output: {
 			// all output goes into `dist`.
 			// packaging depends on that and this must always be like it
 			filename: '[name].js',
-			path: path.join(extensionDir, 'dist'),
+			path: path.join(extConfig.context, 'dist'),
 			libraryTarget: "commonjs",
 		},
 		// yes, really source maps
 		devtool: 'source-map'
-	};
-};
+	}
+
+	return merge(defaultConfig, extConfig);
+}
+
+// /**
+//  * Function that must be invoked with __dirname and that
+//  * returns a good default configuation for extensions that
+//  * want to do webpack
+//  */
+// module.exports = function (extensionDir) {
+// 	return {
+// 		context: extensionDir,
+// 		mode: 'none', // this leaves the source code as close as possible to the original (when packaging we set this to 'production')
+// 		target: 'node', // extensions run in a node context
+// 		resolve: {
+// 			mainFields: ['main'], // prefer the main-entry of package.json files
+// 			extensions: ['.ts', '.js'] // support ts-files and js-files
+// 		},
+// 		module: {
+// 			rules: [{
+// 				test: /\.ts$/,
+// 				exclude: /node_modules/,
+// 				use: [{
+// 					// vscode-nls-dev loader:
+// 					// * rewrite nls-calls
+// 					loader: 'vscode-nls-dev/lib/webpack-loader'
+// 				}, {
+// 					// configure TypeScript loader:
+// 					// * only transpile because we have a separate compilation pipeline
+// 					// * enable sources maps for end-to-end source maps
+// 					loader: 'ts-loader',
+// 					options: {
+// 						transpileOnly: true,
+// 						compilerOptions: {
+// 							"sourceMap": true,
+// 						}
+// 					}
+// 				}]
+// 			}]
+// 		},
+// 		plugins: [
+// 			new CopyWebpackPlugin([
+// 				{ from: './out/nls.*.json', to: '[name].json' }
+// 			])
+// 		],
+// 		output: {
+// 			// all output goes into `dist`.
+// 			// packaging depends on that and this must always be like it
+// 			filename: '[name].js',
+// 			path: path.join(extensionDir, 'dist'),
+// 			libraryTarget: "commonjs",
+// 		},
+// 		// yes, really source maps
+// 		devtool: 'source-map'
+// 	};
+// };