diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts index c9d3c977bca..552a75241de 100644 --- a/src/vs/vscode.proposed.d.ts +++ b/src/vs/vscode.proposed.d.ts @@ -1489,9 +1489,6 @@ declare module 'vscode' { // optional kernel interrupt command interruptHandler?: (notebook: NotebookDocument) => void - // // kernels (and _only_ they) can create executions - createNotebookCellExecutionTask(uri: Uri, index: number): NotebookCellExecutionTask; - // // kernels can establish IPC channels to (visible) notebook editors // createNotebookCommunication(editor: vscode.NotebookEditor): vscode.NotebookCommunication; diff --git a/src/vs/workbench/api/common/extHostNotebookKernels.ts b/src/vs/workbench/api/common/extHostNotebookKernels.ts index a813bb816b9..a6fb60aab11 100644 --- a/src/vs/workbench/api/common/extHostNotebookKernels.ts +++ b/src/vs/workbench/api/common/extHostNotebookKernels.ts @@ -113,9 +113,6 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape { data.supportsInterrupt = Boolean(value); _update(); }, - createNotebookCellExecutionTask(uri, index) { - return that._extHostNotebook.createNotebookCellExecution(uri, index, data.id)!; - }, dispose: () => { isDisposed = true; this._kernelData.delete(handle); @@ -150,12 +147,15 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape { const cells = document.notebookDocument.getCells(NotebookCellRange.to(range)); for (let cell of cells) { const exec = this._extHostNotebook.createNotebookCellExecution(document.uri, cell.index, obj.id); - // todo@jrieken there should always be an exec-object if (exec) { execs.push(exec); + } else { + // todo@jrieken there should always be an exec-object + console.warn('could NOT create notebook cell execution task for: ' + cell.document.uri); } } } + try { obj.executeHandler(execs); } catch (err) {