From 01c3eb72cbd84d974214006dc56dc07c489d1a24 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Sat, 2 Jun 2018 16:56:14 -0700 Subject: [PATCH] Register onData listener --- src/vs/workbench/api/node/extHostTerminalService.ts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/vs/workbench/api/node/extHostTerminalService.ts b/src/vs/workbench/api/node/extHostTerminalService.ts index a8e7a67c0bb..23ed4e70b31 100644 --- a/src/vs/workbench/api/node/extHostTerminalService.ts +++ b/src/vs/workbench/api/node/extHostTerminalService.ts @@ -131,11 +131,15 @@ export class ExtHostTerminal extends BaseExtHostTerminal implements vscode.Termi } export class ExtHostTerminalRenderer extends BaseExtHostTerminal implements vscode.TerminalRenderer { - public get name(): string { return this._name; } private readonly _onData: Emitter = new Emitter(); - public get onData(): Event { return this._onData && this._onData.event; } + public get onData(): Event { + // TODO: This needs to fire for keystrokes and sendText only for renderers + // Tell the main side to start sending data if it's not already + this._proxy.$registerOnDataListener(this._id); + return this._onData && this._onData.event; + } constructor( proxy: MainThreadTerminalServiceShape, @@ -149,7 +153,7 @@ export class ExtHostTerminalRenderer extends BaseExtHostTerminal implements vsco public write(data: string): void { this._checkDisposed(); - this._queueApiRequest(this._proxy.$write, []); + this._queueApiRequest(this._proxy.$write, [data]); } }