Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 19:18:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add null type annotations for the common x: T = null pattern

Browse Source 
In these cases, the programmer has explicitly indicated that the type should be nullable
This commit is contained in:
Matt Bierner
2018-10-11 14:13:20 -07:00
parent da546f5d5d
commit 0318e90c93
130 changed files with 257 additions and 221 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/vs/workbench/api/electron-browser/mainThreadDocumentsAndEditors.ts
View File

@@ -246,7 +246,7 @@ class MainThreadDocumentAndEditorStateComputer {
// editor: only take those that have a not too large model
const editors = new Map<string, TextEditorSnapshot>();
let activeEditor: string = null;
let activeEditor: string | null = null;
for (const editor of this._codeEditorService.listCodeEditors()) {
if (editor.isSimpleWidget) {

2
src/vs/workbench/api/electron-browser/mainThreadSaveParticipant.ts
View File

@@ -86,7 +86,7 @@ class TrimWhitespaceParticipant implements ISaveParticipantParticipant {
}
function findEditor(model: ITextModel, codeEditorService: ICodeEditorService): ICodeEditor {
let candidate: ICodeEditor = null;
let candidate: ICodeEditor | null = null;
if (model.isAttachedToEditor()) {
for (const editor of codeEditorService.listCodeEditors()) {

2
src/vs/workbench/api/node/extHost.api.impl.ts
View File

@@ -97,7 +97,7 @@ export function createApiFactory(
extHostLogService: ExtHostLogService
): IExtensionApiFactory {
let schemeTransformer: ISchemeTransformer = null;
let schemeTransformer: ISchemeTransformer | null = null;
// Addressable instances
rpcProtocol.set(ExtHostContext.ExtHostLogService, extHostLogService);

2
src/vs/workbench/api/node/extHostExtensionService.ts
View File

@@ -407,7 +407,7 @@ export class ExtHostExtensionService implements ExtHostExtensionServiceShape {
}
function loadCommonJSModule<T>(logService: ILogService, modulePath: string, activationTimesBuilder: ExtensionActivationTimesBuilder): TPromise<T> {
let r: T = null;
let r: T | null = null;
activationTimesBuilder.codeLoadingStart();
logService.info(`ExtensionService#loadCommonJSModule ${modulePath}`);
try {

2
src/vs/workbench/api/node/extHostTerminalService.ts
View File

@@ -487,7 +487,7 @@ export class ExtHostTerminalService implements ExtHostTerminalServiceShape {
}
private _getTerminalObjectIndexById<T extends ExtHostTerminal | ExtHostTerminalRenderer>(array: T[], id: number): number {
let index: number = null;
let index: number | null = null;
array.some((item, i) => {
const thisId = item._id;
if (thisId === id) {

4
src/vs/workbench/api/node/extHostTextEditor.ts
View File

@@ -76,7 +76,7 @@ export class TextEditorEdit {
}
replace(location: Position | Range | Selection, value: string): void {
let range: Range = null;
let range: Range | null = null;
if (location instanceof Position) {
range = new Range(location, location);
@@ -94,7 +94,7 @@ export class TextEditorEdit {
}
delete(location: Range | Selection): void {
let range: Range = null;
let range: Range | null = null;
if (location instanceof Range) {
range = location;