Commenting range resource change proposal (#206346)

Part of #185551
This commit is contained in:
Alex Ross
2024-02-27 15:16:20 +01:00
committed by GitHub
parent 0c3664116e
commit 03bd0bb8d1
8 changed files with 65 additions and 3 deletions

View File

@@ -563,8 +563,17 @@ export function createExtHostComments(mainContext: IMainContext, commands: ExtHo
return this._commentingRangeProvider;
}
private _commentingRangeProviderResourcesChanged: vscode.Disposable | undefined;
set commentingRangeProvider(provider: vscode.CommentingRangeProvider | undefined) {
this._commentingRangeProvider = provider;
this._commentingRangeProviderResourcesChanged?.dispose();
this._commentingRangeProviderResourcesChanged = undefined;
if (this._commentingRangeProvider?.onDidChangeResourcesWithCommentingRanges) {
checkProposedApiEnabled(this._extension, 'commentingRangeResourcesChanged');
this._commentingRangeProviderResourcesChanged = this._commentingRangeProvider.onDidChangeResourcesWithCommentingRanges(e => {
proxy.$onDidChangeResourcesWithCommentingRanges(this.handle, e.schemes, e.resources);
});
}
proxy.$updateCommentingRanges(this.handle);
}
@@ -695,7 +704,7 @@ export function createExtHostComments(mainContext: IMainContext, commands: ExtHo
this._threads.forEach(value => {
value.dispose();
});
this._commentingRangeProviderResourcesChanged?.dispose();
this._localDisposables.forEach(disposable => disposable.dispose());
}
}