Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 11:08:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

Extension tests cannot use test frameworks that call process.exit (fixes #37708)

Browse Source
This commit is contained in:
Benjamin Pasero
2017-11-09 07:49:42 +01:00
parent 0fbdfff167
commit 04659ba395
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/vs/workbench/node/extensionHostMain.ts
View File

@@ -23,10 +23,16 @@ import * as watchdog from 'native-watchdog';
import * as glob from 'vs/base/common/glob';
// const nativeExit = process.exit.bind(process);
process.exit = function () {
const err = new Error('An extension called process.exit() and this was prevented.');
console.warn(err.stack);
};
function patchExit(allowExit: boolean) {
process.exit = function (code) {
if (allowExit) {
exit(code);
} else {
const err = new Error('An extension called process.exit() and this was prevented.');
console.warn(err.stack);
}
};
}
export function exit(code?: number) {
//nativeExit(code);
@@ -66,6 +72,9 @@ export class ExtensionHostMain {
this._environment = initData.environment;
this._workspace = initData.workspace;
const allowExit = !!this._environment.extensionTestsPath; // to support other test frameworks like Jasmin that use process.exit (https://github.com/Microsoft/vscode/issues/37708)
patchExit(allowExit);
// services
const threadService = new ExtHostThreadService(rpcProtocol);
const extHostWorkspace = new ExtHostWorkspace(threadService, initData.workspace);