From 04dcda4b3ba4e5b7bf46ce47ef7099dee98fe348 Mon Sep 17 00:00:00 2001 From: Connor Peet Date: Tue, 3 Aug 2021 16:34:51 -0700 Subject: [PATCH] testing: fix clear results leaving progress text Fixes #129763 --- .../workbench/contrib/testing/browser/testingExplorerView.ts | 3 ++- .../contrib/testing/browser/testingProgressUiService.ts | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/testing/browser/testingExplorerView.ts b/src/vs/workbench/contrib/testing/browser/testingExplorerView.ts index 2f62c95978b..1dfaf5309fe 100644 --- a/src/vs/workbench/contrib/testing/browser/testingExplorerView.ts +++ b/src/vs/workbench/contrib/testing/browser/testingExplorerView.ts @@ -133,9 +133,10 @@ export class TestingExplorerView extends ViewPane { const messagesContainer = dom.append(this.treeHeader, dom.$('.test-explorer-messages')); this._register(this.testProgressService.onTextChange(text => { const hadText = !!messagesContainer.innerText; + const hasText = !!text; messagesContainer.innerText = text; - if (!hadText) { + if (hadText !== hasText) { this.layoutBody(); } })); diff --git a/src/vs/workbench/contrib/testing/browser/testingProgressUiService.ts b/src/vs/workbench/contrib/testing/browser/testingProgressUiService.ts index 1e6dc08c178..b22b615c6ca 100644 --- a/src/vs/workbench/contrib/testing/browser/testingProgressUiService.ts +++ b/src/vs/workbench/contrib/testing/browser/testingProgressUiService.ts @@ -60,6 +60,9 @@ export class TestingProgressUiService extends Disposable implements ITestingProg const collected = collectTestStateCounts(false, allResults[0].counts); this.updateCountsEmitter.fire(collected); this.updateTextEmitter.fire(getTestProgressText(false, collected)); + } else { + this.updateTextEmitter.fire(''); + this.updateCountsEmitter.fire(collectTestStateCounts(false)); } this.current.clear();