From 053a32e2bbc354af2b19cb40758f615cefcb714e Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Thu, 18 Apr 2019 07:43:44 +0200 Subject: [PATCH] tests updates --- .../src/singlefolder-tests/window.test.ts | 25 ++++++++++--------- .../files/test/node/diskFileService.test.ts | 6 ++++- 2 files changed, 18 insertions(+), 13 deletions(-) diff --git a/extensions/vscode-api-tests/src/singlefolder-tests/window.test.ts b/extensions/vscode-api-tests/src/singlefolder-tests/window.test.ts index b9556197469..f6844162017 100644 --- a/extensions/vscode-api-tests/src/singlefolder-tests/window.test.ts +++ b/extensions/vscode-api-tests/src/singlefolder-tests/window.test.ts @@ -518,19 +518,20 @@ suite('window namespace tests', () => { return Promise.all([a, b]); }); - test('showWorkspaceFolderPick', async function () { - const p = window.showWorkspaceFolderPick(undefined); + // TODO@chrmarti Disabled due to flaky behaviour (https://github.com/Microsoft/vscode/issues/70887) + // test('showWorkspaceFolderPick', async function () { + // const p = window.showWorkspaceFolderPick(undefined); - await timeout(10); - await commands.executeCommand('workbench.action.acceptSelectedQuickOpenItem'); - try { - await p; - assert.ok(true); - } - catch (_error) { - assert.ok(false); - } - }); + // await timeout(10); + // await commands.executeCommand('workbench.action.acceptSelectedQuickOpenItem'); + // try { + // await p; + // assert.ok(true); + // } + // catch (_error) { + // assert.ok(false); + // } + // }); test('Default value for showInput Box not accepted when it fails validateInput, reversing #33691', async function () { const result = window.showInputBox({ diff --git a/src/vs/workbench/services/files/test/node/diskFileService.test.ts b/src/vs/workbench/services/files/test/node/diskFileService.test.ts index 23e2494de30..36d67dd926f 100644 --- a/src/vs/workbench/services/files/test/node/diskFileService.test.ts +++ b/src/vs/workbench/services/files/test/node/diskFileService.test.ts @@ -1491,7 +1491,11 @@ suite('Disk File Service', () => { setTimeout(() => mkdirSync(folder.fsPath), 50); }); - test.skip('watch - folder (non recursive) - delete folder', done => { + test('watch - folder (non recursive) - delete folder', done => { + if (isWindows) { + return done(); // not happy + } + const watchDir = URI.file(join(testDir, 'watch7')); mkdirSync(watchDir.fsPath);