Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-18 23:59:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove notebook editor edit api (#158988)

Browse Source 
Fixes #149181
This commit is contained in:
Matt Bierner
2022-08-29 09:34:57 -07:00
committed by GitHub
parent 86d5fc5eba
commit 07025f0b0d
11 changed files with 38 additions and 238 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/vscode-api-tests/src/singlefolder-tests/notebook.api.test.ts
View File

@@ -294,7 +294,7 @@ const apiTestContentProvider: vscode.NotebookContentProvider = {
await provideCalled;
const edit = new vscode.WorkspaceEdit();
edit.replaceNotebookCellMetadata(notebook.uri, 0, { inputCollapsed: true });
edit.set(notebook.uri, [vscode.NotebookEdit.updateCellMetadata(0, { inputCollapsed: true })]);
await vscode.workspace.applyEdit(edit);
await provideCalled;
});

32
extensions/vscode-api-tests/src/singlefolder-tests/notebook.document.test.ts
View File

@@ -173,7 +173,7 @@ suite('Notebook Document', function () {
// inserting two new cells
{
const edit = new vscode.WorkspaceEdit();
edit.replaceNotebookCells(document.uri, new vscode.NotebookRange(0, 0), [{
edit.set(document.uri, [vscode.NotebookEdit.replaceCells(new vscode.NotebookRange(0, 0), [{
kind: vscode.NotebookCellKind.Markup,
languageId: 'markdown',
metadata: undefined,
@@ -185,7 +185,7 @@ suite('Notebook Document', function () {
metadata: undefined,
outputs: [],
value: 'new_code'
}]);
}])]);
const success = await vscode.workspace.applyEdit(edit);
assert.strictEqual(success, true);
@@ -198,8 +198,10 @@ suite('Notebook Document', function () {
// deleting cell 1 and 3
{
const edit = new vscode.WorkspaceEdit();
edit.replaceNotebookCells(document.uri, new vscode.NotebookRange(0, 1), []);
edit.replaceNotebookCells(document.uri, new vscode.NotebookRange(2, 3), []);
edit.set(document.uri, [
vscode.NotebookEdit.replaceCells(new vscode.NotebookRange(0, 1), []),
vscode.NotebookEdit.replaceCells(new vscode.NotebookRange(2, 3), [])
]);
const success = await vscode.workspace.applyEdit(edit);
assert.strictEqual(success, true);
}
@@ -210,7 +212,7 @@ suite('Notebook Document', function () {
// replacing all cells
{
const edit = new vscode.WorkspaceEdit();
edit.replaceNotebookCells(document.uri, new vscode.NotebookRange(0, 1), [{
edit.set(document.uri, [vscode.NotebookEdit.replaceCells(new vscode.NotebookRange(0, 1), [{
kind: vscode.NotebookCellKind.Markup,
languageId: 'markdown',
metadata: undefined,
@@ -222,7 +224,7 @@ suite('Notebook Document', function () {
metadata: undefined,
outputs: [],
value: 'new2_code'
}]);
}])]);
const success = await vscode.workspace.applyEdit(edit);
assert.strictEqual(success, true);
}
@@ -233,7 +235,7 @@ suite('Notebook Document', function () {
// remove all cells
{
const edit = new vscode.WorkspaceEdit();
edit.replaceNotebookCells(document.uri, new vscode.NotebookRange(0, document.cellCount), []);
edit.set(document.uri, [vscode.NotebookEdit.replaceCells(new vscode.NotebookRange(0, document.cellCount), [])]);
const success = await vscode.workspace.applyEdit(edit);
assert.strictEqual(success, true);
}
@@ -246,7 +248,7 @@ suite('Notebook Document', function () {
assert.strictEqual(document.cellCount, 1);
const edit = new vscode.WorkspaceEdit();
edit.replaceNotebookCells(document.uri, new vscode.NotebookRange(0, 0), [{
edit.set(document.uri, [vscode.NotebookEdit.replaceCells(new vscode.NotebookRange(0, 0), [{
kind: vscode.NotebookCellKind.Markup,
languageId: 'markdown',
metadata: undefined,
@@ -258,7 +260,7 @@ suite('Notebook Document', function () {
metadata: undefined,
outputs: [],
value: 'new_code'
}]);
}])]);
const event = utils.asPromise<vscode.NotebookDocumentChangeEvent>(vscode.workspace.onDidChangeNotebookDocument);
@@ -287,7 +289,7 @@ suite('Notebook Document', function () {
const document = await vscode.workspace.openNotebookDocument(uri);
const edit = new vscode.WorkspaceEdit();
edit.replaceNotebookCellMetadata(document.uri, 0, { inputCollapsed: true });
edit.set(document.uri, [vscode.NotebookEdit.updateCellMetadata(0, { inputCollapsed: true })]);
const success = await vscode.workspace.applyEdit(edit);
assert.strictEqual(success, true);
assert.strictEqual(document.cellAt(0).metadata.inputCollapsed, true);
@@ -300,7 +302,7 @@ suite('Notebook Document', function () {
const edit = new vscode.WorkspaceEdit();
const event = utils.asPromise<vscode.NotebookDocumentChangeEvent>(vscode.workspace.onDidChangeNotebookDocument);
edit.replaceNotebookCellMetadata(document.uri, 0, { inputCollapsed: true });
edit.set(document.uri, [vscode.NotebookEdit.updateCellMetadata(0, { inputCollapsed: true })]);
const success = await vscode.workspace.applyEdit(edit);
assert.strictEqual(success, true);
const data = await event;
@@ -338,7 +340,7 @@ suite('Notebook Document', function () {
assert.strictEqual(notebook.notebookType, 'notebook.nbdtest');
const edit = new vscode.WorkspaceEdit();
edit.replaceNotebookCells(notebook.uri, new vscode.NotebookRange(0, 0), [{
edit.set(notebook.uri, [vscode.NotebookEdit.replaceCells(new vscode.NotebookRange(0, 0), [{
kind: vscode.NotebookCellKind.Markup,
languageId: 'markdown',
metadata: undefined,
@@ -350,7 +352,7 @@ suite('Notebook Document', function () {
metadata: undefined,
outputs: [],
value: 'new_code'
}]);
}])]);
const success = await vscode.workspace.applyEdit(edit);
assert.strictEqual(success, true);
@@ -399,7 +401,7 @@ suite('Notebook Document', function () {
assert.strictEqual(document.isDirty, false);
const edit = new vscode.WorkspaceEdit();
edit.replaceNotebookCells(document.uri, new vscode.NotebookRange(0, document.cellCount), []);
edit.set(document.uri, [vscode.NotebookEdit.replaceCells(new vscode.NotebookRange(0, document.cellCount), [])]);
assert.ok(await vscode.workspace.applyEdit(edit));
assert.strictEqual(document.isDirty, true);
@@ -414,7 +416,7 @@ suite('Notebook Document', function () {
assert.strictEqual(document.isDirty, false);
const edit = new vscode.WorkspaceEdit();
edit.replaceNotebookCells(document.uri, new vscode.NotebookRange(0, document.cellCount), []);
edit.set(document.uri, [vscode.NotebookEdit.replaceCells(new vscode.NotebookRange(0, document.cellCount), [])]);
assert.ok(await vscode.workspace.applyEdit(edit));
assert.strictEqual(document.isDirty, true);

2
extensions/vscode-api-tests/src/singlefolder-tests/notebook.kernel.test.ts
View File

@@ -406,7 +406,7 @@ const apiTestContentProvider: vscode.NotebookContentProvider = {
// Delete executing cell
const edit = new vscode.WorkspaceEdit();
edit.replaceNotebookCells(cell!.notebook.uri, new vscode.NotebookRange(cell!.index, cell!.index + 1), []);
edit.set(cell!.notebook.uri, [vscode.NotebookEdit.replaceCells(new vscode.NotebookRange(cell!.index, cell!.index + 1), [])]);
await vscode.workspace.applyEdit(edit);
assert.strictEqual(executionWasCancelled, true);