diff --git a/extensions/markdown-language-features/src/commands/openImage.ts b/extensions/markdown-language-features/src/commands/openImage.ts index 30026f7467d..7a0562db446 100644 --- a/extensions/markdown-language-features/src/commands/openImage.ts +++ b/extensions/markdown-language-features/src/commands/openImage.ts @@ -14,9 +14,9 @@ export class OpenImageCommand implements Command { private readonly _webviewManager: MarkdownPreviewManager, ) { } - public execute(args: { resource: string, imageSource: string }) { + public execute(args: { resource: string; imageSource: string }) { const source = vscode.Uri.parse(args.resource); - const { fsPath } = vscode.Uri.parse(args.imageSource); - this._webviewManager.findPreview(source)?.openImage(fsPath); + const imageSource = vscode.Uri.file(vscode.Uri.parse(args.imageSource).path); + vscode.commands.executeCommand('vscode.open', imageSource, this._webviewManager.findPreview(source)); } } diff --git a/extensions/markdown-language-features/src/preview/preview.ts b/extensions/markdown-language-features/src/preview/preview.ts index 9e4ae20e064..7ccbc625b47 100644 --- a/extensions/markdown-language-features/src/preview/preview.ts +++ b/extensions/markdown-language-features/src/preview/preview.ts @@ -443,7 +443,6 @@ export interface IManagedMarkdownPreview { readonly onDidChangeViewState: vscode.Event; copyImage(id: string): void; - openImage(imagePath: string): void; dispose(): void; refresh(): void; updateConfiguration(): void; @@ -525,12 +524,6 @@ export class StaticMarkdownPreview extends Disposable implements IManagedMarkdow }); } - openImage(imagePath: string): void { - const uri = vscode.Uri.file(imagePath); - this._webviewPanel.reveal(); - vscode.commands.executeCommand('vscode.open', uri); - } - private readonly _onDispose = this._register(new vscode.EventEmitter()); public readonly onDispose = this._onDispose.event; @@ -686,12 +679,6 @@ export class DynamicMarkdownPreview extends Disposable implements IManagedMarkdo }); } - openImage(imagePath: string): void { - const uri = vscode.Uri.file(imagePath); - this._webviewPanel.reveal(); - vscode.commands.executeCommand('vscode.open', uri); - } - private readonly _onDisposeEmitter = this._register(new vscode.EventEmitter()); public readonly onDispose = this._onDisposeEmitter.event;