Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 02:58:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

adopt changes after feedback round one

Browse Source
This commit is contained in:
Johannes Rieken
2020-09-25 18:00:11 +02:00
parent 611bbad868
commit 08695ede81
6 changed files with 57 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
extensions/vscode-notebook-tests/src/notebook.test.ts
View File

@@ -423,27 +423,24 @@ suite('Notebook API tests', () => {
await vscode.commands.executeCommand('vscode.openWith', resource, 'notebookCoreTest');
await vscode.notebook.activeNotebookEditor!.edit(editBuilder => {
editBuilder.replaceCellOutput(0, [
editBuilder.replaceCellOutput(0, [new vscode.NotebookCellOutputList([
new vscode.NotebookCellOutput('application/foo', 'bar'),
new vscode.NotebookCellOutput('application/json', { data: true }, { metadata: true }),
]);
])]);
});
const document = vscode.notebook.activeNotebookEditor?.document!;
assert.strictEqual(document.isDirty, true);
assert.strictEqual(document.cells.length, 1);
assert.strictEqual(document.cells[0].outputs.length, 2);
assert.strictEqual(document.cells[0].outputs.length, 1);
// consuming is OLD api
const [one, two] = document.cells[0].outputs;
// consuming is OLD api (for now)
const [output] = document.cells[0].outputs;
assert.strictEqual(one.outputKind, vscode.CellOutputKind.Rich);
assert.strictEqual((<vscode.CellDisplayOutput>one).data['application/foo'], 'bar');
assert.strictEqual((<vscode.CellDisplayOutput>one).metadata, undefined);
assert.strictEqual(two.outputKind, vscode.CellOutputKind.Rich);
assert.deepStrictEqual((<vscode.CellDisplayOutput>two).data['application/json'], { data: true });
assert.deepStrictEqual((<vscode.CellDisplayOutput>two).metadata, { custom: { metadata: true } });
assert.strictEqual(output.outputKind, vscode.CellOutputKind.Rich);
assert.strictEqual((<vscode.CellDisplayOutput>output).data['application/foo'], 'bar');
assert.deepStrictEqual((<vscode.CellDisplayOutput>output).data['application/json'], { data: true });
assert.deepStrictEqual((<vscode.CellDisplayOutput>output).metadata, { custom: { 'application/json': { metadata: true } } });
await saveAllFilesAndCloseAll(undefined);
});