From 08e9e778dcd11e6bc95d80a9d7e633d318e4f99b Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Mon, 2 Oct 2023 15:22:02 +0200 Subject: [PATCH] allow moving view containers always (#194607) #194606 allow moving view containers always --- src/vs/workbench/browser/parts/compositeBar.ts | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/vs/workbench/browser/parts/compositeBar.ts b/src/vs/workbench/browser/parts/compositeBar.ts index afa384aa88c..4fc6203d310 100644 --- a/src/vs/workbench/browser/parts/compositeBar.ts +++ b/src/vs/workbench/browser/parts/compositeBar.ts @@ -59,11 +59,6 @@ export class CompositeDragAndDrop implements ICompositeDragAndDrop { } // ... on a different composite bar else { - const viewsToMove = this.viewDescriptorService.getViewContainerModel(currentContainer)!.allViewDescriptors; - if (viewsToMove.some(v => !v.canMoveView)) { - return; - } - this.viewDescriptorService.moveViewContainerToLocation(currentContainer, this.targetContainerLocation, this.getTargetIndex(targetCompositeId, before)); } } @@ -118,11 +113,7 @@ export class CompositeDragAndDrop implements ICompositeDragAndDrop { return dragData.id !== targetCompositeId; } - // ... to another composite location - const draggedViews = this.viewDescriptorService.getViewContainerModel(currentContainer)!.allViewDescriptors; - - // ... all views must be movable - return !draggedViews.some(view => !view.canMoveView); + return true; } else { // Dragging an individual view