From 09c324fef8a68e1a3dca018cfbee30d574004684 Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Thu, 2 Feb 2017 21:24:39 +0100 Subject: [PATCH] Fix #19741 --- .../parts/preferences/browser/preferencesRenderers.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/parts/preferences/browser/preferencesRenderers.ts b/src/vs/workbench/parts/preferences/browser/preferencesRenderers.ts index d000a53e5276..5e8f4dcb4e94 100644 --- a/src/vs/workbench/parts/preferences/browser/preferencesRenderers.ts +++ b/src/vs/workbench/parts/preferences/browser/preferencesRenderers.ts @@ -861,6 +861,7 @@ class UnsupportedWorkspaceSettingsRenderer extends Disposable { @IMarkerService private markerService: IMarkerService ) { super(); + this._register(this.configurationService.onDidUpdateConfiguration(() => this.render())); } private getMarkerMessage(settingKey): string { @@ -889,8 +890,10 @@ class UnsupportedWorkspaceSettingsRenderer extends Disposable { }); } } - if (markerData.length > 0) { + if (markerData.length) { this.markerService.changeOne('preferencesEditor', this.workspaceSettingsEditorModel.uri, markerData); + } else { + this.markerService.remove('preferencesEditor', [this.workspaceSettingsEditorModel.uri]); } } }