diff --git a/.github/workflows/screenshot-test.yml b/.github/workflows/screenshot-test.yml index a45f8d38133..9907b0ccee8 100644 --- a/.github/workflows/screenshot-test.yml +++ b/.github/workflows/screenshot-test.yml @@ -1,4 +1,4 @@ -name: Screenshot Tests +name: Checking Component Screenshots on: push: @@ -20,6 +20,7 @@ concurrency: jobs: screenshots: + name: Checking Component Screenshots runs-on: ubuntu-latest steps: - name: Checkout @@ -95,39 +96,42 @@ jobs: REPORT="test/componentFixtures/.screenshots/report/report.json" if [ -f "$REPORT" ]; then CHANGED=$(node -e "const r = require('./$REPORT'); console.log(r.summary.added + r.summary.removed + r.summary.changed)") - TITLE="${CHANGED} screenshots changed" + TITLE="📸 ${CHANGED} screenshots changed" + CONCLUSION="neutral" else - TITLE="Screenshots match" + TITLE="📸 Screenshots match" + CONCLUSION="success" fi SHA="${{ github.event.pull_request.head.sha || github.sha }}" - CHECK_RUN_ID=$(gh api "repos/${{ github.repository }}/commits/$SHA/check-runs" \ - --jq '.check_runs[] | select(.name == "screenshots") | .id') - DETAILS_URL="https://hediet-ghartifactpreview.azurewebsites.net/${{ github.repository }}/run/${{ github.run_id }}/component-explorer/___explorer.html?report=./screenshot-report/report.json" + EXPLORER_PUSHED=false + if gh api "repos/${{ github.repository }}/check-runs" \ + --input - <> $GITHUB_STEP_SUMMARY - else - echo "## Screenshots ✅" >> $GITHUB_STEP_SUMMARY - echo "No visual changes detected." >> $GITHUB_STEP_SUMMARY - fi - # - name: Post PR comment # if: github.event_name == 'pull_request' # env: diff --git a/.vscode/tasks.json b/.vscode/tasks.json index 8353bc02c75..e950c75d912 100644 --- a/.vscode/tasks.json +++ b/.vscode/tasks.json @@ -385,6 +385,11 @@ "file": 1, "line": 2, "column": 3 + }, + "background": { + "activeOnStart": true, + "beginsPattern": ".*Setting up sessions.*", + "endsPattern": "Redirection server listening on.*" } } } diff --git a/build/vite/vite.config.ts b/build/vite/vite.config.ts index cdae205f030..24aaa12c026 100644 --- a/build/vite/vite.config.ts +++ b/build/vite/vite.config.ts @@ -143,11 +143,8 @@ const logger = createLogger(); const loggerWarn = logger.warn; logger.warn = (msg, options) => { - // amdX and the baseUrl code cannot be analyzed by vite. - // However, they are not needed, so it is okay to silence the warning. - if (msg.indexOf('vs/amdX.ts') !== -1) { - return; - } + // the baseUrl code cannot be analyzed by vite. + // However, it is not needed, so it is okay to silence the warning. if (msg.indexOf('await import(new URL(`vs/workbench/workbench.desktop.main.js`, baseUrl).href)') !== -1) { return; } diff --git a/src/vs/amdX.ts b/src/vs/amdX.ts index 374d4f19faf..98290fdc2b4 100644 --- a/src/vs/amdX.ts +++ b/src/vs/amdX.ts @@ -171,15 +171,15 @@ class AMDModuleImporter { if (this._amdPolicy) { scriptSrc = this._amdPolicy.createScriptURL(scriptSrc) as unknown as string; } - await import(scriptSrc); + await import(/* @vite-ignore */ scriptSrc); return this._defineCalls.pop(); } private async _nodeJSLoadScript(scriptSrc: string): Promise { try { - const fs = (await import(`${'fs'}`)).default; - const vm = (await import(`${'vm'}`)).default; - const module = (await import(`${'module'}`)).default; + const fs = (await import(/* @vite-ignore */ `${'fs'}`)).default; + const vm = (await import(/* @vite-ignore */ `${'vm'}`)).default; + const module = (await import(/* @vite-ignore */ `${'module'}`)).default; const filePath = URI.parse(scriptSrc).fsPath; const content = fs.readFileSync(filePath).toString();